* [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1
@ 2023-10-01 17:19 Caleb Connolly
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Caleb Connolly @ 2023-10-01 17:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, ~postmarketos/upstreaming, phone-devel,
Caleb Connolly, Joel Selvaraj
Like the SHIFT6mq, these devices both feature a dual-tone flash, enable
them.
Both patches have been shipping in postmarketOS for a few months now with no
known issues.
---
Caleb Connolly (1):
arm64: dts: qcom: sdm845-oneplus: enable flash LED
Joel Selvaraj (1):
arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led
.../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 23 ++++++++++++++++++++++
.../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 22 +++++++++++++++++++++
2 files changed, 45 insertions(+)
---
base-commit: 4b9e79bf480770216d598ed9383c675d50b0ae92
// Caleb (they/them)
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
2023-10-01 17:19 [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Caleb Connolly
@ 2023-10-01 17:19 ` Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
2023-10-28 10:39 ` Pavel Machek
2023-10-01 17:19 ` [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led Caleb Connolly
2023-10-22 15:50 ` [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Bjorn Andersson
2 siblings, 2 replies; 7+ messages in thread
From: Caleb Connolly @ 2023-10-01 17:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, ~postmarketos/upstreaming, phone-devel,
Caleb Connolly
Both the 6 and 6T feature a dual tone flash, enable it.
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
.../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index b523b5fff702..e821103d49c0 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -8,6 +8,7 @@
/dts-v1/;
#include <dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include <dt-bindings/sound/qcom,q6afe.h>
#include <dt-bindings/sound/qcom,q6asm.h>
@@ -484,6 +485,28 @@ &pmi8998_charger {
status = "okay";
};
+&pmi8998_flash {
+ status = "okay";
+
+ led-0 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>;
+ led-max-microamp = <500000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1280000>;
+ };
+
+ led-1 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_YELLOW>;
+ led-sources = <2>;
+ led-max-microamp = <500000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1280000>;
+ };
+};
+
&q6afedai {
qi2s@22 {
reg = <22>;
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
@ 2023-10-02 9:15 ` Konrad Dybcio
2023-10-28 10:39 ` Pavel Machek
1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-10-02 9:15 UTC (permalink / raw)
To: Caleb Connolly, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, ~postmarketos/upstreaming, phone-devel
On 10/1/23 19:19, Caleb Connolly wrote:
> Both the 6 and 6T feature a dual tone flash, enable it.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
@ 2023-10-28 10:39 ` Pavel Machek
1 sibling, 0 replies; 7+ messages in thread
From: Pavel Machek @ 2023-10-28 10:39 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
~postmarketos/upstreaming, phone-devel
Hi!
> + led-1 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_YELLOW>;
That's warm white, not yellow. We should likely create a define for
that.
BR,
Pavel
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led
2023-10-01 17:19 [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Caleb Connolly
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
@ 2023-10-01 17:19 ` Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
2023-10-22 15:50 ` [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Bjorn Andersson
2 siblings, 1 reply; 7+ messages in thread
From: Caleb Connolly @ 2023-10-01 17:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, ~postmarketos/upstreaming, phone-devel,
Joel Selvaraj, Caleb Connolly
From: Joel Selvaraj <joelselvaraj.oss@gmail.com>
Configure and enable the dual-tone on the PocoPhone F1
Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
.../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 93b1582e807d..617b17b2d7d9 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -355,6 +355,28 @@ &pmi8998_charger {
status = "okay";
};
+&pmi8998_flash {
+ status = "okay";
+
+ led-0 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>;
+ led-max-microamp = <500000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1280000>;
+ };
+
+ led-1 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_YELLOW>;
+ led-sources = <2>;
+ led-max-microamp = <500000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1280000>;
+ };
+};
+
&pm8998_resin {
linux,code = <KEY_VOLUMEDOWN>;
status = "okay";
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led
2023-10-01 17:19 ` [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led Caleb Connolly
@ 2023-10-02 9:15 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-10-02 9:15 UTC (permalink / raw)
To: Caleb Connolly, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, ~postmarketos/upstreaming, phone-devel,
Joel Selvaraj
On 10/1/23 19:19, Caleb Connolly wrote:
> From: Joel Selvaraj <joelselvaraj.oss@gmail.com>
>
> Configure and enable the dual-tone on the PocoPhone F1
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1
2023-10-01 17:19 [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Caleb Connolly
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
2023-10-01 17:19 ` [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led Caleb Connolly
@ 2023-10-22 15:50 ` Bjorn Andersson
2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-10-22 15:50 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Caleb Connolly
Cc: linux-arm-msm, devicetree, ~postmarketos/upstreaming, phone-devel,
Joel Selvaraj
On Sun, 01 Oct 2023 18:19:02 +0100, Caleb Connolly wrote:
> Like the SHIFT6mq, these devices both feature a dual-tone flash, enable
> them.
>
> Both patches have been shipping in postmarketOS for a few months now with no
> known issues.
>
Applied, thanks!
[1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
commit: 84b160876b4d8a97dc0feccc4426fefbc396d414
[2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led
commit: 7eedf7d6faaf0dd0807fff2ee595433faf08d138
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-28 10:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-01 17:19 [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Caleb Connolly
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
2023-10-28 10:39 ` Pavel Machek
2023-10-01 17:19 ` [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
2023-10-22 15:50 ` [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.