All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush
@ 2023-11-09 19:21 ` Vinay Belgaumkar
  0 siblings, 0 replies; 11+ messages in thread
From: Vinay Belgaumkar @ 2023-11-09 19:21 UTC (permalink / raw)
  To: intel-gfx, dri-devel

We read RENDER_HEAD as a part of the flush. If GT is in
deeper sleep states, this could lead to read errors since we are
not using a forcewake. Safer to read a shadowed register instead.

Cc: John Harrison <john.c.harrison@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index ed32bf5b1546..ea814ea5f700 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -451,7 +451,7 @@ void intel_gt_flush_ggtt_writes(struct intel_gt *gt)
 
 		spin_lock_irqsave(&uncore->lock, flags);
 		intel_uncore_posting_read_fw(uncore,
-					     RING_HEAD(RENDER_RING_BASE));
+					     RING_TAIL(RENDER_RING_BASE));
 		spin_unlock_irqrestore(&uncore->lock, flags);
 	}
 }
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-11-15 19:46 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-09 19:21 [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush Vinay Belgaumkar
2023-11-09 19:21 ` Vinay Belgaumkar
2023-11-09 19:30 ` [Intel-gfx] " Ville Syrjälä
2023-11-09 20:01   ` Belgaumkar, Vinay
2023-11-09 20:35     ` Ville Syrjälä
2023-11-10  1:02       ` Belgaumkar, Vinay
2023-11-15 19:46         ` Sripada, Radhakrishna
2023-11-15 19:46           ` Sripada, Radhakrishna
2023-11-09 22:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-11-10  2:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-11-13 19:33   ` Belgaumkar, Vinay

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.