From: Christoph Hellwig <hch@infradead.org>
To: ed.tsai@mediatek.com
Cc: ming.lei@redhat.com, hch@lst.de, Jens Axboe <axboe@kernel.dk>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
wsd_upstream@mediatek.com, chun-hung.wu@mediatek.com,
casper.li@mediatek.com, will.shiu@mediatek.com,
light.hsieh@mediatek.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] block: limit the extract size to align queue limit
Date: Thu, 9 Nov 2023 22:36:47 -0800 [thread overview]
Message-ID: <ZU3Pf0o2RCZ+dGNa@infradead.org> (raw)
In-Reply-To: <20231110051950.21972-1-ed.tsai@mediatek.com>
On Fri, Nov 10, 2023 at 01:19:49PM +0800, ed.tsai@mediatek.com wrote:
> + if (bdev && blk_queue_pci_p2pdma(bdev->bd_disk->queue))
> extraction_flags |= ITER_ALLOW_P2PDMA;
As pointed out in reply to Ming, you really need to first figure out
if we can assume we have a valid bdev or not, and if not pass all the
relevant information separately.
> + if (bdev && bio_op(bio) != REQ_OP_ZONE_APPEND) {
> + unsigned int max = queue_max_bytes(bdev_get_queue(bdev));
The higher level code must not look at queue_max_bytes, that is only
used for splitting and might not even be initialized.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: ed.tsai@mediatek.com
Cc: ming.lei@redhat.com, hch@lst.de, Jens Axboe <axboe@kernel.dk>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
wsd_upstream@mediatek.com, chun-hung.wu@mediatek.com,
casper.li@mediatek.com, will.shiu@mediatek.com,
light.hsieh@mediatek.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] block: limit the extract size to align queue limit
Date: Thu, 9 Nov 2023 22:36:47 -0800 [thread overview]
Message-ID: <ZU3Pf0o2RCZ+dGNa@infradead.org> (raw)
In-Reply-To: <20231110051950.21972-1-ed.tsai@mediatek.com>
On Fri, Nov 10, 2023 at 01:19:49PM +0800, ed.tsai@mediatek.com wrote:
> + if (bdev && blk_queue_pci_p2pdma(bdev->bd_disk->queue))
> extraction_flags |= ITER_ALLOW_P2PDMA;
As pointed out in reply to Ming, you really need to first figure out
if we can assume we have a valid bdev or not, and if not pass all the
relevant information separately.
> + if (bdev && bio_op(bio) != REQ_OP_ZONE_APPEND) {
> + unsigned int max = queue_max_bytes(bdev_get_queue(bdev));
The higher level code must not look at queue_max_bytes, that is only
used for splitting and might not even be initialized.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-10 6:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 5:19 [PATCH v2] block: limit the extract size to align queue limit ed.tsai
2023-11-10 5:19 ` ed.tsai
2023-11-10 6:36 ` Christoph Hellwig [this message]
2023-11-10 6:36 ` Christoph Hellwig
2023-11-10 10:59 ` kernel test robot
2023-11-10 10:59 ` kernel test robot
2023-11-10 16:03 ` Ming Lei
2023-11-10 16:03 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU3Pf0o2RCZ+dGNa@infradead.org \
--to=hch@infradead.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=axboe@kernel.dk \
--cc=casper.li@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=hch@lst.de \
--cc=light.hsieh@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming.lei@redhat.com \
--cc=will.shiu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.