From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Yuran Pereira <yuran.pereira@hotmail.com>,
linux-crypto@vger.kernel.org, davem@davemloft.net,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 0/7] crypto: Proper Initialization of `struct skcipher_walk` in x86 Glue Files
Date: Thu, 2 Nov 2023 12:30:44 +0800 [thread overview]
Message-ID: <ZUMl9BJcEXta1Spg@gondor.apana.org.au> (raw)
In-Reply-To: <20231102042043.GD1498@sol.localdomain>
On Wed, Nov 01, 2023 at 09:20:43PM -0700, Eric Biggers wrote:
>
> Updating all callers of skcipher_walk_virt() seems like the wrong approach.
> Shouldn't skcipher_walk_virt() be fixed to initialize the flags to 0 instead?
The bits of the flags that are used are initialised in skcipher_walk_next.
> Also, does this fix affect any behavior, or is it just to fix a KMSAN warning?
> It needs to be fixed either way, but it's helpful to understand the effect of
> the fix so that people can decide whether it needs to be backported or not.
Does this actually trigger a KMSAN warning? If so I'd like to see
it. If it's just a static analyser then I'm not applying this.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: x86@kernel.org, dave.hansen@linux.intel.com,
linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
linux-crypto@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
Yuran Pereira <yuran.pereira@hotmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
davem@davemloft.net
Subject: Re: [PATCH 0/7] crypto: Proper Initialization of `struct skcipher_walk` in x86 Glue Files
Date: Thu, 2 Nov 2023 12:30:44 +0800 [thread overview]
Message-ID: <ZUMl9BJcEXta1Spg@gondor.apana.org.au> (raw)
In-Reply-To: <20231102042043.GD1498@sol.localdomain>
On Wed, Nov 01, 2023 at 09:20:43PM -0700, Eric Biggers wrote:
>
> Updating all callers of skcipher_walk_virt() seems like the wrong approach.
> Shouldn't skcipher_walk_virt() be fixed to initialize the flags to 0 instead?
The bits of the flags that are used are initialised in skcipher_walk_next.
> Also, does this fix affect any behavior, or is it just to fix a KMSAN warning?
> It needs to be fixed either way, but it's helpful to understand the effect of
> the fix so that people can decide whether it needs to be backported or not.
Does this actually trigger a KMSAN warning? If so I'd like to see
it. If it's just a static analyser then I'm not applying this.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2023-11-02 4:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 4:04 [PATCH 0/7] crypto: Proper Initialization of `struct skcipher_walk` in x86 Glue Files Yuran Pereira
2023-11-02 4:04 ` Yuran Pereira
2023-11-02 4:09 ` [PATCH 1/7] crypto: Fixes uninitialized skcipher_walk use in sm4_aesni_avx_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
[not found] ` <20231102040931.1556061-1-yuran.pereira@hotmail.com>
2023-11-02 4:09 ` [PATCH 2/7] crypto: Fixes uninitialized skcipher_walk use in des3_ede_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
2023-11-02 4:09 ` [PATCH 3/7] crypto: Fixes uninitialized skcipher_walk use in chacha_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
2023-11-02 4:09 ` [PATCH 4/7] crypto: Fixes uninitialized skcipher_walk use in aesni-intel_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
2023-11-02 4:09 ` [PATCH 5/7] crypto: Fixes uninitialized skcipher_walk use in aria_aesni_avx2_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
2023-11-02 4:09 ` [PATCH 6/7] crypto: Fixes uninitialized skcipher_walk use in aria_aesni_avx_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
2023-11-02 4:09 ` [PATCH 7/7] crypto: Fixes uninitialized skcipher_walk use in aria_gfni_avx512_glue Yuran Pereira
2023-11-02 4:09 ` Yuran Pereira
2023-11-02 4:20 ` [PATCH 0/7] crypto: Proper Initialization of `struct skcipher_walk` in x86 Glue Files Eric Biggers
2023-11-02 4:20 ` Eric Biggers
2023-11-02 4:30 ` Herbert Xu [this message]
2023-11-02 4:30 ` Herbert Xu
2023-11-02 4:57 ` Yuran Pereira
2023-11-02 4:57 ` Yuran Pereira
2023-11-02 5:00 ` Herbert Xu
2023-11-02 5:00 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUMl9BJcEXta1Spg@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yuran.pereira@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.