From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Justin Stitt <justinstitt@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Shay Agroskin" <shayagr@amazon.com>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
"David Arinzon" <darinzon@amazon.com>,
"Noam Dagan" <ndagan@amazon.com>,
"Saeed Bishara" <saeedb@amazon.com>,
"Rasesh Mody" <rmody@marvell.com>,
"Sudarsana Kalluru" <skalluru@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
"Dimitris Michailidis" <dmichail@fungible.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Louis Peens" <louis.peens@corigine.com>,
"Shannon Nelson" <shannon.nelson@amd.com>,
"Brett Creeley" <brett.creeley@amd.com>,
drivers@pensando.io, "K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Dexuan Cui" <decui@microsoft.com>,
"Ronak Doshi" <doshir@vmware.com>,
"VMware PV-Drivers Reviewers" <pv-drivers@vmware.com>,
"Andy Whitcroft" <apw@canonical.com>,
"Joe Perches" <joe@perches.com>,
"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Wei Fang" <wei.fang@nxp.com>,
"Shenwei Wang" <shenwei.wang@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Lars Povlsen" <lars.povlsen@microchip.com>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
"Daniel Machon" <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com,
"Jiawen Wu" <jiawenwu@trustnetic.com>,
"Mengyuan Lou" <mengyuanlou@net-swift.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Kees Cook" <keescook@chromium.org>,
intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com,
linux-hyperv@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/3] ethtool: Implement ethtool_puts()
Date: Thu, 2 Nov 2023 19:22:06 +0000 [thread overview]
Message-ID: <ZUP23ic6adijQ8U9@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231102-ethtool_puts_impl-v4-1-14e1e9278496@google.com>
On Thu, Nov 02, 2023 at 06:55:42PM +0000, Justin Stitt wrote:
> +/**
> + * ethtool_puts - Write string to ethtool string data
> + * @data: Pointer to a pointer to the start of string to update
> + * @str: String to write
> + *
> + * Write string to *data. Update *data to point at start of
> + * next string.
A minor nit...
Sorry to jump in a bit late in this, but... concerning the use of "puts"
the userspace stdio version adds a trailing newline. Thus, to avoid any
confusion, I think the kerneldoc for this should explicitly state that
this does not add a newline.
* Write string to *data without a trailing newline. Update *data to
* point at the start of the next string.
This shouldn't be an issue, but it makes the behaviour of it plainly
obvious to the reader.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Justin Stitt <justinstitt@google.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
linux-hyperv@vger.kernel.org,
"Brett Creeley" <brett.creeley@amd.com>,
"Ronak Doshi" <doshir@vmware.com>,
"VMware PV-Drivers Reviewers" <pv-drivers@vmware.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexei Starovoitov" <ast@kernel.org>,
linux-kernel@vger.kernel.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Mengyuan Lou" <mengyuanlou@net-swift.com>,
netdev@vger.kernel.org, "Arthur Kiyanovski" <akiyano@amazon.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Louis Peens" <louis.peens@corigine.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Noam Dagan" <ndagan@amazon.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Shenwei Wang" <shenwei.wang@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Shay Agroskin" <shayagr@amazon.com>,
"Daniel Machon" <daniel.machon@microchip.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Joe Perches" <joe@perches.com>,
"Jiawen Wu" <jiawenwu@trustnetic.com>,
"Wei Fang" <wei.fang@nxp.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Andy Whitcroft" <apw@canonical.com>,
drivers@pensando.io, intel-wired-lan@lists.osuosl.org,
"Lars Povlsen" <lars.povlsen@microchip.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
"Salil Mehta" <salil.mehta@huawei.com>,
GR-Linux-NIC-Dev@marvell.com, "DENG Qingfang" <dqfext@gmail.com>,
"Kees Cook" <keescook@chromium.org>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Rasesh Mody" <rmody@marvell.com>,
"David Arinzon" <darinzon@amazon.com>,
oss-drivers@corigine.com,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
"Saeed Bishara" <saeedb@amazon.com>,
linux-mediatek@lists.infradead.org, bpf@vger.kernel.org,
"Dimitris Michailidis" <dmichail@fungible.com>,
"Sudarsana Kalluru" <skalluru@marvell.com>,
UNGLinuxDriver@microchip.com,
"Shannon Nelson" <shannon.nelson@amd.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/3] ethtool: Implement ethtool_puts()
Date: Thu, 2 Nov 2023 19:22:06 +0000 [thread overview]
Message-ID: <ZUP23ic6adijQ8U9@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231102-ethtool_puts_impl-v4-1-14e1e9278496@google.com>
On Thu, Nov 02, 2023 at 06:55:42PM +0000, Justin Stitt wrote:
> +/**
> + * ethtool_puts - Write string to ethtool string data
> + * @data: Pointer to a pointer to the start of string to update
> + * @str: String to write
> + *
> + * Write string to *data. Update *data to point at start of
> + * next string.
A minor nit...
Sorry to jump in a bit late in this, but... concerning the use of "puts"
the userspace stdio version adds a trailing newline. Thus, to avoid any
confusion, I think the kerneldoc for this should explicitly state that
this does not add a newline.
* Write string to *data without a trailing newline. Update *data to
* point at the start of the next string.
This shouldn't be an issue, but it makes the behaviour of it plainly
obvious to the reader.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-11-02 19:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 18:55 [PATCH net-next v4 0/3] ethtool: Add ethtool_puts() Justin Stitt
2023-11-02 18:55 ` [Intel-wired-lan] " Justin Stitt
2023-11-02 18:55 ` [PATCH net-next v4 1/3] ethtool: Implement ethtool_puts() Justin Stitt
2023-11-02 18:55 ` [Intel-wired-lan] " Justin Stitt
2023-11-02 19:22 ` Russell King (Oracle) [this message]
2023-11-02 19:22 ` Russell King (Oracle)
2023-11-02 18:55 ` [PATCH net-next v4 2/3] checkpatch: add ethtool_sprintf rules Justin Stitt
2023-11-02 18:55 ` [Intel-wired-lan] " Justin Stitt
2023-11-02 18:55 ` [PATCH net-next v4 3/3] net: Convert some ethtool_sprintf() to ethtool_puts() Justin Stitt
2023-11-02 18:55 ` [Intel-wired-lan] " Justin Stitt
2023-11-02 19:15 ` Kiyanovski, Arthur
2023-11-02 19:15 ` [Intel-wired-lan] " Kiyanovski, Arthur
2023-11-02 19:55 ` Andrew Lunn
2023-11-02 19:55 ` [Intel-wired-lan] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUP23ic6adijQ8U9@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=Landen.Chao@mediatek.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=akiyano@amazon.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anthony.l.nguyen@intel.com \
--cc=apw@canonical.com \
--cc=arinc.unal@arinc9.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brett.creeley@amd.com \
--cc=daniel.machon@microchip.com \
--cc=daniel@iogearbox.net \
--cc=daniel@makrotopia.org \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dmichail@fungible.com \
--cc=doshir@vmware.com \
--cc=dqfext@gmail.com \
--cc=drivers@pensando.io \
--cc=dwaipayanray1@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=hauke@hauke-m.de \
--cc=hawk@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=joe@perches.com \
--cc=john.fastabend@gmail.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.peens@corigine.com \
--cc=lukas.bulwahn@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mengyuanlou@net-swift.com \
--cc=nathan@kernel.org \
--cc=ndagan@amazon.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=rmody@marvell.com \
--cc=saeedb@amazon.com \
--cc=salil.mehta@huawei.com \
--cc=sean.wang@mediatek.com \
--cc=shannon.nelson@amd.com \
--cc=shayagr@amazon.com \
--cc=shenwei.wang@nxp.com \
--cc=skalluru@marvell.com \
--cc=wei.fang@nxp.com \
--cc=wei.liu@kernel.org \
--cc=xiaoning.wang@nxp.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.