Re: [PATCH nft 2/2] json: drop handling missing json() hook for "struct expr_ops"

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Nov 02, 2023 at 05:17:56PM +0100, Thomas Haller wrote:
> On Thu, 2023-11-02 at 16:54 +0100, Pablo Neira Ayuso wrote:
> > What example would be triggering bug?
> 
> when you apply above patchset (and revert patch 2/7), and:
> 
>     $ make
>     $ ./tests/shell/run-tests.sh
>     ...
>     $ grep '^[^ ]*W[^ ]*:' /tmp/nft-test.latest.*/test.log
>     W: [CHK DUMP]     8/381 tests/shell/testcases/chains/0041chain_binding_0  
>     W: [CHK DUMP]    66/381 tests/shell/testcases/cache/0010_implicit_chain_0
>     W: [CHK DUMP]   226/381 tests/shell/testcases/nft-f/sample-ruleset
>     $ grep -R 'Command `./tests/shell/../../src/nft -j list ruleset""` failed' /tmp/nft-test.latest.*/
>     ...
> 
> Gives:
> 
> tests/shell/testcases/nft-f/sample-ruleset
> tests/shell/testcases/cache/0010_implicit_chain_0
> tests/shell/testcases/chains/0041chain_binding_0
> 
> For example:
> 
> /tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:Command `./tests/shell/../../src/nft -j list ruleset""` failed
> /tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:>>>>
> /tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:warning: stmt ops chain have no json callback
> /tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:warning: stmt ops chain have no json callback

Yes, chain statement is lacking a json output, that is correct, that
needs to be done.

But, as for variable and symbol expressions, I do not see how those
can be found in the 'list ruleset' path. Note that symbol expressions
represent a preliminary state of the expression, these type of
expressions go away after evaluation. Same thing applies to variable
expression. They have no use for listing path.

Do you have tests that explicitly refer to the lack of json callback
for variable and symbol expressions just like in the warning above?

> /tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:<<<<
> 
> There are also other failures. e.g.
> tests/shell/testcases/parsing/large_rule_pipe does not give stable
> output. I need to drop that .json-nft file in v2.

What does 'unstable' mean in this case?