Re: [PATCH nft 2/2] json: drop handling missing json() hook for "struct expr_ops"

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Nov 03, 2023 at 01:19:33PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > > Do you have tests that explicitly refer to the lack of json callback
> > > > for variable and symbol expressions just like in the warning above?
> > > > 
> > > > > /tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-
> > > > > 0041chain_binding_0.4/rc-failed-chkdump:<<<<
> > > > > 
> > > > > There are also other failures. e.g.
> > > > > tests/shell/testcases/parsing/large_rule_pipe does not give stable
> > > > > output. I need to drop that .json-nft file in v2.
> > > > 
> > > > What does 'unstable' mean in this case?
> > > 
> > > It seems, that the order of the elements of the list is unstable.
> > 
> > Ah, I see, so it is not easy to compare. Thanks for explaining.
> 
> If its really just that the element ordering is random, then I think
> we should change libnftables to sort before printing, it should not
> be too much work/code.

There is a sort function that is already used when listing elements IIRC.

Maybe this is missing the json codepath?