From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Thomas Haller <thaller@redhat.com>,
NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 0/6] add infrastructure for unit tests
Date: Fri, 3 Nov 2023 16:33:44 +0100 [thread overview]
Message-ID: <ZUUS2CuHJAVxc7Ih@calendula> (raw)
In-Reply-To: <20231103122641.GC8035@breakpoint.cc>
On Fri, Nov 03, 2023 at 01:26:41PM +0100, Florian Westphal wrote:
> Thomas Haller <thaller@redhat.com> wrote:
>
> Thanks for sending an initial empty skeleton.
>
> > There are new new make targets:
> >
> > - "build-all"
> > - "check" (runs "normal" tests, like unit tests and "tools/check-tree.sh").
> > - "check-more" (runs extra tests, like "tests/build")
> > - "check-all" (runs "check" + "check-more")
> > - "check-local" (a subset of "check")
> > - "check-TESTS" (the unit tests)
>
> "check-unit" perhaps? TESTS isn't very descriptive. Also,
> why CAPS? If this is some pre-established standard, then maybe just
> document that in the commit changelog.
>
> Please don't do anything yet and wait for more comments, but
> I would prefer 'make check' to run all tests that we have.
We had a few tests that have been shown to be unstable.
I just would like that I don't hit this when making the release and
hold back a release because a test fails occasionally.
If we go for `make check' then all test runs must be reliable.
next prev parent reply other threads:[~2023-11-03 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 11:05 [PATCH nft 0/6] add infrastructure for unit tests Thomas Haller
2023-11-03 11:05 ` [PATCH nft 1/6] gitignore: ignore build artifacts from top level file Thomas Haller
2023-11-03 11:30 ` Pablo Neira Ayuso
2023-11-03 12:57 ` Thomas Haller
2023-11-03 11:05 ` [PATCH nft 2/6] build: add basic "check-{local,more,all}" and "build-all" make targets Thomas Haller
2023-11-03 11:05 ` [PATCH nft 3/6] build: add `make check-tests-build` to add build test Thomas Haller
2023-11-03 11:05 ` [PATCH nft 4/6] build: add check for consistency of source tree Thomas Haller
2023-11-03 11:05 ` [PATCH nft 5/6] build: cleanup if blocks for conditional compilation Thomas Haller
2023-11-03 11:05 ` [PATCH nft 6/6] tests/unit: add unit tests for libnftables Thomas Haller
2023-11-03 11:43 ` [PATCH nft 0/6] add infrastructure for unit tests Pablo Neira Ayuso
2023-11-03 12:26 ` Florian Westphal
2023-11-03 13:08 ` Thomas Haller
2023-11-03 15:33 ` Pablo Neira Ayuso [this message]
2023-11-03 15:57 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUUS2CuHJAVxc7Ih@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.