From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/6] gitignore: ignore build artifacts from top level file
Date: Fri, 3 Nov 2023 12:30:19 +0100 [thread overview]
Message-ID: <ZUTZy09Y+FyQjA6e@calendula> (raw)
In-Reply-To: <20231103111102.2801624-2-thaller@redhat.com>
On Fri, Nov 03, 2023 at 12:05:43PM +0100, Thomas Haller wrote:
> I don't think that having multiple .gitignore files for a small project
> like nftables is best. Anyway. The build artifacts like "*.o" will not
> only be found under "src/". Move those patterns.
>
> Signed-off-by: Thomas Haller <thaller@redhat.com>
> ---
> .gitignore | 7 ++++++-
> src/.gitignore | 5 -----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index a62e31f31c6b..51429020ceb6 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,6 +1,11 @@
> -# Generated by autoconf/configure/automake
> +# Generated by autoconf/configure/automake/make
> *.m4
> +*.la
> +*.lo
> +*.o
> +.deps/
> .dirstamp
> +.libs/
> Makefile
> Makefile.in
> stamp-h1
> diff --git a/src/.gitignore b/src/.gitignore
> index 2d907425cbb0..f34105c6cda4 100644
> --- a/src/.gitignore
> +++ b/src/.gitignore
> @@ -1,8 +1,3 @@
> -*.la
> -*.lo
> -*.o
> -.deps/
> -.libs/
Please, move things where they used to be.
> nft
> parser_bison.c
> parser_bison.h
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-11-03 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 11:05 [PATCH nft 0/6] add infrastructure for unit tests Thomas Haller
2023-11-03 11:05 ` [PATCH nft 1/6] gitignore: ignore build artifacts from top level file Thomas Haller
2023-11-03 11:30 ` Pablo Neira Ayuso [this message]
2023-11-03 12:57 ` Thomas Haller
2023-11-03 11:05 ` [PATCH nft 2/6] build: add basic "check-{local,more,all}" and "build-all" make targets Thomas Haller
2023-11-03 11:05 ` [PATCH nft 3/6] build: add `make check-tests-build` to add build test Thomas Haller
2023-11-03 11:05 ` [PATCH nft 4/6] build: add check for consistency of source tree Thomas Haller
2023-11-03 11:05 ` [PATCH nft 5/6] build: cleanup if blocks for conditional compilation Thomas Haller
2023-11-03 11:05 ` [PATCH nft 6/6] tests/unit: add unit tests for libnftables Thomas Haller
2023-11-03 11:43 ` [PATCH nft 0/6] add infrastructure for unit tests Pablo Neira Ayuso
2023-11-03 12:26 ` Florian Westphal
2023-11-03 13:08 ` Thomas Haller
2023-11-03 15:33 ` Pablo Neira Ayuso
2023-11-03 15:57 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUTZy09Y+FyQjA6e@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.