External display on the x13s?

External display on the x13s?

[Brian Masney]

I have Fedora 39 running on my x13s (with some minor tweaks to the grub
BLS boot entry) and it has working GPU, sound, battery status, etc. I
see the external display port in the DTS, however it's not working for
me. I have pd-mapper and qrtr installed. Does anyone have any
suggestions for enabling that? dmesg doesn't give any useful
information.

Brian

Re: External display on the x13s?

[Bryan O'Donoghue]

On 03/11/2023 17:17, Brian Masney wrote:
> I have Fedora 39 running on my x13s (with some minor tweaks to the grub
> BLS boot entry) and it has working GPU, sound, battery status, etc. I
> see the external display port in the DTS, however it's not working for
> me. I have pd-mapper and qrtr installed. Does anyone have any
> suggestions for enabling that? dmesg doesn't give any useful
> information.
> 
> Brian
> 

Run gnome and run the display @ < 2k

---
bod

Re: External display on the x13s?

[Bryan O'Donoghue]

On 03/11/2023 17:37, Bryan O'Donoghue wrote:
> On 03/11/2023 17:17, Brian Masney wrote:
>> I have Fedora 39 running on my x13s (with some minor tweaks to the grub
>> BLS boot entry) and it has working GPU, sound, battery status, etc. I
>> see the external display port in the DTS, however it's not working for
>> me. I have pd-mapper and qrtr installed. Does anyone have any
>> suggestions for enabling that? dmesg doesn't give any useful
>> information.
>>
>> Brian
>>
> 
> Run gnome and run the display @ < 2k
> 
> ---
> bod

<= 2k

Re: External display on the x13s?

[Bjorn Andersson]

On Fri, Nov 03, 2023 at 05:37:36PM +0000, Bryan O'Donoghue wrote:
> On 03/11/2023 17:17, Brian Masney wrote:
> > I have Fedora 39 running on my x13s (with some minor tweaks to the grub
> > BLS boot entry) and it has working GPU, sound, battery status, etc. I
> > see the external display port in the DTS, however it's not working for
> > me. I have pd-mapper and qrtr installed. Does anyone have any
> > suggestions for enabling that? dmesg doesn't give any useful
> > information.
> > 
> > Brian
> > 
> 
> Run gnome and run the display @ < 2k
> 

Brian's question makes it seem like he doesn't have any display, your
<=2k only relates to the display artifacts that you have, right?

Regards,
Bjorn

Re: External display on the x13s?

[Bjorn Andersson]

On Fri, Nov 03, 2023 at 01:17:38PM -0400, Brian Masney wrote:
> I have Fedora 39 running on my x13s (with some minor tweaks to the grub
> BLS boot entry) and it has working GPU, sound, battery status, etc. I
> see the external display port in the DTS, however it's not working for
> me. I have pd-mapper and qrtr installed. Does anyone have any
> suggestions for enabling that? dmesg doesn't give any useful
> information.
> 

With the ADSP remoteproc and pd-mapper running, and pd-mapper being able
to pick up the json files you should get your power-supply, and you
should get your USB Type-C events.

Unless I'm mistaken, there's still some issue with Gnome, but you should
be able to validate if the display is detected using "modetest -c". It
should present you with a eDP-1, USB-1 and USB-2 (or eDP-1, DP-1, DP-2
now in the future).


For reference, I'm running v6.6 with no modifications and built straight
from the upstream defconfig. I just confirmed that I can drive my 4k TV
(at 30Hz...) over HDMI with that.

Regards,
Bjorn

Re: External display on the x13s?

[Brian Masney]

On Fri, Nov 3, 2023 at 3:04 PM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
> With the ADSP remoteproc and pd-mapper running, and pd-mapper being able
> to pick up the json files you should get your power-supply, and you
> should get your USB Type-C events.
>
> Unless I'm mistaken, there's still some issue with Gnome, but you should
> be able to validate if the display is detected using "modetest -c". It
> should present you with a eDP-1, USB-1 and USB-2 (or eDP-1, DP-1, DP-2
> now in the future).
>
>
> For reference, I'm running v6.6 with no modifications and built straight
> from the upstream defconfig. I just confirmed that I can drive my 4k TV
> (at 30Hz...) over HDMI with that.

The issue ended up being my HDMI adapter since it looks like it's
thunderbolt. I found a different USB-C to HDMI adapter in my box of
cables and it's now detected on the x13s. However, mutter crashes and
I believe it's this issue:
https://gitlab.gnome.org/GNOME/mutter/-/issues/2398

To get Fedora 39 on the x13s, I had to take the nvme drive out, put it
in a USB caddy, dd the image to the drive using another computer, and
modify the grub config. It looks like Fedora's initramfs is missing
one or more modules that's needed so that the USB storage is detected.
I'm going to look into that as I have free time. I heard from Andrew
that there is (or was) an issue on boot up where the USB voltage
drops. Is that still an issue?

For the search engines: To get Fedora 39 booting on the x13s

directly dd the image using a different computer as I describe above

Mount the second partition and edit the loader/entries/xxx.conf file
on that partition:

Under options, remove 'quiet' and add 'arm64.nopauth clk_ignore_unused
pd_ignore_unused'
Add a new line:

    devicetree /dtb-6.5.6-300.fc39.aarch64/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

Put the drive back in the system.

To persist the kernel options once you boot the system, edit
/etc/default/grub. Change this line to:

GRUB_CMDLINE_LINUX="arm64.nopauth clk_ignore_unused pd_ignore_unused"

Add a new line GRUB_DEFAULT_DTB=/dtb/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

Fedora 39 currently has the 6.5.6 kernel and you can upgrade to a 6.6
kernel with:

sudo dnf copr enable @kernel-vanilla/mainline-wo-mergew
sudo dnf upgrade 'kernel*'

Brian

Re: External display on the x13s?

[Bryan O'Donoghue]

On 03/11/2023 18:53, Bjorn Andersson wrote:
> On Fri, Nov 03, 2023 at 05:37:36PM +0000, Bryan O'Donoghue wrote:
>> On 03/11/2023 17:17, Brian Masney wrote:
>>> I have Fedora 39 running on my x13s (with some minor tweaks to the grub
>>> BLS boot entry) and it has working GPU, sound, battery status, etc. I
>>> see the external display port in the DTS, however it's not working for
>>> me. I have pd-mapper and qrtr installed. Does anyone have any
>>> suggestions for enabling that? dmesg doesn't give any useful
>>> information.
>>>
>>> Brian
>>>
>>
>> Run gnome and run the display @ < 2k
>>
> 
> Brian's question makes it seem like he doesn't have any display, your
> <=2k only relates to the display artifacts that you have, right?
> 
> Regards,
> Bjorn
> 

Well its funny you asked.

I had an idea Gnome was working but lxqt was not, testing this a bit I 
get the second display up if the display port is connected to the port 
furthest away from the screen, not the port closest to the screen.

 > 2k artifacts persist but

- Gnome
- Gnome Classic
- KDE Plasma
- lxqt

Give me second screen up on Debian sid ~ reliably but only through the 
port furthest away from the ESC key.

Plugging the cable in and out at the gdm prompt seems to crash gdm.

The best result for me seems to be log in and then connect the cable 
furthest away from the screen.

I don't think the WM makes a real difference.

---
bod

Re: External display on the x13s?

[Johan Hovold]

On Sat, Nov 04, 2023 at 02:54:45PM +0000, Bryan O'Donoghue wrote:
> On 03/11/2023 18:53, Bjorn Andersson wrote:
> > On Fri, Nov 03, 2023 at 05:37:36PM +0000, Bryan O'Donoghue wrote:
> >> On 03/11/2023 17:17, Brian Masney wrote:
> >>> I have Fedora 39 running on my x13s (with some minor tweaks to the grub
> >>> BLS boot entry) and it has working GPU, sound, battery status, etc. I
> >>> see the external display port in the DTS, however it's not working for
> >>> me. I have pd-mapper and qrtr installed. Does anyone have any
> >>> suggestions for enabling that? dmesg doesn't give any useful
> >>> information.

> >> Run gnome and run the display @ < 2k

> > Brian's question makes it seem like he doesn't have any display, your
> > <=2k only relates to the display artifacts that you have, right?

> I had an idea Gnome was working but lxqt was not, testing this a bit I 
> get the second display up if the display port is connected to the port 
> furthest away from the screen, not the port closest to the screen.

Works fine on both ports here so that could also indicate a
(configuration) problem with your user space.

The port closes to the screen is the second port ("Unknown20-2", "USB-2"
or soon "DP-2"), which may or may not be relevant.

> Plugging the cable in and out at the gdm prompt seems to crash gdm.

I don't use Gnome, but that sounds like it could be related to the
mutter issue Brian mentioned. Have your verified that you have that fix?

Try booting to a VT console (stop whatever display server you are using)
and then plug in the USB connector in order to confirm that the issue is
in user space. You should see the console mirrored on your external
display.

Johan

Re: External display on the x13s?

[Bryan O'Donoghue]

On 06/11/2023 08:01, Johan Hovold wrote:
> On Sat, Nov 04, 2023 at 02:54:45PM +0000, Bryan O'Donoghue wrote:
>> On 03/11/2023 18:53, Bjorn Andersson wrote:
>>> On Fri, Nov 03, 2023 at 05:37:36PM +0000, Bryan O'Donoghue wrote:
>>>> On 03/11/2023 17:17, Brian Masney wrote:
>>>>> I have Fedora 39 running on my x13s (with some minor tweaks to the grub
>>>>> BLS boot entry) and it has working GPU, sound, battery status, etc. I
>>>>> see the external display port in the DTS, however it's not working for
>>>>> me. I have pd-mapper and qrtr installed. Does anyone have any
>>>>> suggestions for enabling that? dmesg doesn't give any useful
>>>>> information.
> 
>>>> Run gnome and run the display @ < 2k
> 
>>> Brian's question makes it seem like he doesn't have any display, your
>>> <=2k only relates to the display artifacts that you have, right?
> 
>> I had an idea Gnome was working but lxqt was not, testing this a bit I
>> get the second display up if the display port is connected to the port
>> furthest away from the screen, not the port closest to the screen.
> 
> Works fine on both ports here so that could also indicate a
> (configuration) problem with your user space.

Maybe. I've apt update/apt upgrade -y as at ~ 30 minutes ago and I see 
gnome-shell crashing with the second port -> nearest the screen.

Not the mutter related backtrace though.

kde plasma seems happy with both ports.
sway uses both ports.

Looks like something specific to gnome shell.

gdm doesn't show anything in journalctl but does appear to restart
sddm is fine but, then again displays only on the laptop screen.


> The port closes to the screen is the second port ("Unknown20-2", "USB-2"
> or soon "DP-2"), which may or may not be relevant.
> 
>> Plugging the cable in and out at the gdm prompt seems to crash gdm.
> 
> I don't use Gnome, but that sounds like it could be related to the
> mutter issue Brian mentioned. Have your verified that you have that fix?


> Try booting to a VT console (stop whatever display server you are using)
> and then plug in the USB connector in order to confirm that the issue is
> in user space. You should see the console mirrored on your external
> display.

Works.

Looks gnome shell specific to me.

Re: External display on the x13s?

[Brian Masney]

On Mon, Nov 06, 2023 at 11:27:55AM +0000, Bryan O'Donoghue wrote:
> On 06/11/2023 08:01, Johan Hovold wrote:
> > Try booting to a VT console (stop whatever display server you are using)
> > and then plug in the USB connector in order to confirm that the issue is
> > in user space. You should see the console mirrored on your external
> > display.
> 
> Works.
> 
> Looks gnome shell specific to me.

The VT consoles work for me and mirror the screen as expected.

I did some more digging and this appears to be GNOME shell related and
is likely different than the issue that I originally linked to [1].
When I run with GNOME under Wayland, I see this error come through from
the XWayland:

    Received an X Window System error.
    This probably reflects a bug in the program.
    The error was 'BadValue (integer parameter out of range for
        operation)'.
    (Details: serial 315 error_code 2 request_code 140 (RANDR)
        minor_code 7)

I have MUTTER_SYNC=1 set in my environment variables, and gdb shows that
gnome-shell crashes at [2] since plane_assignment is NULL. I don't have
anymore time to dig deeper into this today unfortunately.

[1] https://gitlab.gnome.org/GNOME/mutter/-/issues/2398
[2] https://github.com/GNOME/mutter/blob/main/src/backends/native/meta-kms-crtc.c#L365

Brian

Re: External display on the x13s?

[Brian Masney]

On Mon, Nov 06, 2023 at 11:13:56AM -0500, Brian Masney wrote:
> On Mon, Nov 06, 2023 at 11:27:55AM +0000, Bryan O'Donoghue wrote:
> The VT consoles work for me and mirror the screen as expected.
> 
> I did some more digging and this appears to be GNOME shell related and
> is likely different than the issue that I originally linked to [1].
> When I run with GNOME under Wayland, I see this error come through from
> the XWayland:
> 
>     Received an X Window System error.
>     This probably reflects a bug in the program.
>     The error was 'BadValue (integer parameter out of range for
>         operation)'.
>     (Details: serial 315 error_code 2 request_code 140 (RANDR)
>         minor_code 7)
> 
> I have MUTTER_SYNC=1 set in my environment variables, and gdb shows that
> gnome-shell crashes at [2] since plane_assignment is NULL. I don't have
> anymore time to dig deeper into this today unfortunately.
> 
> [1] https://gitlab.gnome.org/GNOME/mutter/-/issues/2398
> [2] https://github.com/GNOME/mutter/blob/main/src/backends/native/meta-kms-crtc.c#L365

After digging more through the coredump, it is the same issue mentioned
above [1] with mutter. I'm just seeing it happen somewhere else.

Brian

Re: External display on the x13s?

[Bjorn Andersson]

On Sat, Nov 04, 2023 at 07:35:07AM -0400, Brian Masney wrote:
> On Fri, Nov 3, 2023 at 3:04 PM Bjorn Andersson
> <quic_bjorande@quicinc.com> wrote:
> > With the ADSP remoteproc and pd-mapper running, and pd-mapper being able
> > to pick up the json files you should get your power-supply, and you
> > should get your USB Type-C events.
> >
> > Unless I'm mistaken, there's still some issue with Gnome, but you should
> > be able to validate if the display is detected using "modetest -c". It
> > should present you with a eDP-1, USB-1 and USB-2 (or eDP-1, DP-1, DP-2
> > now in the future).
> >
> >
> > For reference, I'm running v6.6 with no modifications and built straight
> > from the upstream defconfig. I just confirmed that I can drive my 4k TV
> > (at 30Hz...) over HDMI with that.
> 
> The issue ended up being my HDMI adapter since it looks like it's
> thunderbolt. I found a different USB-C to HDMI adapter in my box of
> cables and it's now detected on the x13s.

Woho!

> However, mutter crashes and
> I believe it's this issue:
> https://gitlab.gnome.org/GNOME/mutter/-/issues/2398
> 

:(

> To get Fedora 39 on the x13s, I had to take the nvme drive out, put it
> in a USB caddy, dd the image to the drive using another computer, and
> modify the grub config. It looks like Fedora's initramfs is missing
> one or more modules that's needed so that the USB storage is detected.
> I'm going to look into that as I have free time. I heard from Andrew
> that there is (or was) an issue on boot up where the USB voltage
> drops. Is that still an issue?
> 

I've not scoped the cable, or analysed the problem further, but the USB
bus is at least re-enumerated when the USB Type-C firmware is loaded by
remoteproc.

> For the search engines: To get Fedora 39 booting on the x13s
> 
> directly dd the image using a different computer as I describe above
> 
> Mount the second partition and edit the loader/entries/xxx.conf file
> on that partition:
> 
> Under options, remove 'quiet' and add 'arm64.nopauth clk_ignore_unused
> pd_ignore_unused'
> Add a new line:
> 
>     devicetree /dtb-6.5.6-300.fc39.aarch64/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
> 
> Put the drive back in the system.
> 
> To persist the kernel options once you boot the system, edit
> /etc/default/grub. Change this line to:
> 
> GRUB_CMDLINE_LINUX="arm64.nopauth clk_ignore_unused pd_ignore_unused"
> 
> Add a new line GRUB_DEFAULT_DTB=/dtb/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
> 
> Fedora 39 currently has the 6.5.6 kernel and you can upgrade to a 6.6
> kernel with:
> 
> sudo dnf copr enable @kernel-vanilla/mainline-wo-mergew
> sudo dnf upgrade 'kernel*'
> 

Thank you for sharing,
Bjorn