From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Cristian Marussi <cristian.marussi@arm.com>,
Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC v5 3/5] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support
Date: Mon, 6 Nov 2023 11:28:03 +0900 [thread overview]
Message-ID: <ZUhPMxpho1WR5b+8@octopus> (raw)
In-Reply-To: <ZUhOw0+HVcJYmvp6@octopus>
On Mon, Nov 06, 2023 at 11:26:11AM +0900, AKASHI Takahiro wrote:
> On Thu, Nov 02, 2023 at 08:06:41AM +0000, Cristian Marussi wrote:
> > On Fri, Oct 27, 2023 at 06:28:10AM +0000, Oleksii Moisieiev wrote:
> > > Add basic implementation of the SCMI v3.2 pincontrol protocol.
> > >
> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > ---
> >
> > Hi Oleksii,
> >
> > the new get/set v3.2 implementation seems finer to me at first sight.
> > I'll try to test this next days and give you more feedback.
>
> I don't think that this version addresses my comment yet:
>
> https://lkml.iu.edu//hypermail/linux/kernel/2308.2/07483.html
>
> I hope that it will be fixed in your *final* v5.
Oops, this comment should better go against patch#4/5.
> -Takahiro Akashi
>
> > Thanks,
> > Cristian
WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Cristian Marussi <cristian.marussi@arm.com>,
Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC v5 3/5] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support
Date: Mon, 6 Nov 2023 11:28:03 +0900 [thread overview]
Message-ID: <ZUhPMxpho1WR5b+8@octopus> (raw)
In-Reply-To: <ZUhOw0+HVcJYmvp6@octopus>
On Mon, Nov 06, 2023 at 11:26:11AM +0900, AKASHI Takahiro wrote:
> On Thu, Nov 02, 2023 at 08:06:41AM +0000, Cristian Marussi wrote:
> > On Fri, Oct 27, 2023 at 06:28:10AM +0000, Oleksii Moisieiev wrote:
> > > Add basic implementation of the SCMI v3.2 pincontrol protocol.
> > >
> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > ---
> >
> > Hi Oleksii,
> >
> > the new get/set v3.2 implementation seems finer to me at first sight.
> > I'll try to test this next days and give you more feedback.
>
> I don't think that this version addresses my comment yet:
>
> https://lkml.iu.edu//hypermail/linux/kernel/2308.2/07483.html
>
> I hope that it will be fixed in your *final* v5.
Oops, this comment should better go against patch#4/5.
> -Takahiro Akashi
>
> > Thanks,
> > Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-06 2:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 6:28 [RFC v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Oleksii Moisieiev
2023-10-27 6:28 ` Oleksii Moisieiev
2023-10-27 6:28 ` [RFC v5 1/5] firmware: arm_scmi: Add optional flags to extended names helper Oleksii Moisieiev
2023-10-27 6:28 ` Oleksii Moisieiev
2023-11-02 7:06 ` Cristian Marussi
2023-11-02 7:06 ` Cristian Marussi
2023-11-02 7:19 ` [PATCH] " Cristian Marussi
2023-11-14 16:18 ` Cristian Marussi
2023-10-27 6:28 ` [RFC v5 2/5] drivers: firmware: scmi: Introduce scmi_get_max_msg_size function Oleksii Moisieiev
2023-10-27 6:28 ` Oleksii Moisieiev
2023-11-02 7:29 ` Cristian Marussi
2023-11-02 7:29 ` Cristian Marussi
2023-11-02 13:57 ` Oleksii Moisieiev
2023-11-02 13:57 ` Oleksii Moisieiev
2023-11-02 15:04 ` Cristian Marussi
2023-11-02 15:04 ` Cristian Marussi
2023-10-27 6:28 ` [RFC v5 3/5] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Oleksii Moisieiev
2023-10-27 6:28 ` Oleksii Moisieiev
2023-11-02 8:06 ` Cristian Marussi
2023-11-02 8:06 ` Cristian Marussi
2023-11-06 2:26 ` AKASHI Takahiro
2023-11-06 2:26 ` AKASHI Takahiro
2023-11-06 2:28 ` AKASHI Takahiro [this message]
2023-11-06 2:28 ` AKASHI Takahiro
2023-10-27 6:28 ` [RFC v5 5/5] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol Oleksii Moisieiev
2023-10-27 6:28 ` Oleksii Moisieiev
2023-10-27 8:56 ` Krzysztof Kozlowski
2023-10-27 8:56 ` Krzysztof Kozlowski
2023-11-01 14:09 ` Oleksii Moisieiev
2023-11-01 14:09 ` Oleksii Moisieiev
2023-10-27 11:54 ` Rob Herring
2023-10-27 11:54 ` Rob Herring
2023-11-06 13:12 ` Linus Walleij
2023-11-06 13:12 ` Linus Walleij
2023-11-10 0:58 ` Takahiro Akashi
2023-11-10 0:58 ` Takahiro Akashi
2023-11-10 15:24 ` Cristian Marussi
2023-11-10 15:24 ` Cristian Marussi
2023-11-13 12:56 ` Souvik Chakravarty
2023-11-13 12:56 ` Souvik Chakravarty
2023-11-13 13:32 ` Linus Walleij
2023-11-13 13:32 ` Linus Walleij
2023-11-13 14:23 ` Souvik Chakravarty
2023-11-13 14:23 ` Souvik Chakravarty
2023-11-14 13:13 ` Linus Walleij
2023-11-14 13:13 ` Linus Walleij
2023-10-27 6:28 ` [RFC v5 4/5] pinctrl: Implementation of the generic scmi-pinctrl driver Oleksii Moisieiev
2023-11-05 21:50 ` [RFC v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Linus Walleij
2023-11-05 21:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUhPMxpho1WR5b+8@octopus \
--to=takahiro.akashi@linaro.org \
--cc=Oleksii_Moisieiev@epam.com \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.