[PATCH for-4.18 0/2] golang: Binding fixes

[PATCH for-4.18 0/2] golang: Binding fixes

[Jason Andryuk]

These two patches refresh the bindings which have gone a little stale.
I used two separate patches since the XSA-443 one may want backporting.

Jason Andryuk (2):
  golang: Fixup binding for Arm FF-A
  golang: Fix bindings after XSA-443

 tools/golang/xenlight/helpers.gen.go | 9 +++++++++
 tools/golang/xenlight/types.gen.go   | 3 +++
 2 files changed, 12 insertions(+)

-- 
2.41.0

[PATCH for-4.18 1/2] golang: Fixup binding for Arm FF-A

[Jason Andryuk]

The new FF-A TEE type changed the go bindings.  Update them.

Fixes: 8abdd8d52862 ("tools: add Arm FF-A mediator")
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
 tools/golang/xenlight/types.gen.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 4f40aac28c..6a9ebb3fec 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -488,6 +488,7 @@ type TeeType int
 const(
 TeeTypeNone TeeType = 0
 TeeTypeOptee TeeType = 1
+TeeTypeFfa TeeType = 2
 )
 
 type SveType int
-- 
2.41.0

Re: [PATCH for-4.18 1/2] golang: Fixup binding for Arm FF-A

[Henry Wang]

Hi Jason,

> On Nov 4, 2023, at 03:45, Jason Andryuk <jandryuk@gmail.com> wrote:
> 
> The new FF-A TEE type changed the go bindings.  Update them.
> 
> Fixes: 8abdd8d52862 ("tools: add Arm FF-A mediator")
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

> ---
> tools/golang/xenlight/types.gen.go | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 4f40aac28c..6a9ebb3fec 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -488,6 +488,7 @@ type TeeType int
> const(
> TeeTypeNone TeeType = 0
> TeeTypeOptee TeeType = 1
> +TeeTypeFfa TeeType = 2
> )
> 
> type SveType int
> -- 
> 2.41.0
> 

Re: [PATCH for-4.18 1/2] golang: Fixup binding for Arm FF-A

[George Dunlap]

On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>
> The new FF-A TEE type changed the go bindings.  Update them.
>
> Fixes: 8abdd8d52862 ("tools: add Arm FF-A mediator")
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Acked-by: George Dunlap <george.dunlap@cloud.com>

[PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

[Jason Andryuk]

The new bootloader_restrict and bootloader_user fields in the libxl idl
change the bindings.  Update them.

Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted mode")
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
 tools/golang/xenlight/helpers.gen.go | 9 +++++++++
 tools/golang/xenlight/types.gen.go   | 2 ++
 2 files changed, 11 insertions(+)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index 3ecffdf0ef..35e209ff1b 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1112,6 +1112,10 @@ x.Bootloader = C.GoString(xc.bootloader)
 if err := x.BootloaderArgs.fromC(&xc.bootloader_args);err != nil {
 return fmt.Errorf("converting field BootloaderArgs: %v", err)
 }
+if err := x.BootloaderRestrict.fromC(&xc.bootloader_restrict);err != nil {
+return fmt.Errorf("converting field BootloaderRestrict: %v", err)
+}
+x.BootloaderUser = C.GoString(xc.bootloader_user)
 x.TimerMode = TimerMode(xc.timer_mode)
 if err := x.NestedHvm.fromC(&xc.nested_hvm);err != nil {
 return fmt.Errorf("converting field NestedHvm: %v", err)
@@ -1465,6 +1469,11 @@ xc.bootloader = C.CString(x.Bootloader)}
 if err := x.BootloaderArgs.toC(&xc.bootloader_args); err != nil {
 return fmt.Errorf("converting field BootloaderArgs: %v", err)
 }
+if err := x.BootloaderRestrict.toC(&xc.bootloader_restrict); err != nil {
+return fmt.Errorf("converting field BootloaderRestrict: %v", err)
+}
+if x.BootloaderUser != "" {
+xc.bootloader_user = C.CString(x.BootloaderUser)}
 xc.timer_mode = C.libxl_timer_mode(x.TimerMode)
 if err := x.NestedHvm.toC(&xc.nested_hvm); err != nil {
 return fmt.Errorf("converting field NestedHvm: %v", err)
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 6a9ebb3fec..7907aa8999 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -577,6 +577,8 @@ DeviceTree string
 Acpi Defbool
 Bootloader string
 BootloaderArgs StringList
+BootloaderRestrict Defbool
+BootloaderUser string
 TimerMode TimerMode
 NestedHvm Defbool
 Apic Defbool
-- 
2.41.0

Re: [PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

[Henry Wang]

Hi Jason,

> On Nov 4, 2023, at 03:45, Jason Andryuk <jandryuk@gmail.com> wrote:
> 
> The new bootloader_restrict and bootloader_user fields in the libxl idl
> change the bindings.  Update them.
> 
> Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted mode")
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

> ---
> tools/golang/xenlight/helpers.gen.go | 9 +++++++++
> tools/golang/xenlight/types.gen.go   | 2 ++
> 2 files changed, 11 insertions(+)
> 
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index 3ecffdf0ef..35e209ff1b 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1112,6 +1112,10 @@ x.Bootloader = C.GoString(xc.bootloader)
> if err := x.BootloaderArgs.fromC(&xc.bootloader_args);err != nil {
> return fmt.Errorf("converting field BootloaderArgs: %v", err)
> }
> +if err := x.BootloaderRestrict.fromC(&xc.bootloader_restrict);err != nil {
> +return fmt.Errorf("converting field BootloaderRestrict: %v", err)
> +}
> +x.BootloaderUser = C.GoString(xc.bootloader_user)
> x.TimerMode = TimerMode(xc.timer_mode)
> if err := x.NestedHvm.fromC(&xc.nested_hvm);err != nil {
> return fmt.Errorf("converting field NestedHvm: %v", err)
> @@ -1465,6 +1469,11 @@ xc.bootloader = C.CString(x.Bootloader)}
> if err := x.BootloaderArgs.toC(&xc.bootloader_args); err != nil {
> return fmt.Errorf("converting field BootloaderArgs: %v", err)
> }
> +if err := x.BootloaderRestrict.toC(&xc.bootloader_restrict); err != nil {
> +return fmt.Errorf("converting field BootloaderRestrict: %v", err)
> +}
> +if x.BootloaderUser != "" {
> +xc.bootloader_user = C.CString(x.BootloaderUser)}
> xc.timer_mode = C.libxl_timer_mode(x.TimerMode)
> if err := x.NestedHvm.toC(&xc.nested_hvm); err != nil {
> return fmt.Errorf("converting field NestedHvm: %v", err)
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 6a9ebb3fec..7907aa8999 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -577,6 +577,8 @@ DeviceTree string
> Acpi Defbool
> Bootloader string
> BootloaderArgs StringList
> +BootloaderRestrict Defbool
> +BootloaderUser string
> TimerMode TimerMode
> NestedHvm Defbool
> Apic Defbool
> -- 
> 2.41.0
> 

Re: [PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

[George Dunlap]

On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>
> The new bootloader_restrict and bootloader_user fields in the libxl idl
> change the bindings.  Update them.
>
> Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted mode")
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Acked-by: George Dunlap <george.dunlap@cloud.com>

Re: [PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

[George Dunlap]

On Mon, Nov 6, 2023 at 11:41 AM George Dunlap <george.dunlap@cloud.com> wrote:
>
> On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@gmail.com> wrote:
> >
> > The new bootloader_restrict and bootloader_user fields in the libxl idl
> > change the bindings.  Update them.
> >
> > Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted mode")
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>
> Acked-by: George Dunlap <george.dunlap@cloud.com>

Also, as Jason pointed out in the cover letter, we probably want to
backport this patch; I'm not sure exactly who's in charge of that for
tools.

 -George

Re: [PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

[Jan Beulich]

On 06.11.2023 12:53, George Dunlap wrote:
> On Mon, Nov 6, 2023 at 11:41 AM George Dunlap <george.dunlap@cloud.com> wrote:
>>
>> On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>>>
>>> The new bootloader_restrict and bootloader_user fields in the libxl idl
>>> change the bindings.  Update them.
>>>
>>> Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted mode")
>>> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>>
>> Acked-by: George Dunlap <george.dunlap@cloud.com>
> 
> Also, as Jason pointed out in the cover letter, we probably want to
> backport this patch; I'm not sure exactly who's in charge of that for
> tools.

I'll try to remember to pick this up once it has been committed.

Jan

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Andrew Cooper]

On 03/11/2023 7:45 pm, Jason Andryuk wrote:
> These two patches refresh the bindings which have gone a little stale.
> I used two separate patches since the XSA-443 one may want backporting.
>
> Jason Andryuk (2):
>   golang: Fixup binding for Arm FF-A
>   golang: Fix bindings after XSA-443

Bah - the security team did mess up there.

Also, we very clearly need the Golang bindings to be a blocking build
test in GitlabCI to avoid repeats of this in the future.

I'm tempted to the Gitlab change ought to be for-4.18 too.  Henry, thoughts?

~Andrew

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Henry Wang]

Hi Andrew,

> On Nov 4, 2023, at 03:50, Andrew Cooper <andcooper@tibco.com> wrote:
> 
> [andcooper@tibco.com appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]

(+Your work email address since this reply somehow ended up with my filter,
I found this email a bit later, sorry for the late reply.)

> 
> On 03/11/2023 7:45 pm, Jason Andryuk wrote:
>> These two patches refresh the bindings which have gone a little stale.
>> I used two separate patches since the XSA-443 one may want backporting.
>> 
>> Jason Andryuk (2):
>>  golang: Fixup binding for Arm FF-A
>>  golang: Fix bindings after XSA-443
> 
> Bah - the security team did mess up there.
> 
> Also, we very clearly need the Golang bindings to be a blocking build
> test in GitlabCI to avoid repeats of this in the future.
> 
> I'm tempted to the Gitlab change ought to be for-4.18 too.  Henry, thoughts?

As long as the GitLab CI change can be submitted within the 4.18 release
timeline, I won’t object it. Thanks.

Kind regards,
Henry

> 
> ~Andrew

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Andrew Cooper]

On 06/11/2023 5:38 am, Henry Wang wrote:
> Hi Andrew,
>
>> On Nov 4, 2023, at 03:50, Andrew Cooper <andcooper@tibco.com> wrote:
>>
>> [andcooper@tibco.com appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]
> (+Your work email address since this reply somehow ended up with my filter,
> I found this email a bit later, sorry for the late reply.)

sigh.

It seems a Thunderbird update has clobbered my configuration, and for
reasons of the corporate merger, @tibco is still our probably accounts.

I'll see about fixing up.

~Andrew

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[George Dunlap]

On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>
> These two patches refresh the bindings which have gone a little stale.
> I used two separate patches since the XSA-443 one may want backporting.

Thanks for these.  Out of curiosity, do you use the golang bindings,
and if so, are you happy with how you're consuming them now?  We had
talked at some point about exposing the bindings somewhere on xenbits
(or maybe gitlab) such that people should simply add the path to their
golang projects and have it download & build like "normal".  Is that
something you'd find useful?

Peace,
 -George

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Jason Andryuk]

On Mon, Nov 6, 2023 at 6:52 AM George Dunlap <george.dunlap@cloud.com> wrote:
>
> On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@gmail.com> wrote:
> >
> > These two patches refresh the bindings which have gone a little stale.
> > I used two separate patches since the XSA-443 one may want backporting.
>
> Thanks for these.  Out of curiosity, do you use the golang bindings,
> and if so, are you happy with how you're consuming them now?  We had
> talked at some point about exposing the bindings somewhere on xenbits
> (or maybe gitlab) such that people should simply add the path to their
> golang projects and have it download & build like "normal".  Is that
> something you'd find useful?

Hi George,

No, I do not use the bindings, so I cannot answer your questions.  I
just noticed the bindings were stale when doing a rebase.

I think Andrew's idea to check these via gitlab is a good one.  They
seem to often be missed.  I only noticed because I had installed go,
and I only installed go to check binding generation for a previous
patch series.

Since the bindings are auto generated, do they really need to be
checked into the tree?  If gitlab checks their generation, then maybe
they don't need to be checked in?

Regards,
Jason

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Roger Pau Monné]

On Fri, Nov 03, 2023 at 03:45:49PM -0400, Jason Andryuk wrote:
> These two patches refresh the bindings which have gone a little stale.
> I used two separate patches since the XSA-443 one may want backporting.

The XSA-443 one is only relevant for unstable and 4.18.  Stable
branches at the time of the XSA didn't get those fields added as it
would break the API.

Regards, Roger.

Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Jason Andryuk]

On Mon, Nov 6, 2023 at 7:45 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
>
> On Fri, Nov 03, 2023 at 03:45:49PM -0400, Jason Andryuk wrote:
> > These two patches refresh the bindings which have gone a little stale.
> > I used two separate patches since the XSA-443 one may want backporting.
>
> The XSA-443 one is only relevant for unstable and 4.18.  Stable
> branches at the time of the XSA didn't get those fields added as it
> would break the API.

Oh, good.  Thanks for confirming, Roger.

Regards,
Jason