* [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized"
@ 2023-10-03 7:49 Colin Ian King
2023-10-04 1:07 ` Ian Rogers
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2023-10-03 7:49 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
linux-perf-users
Cc: kernel-janitors, linux-kernel
There are spelling mistakes in comments and a pr_debug message. Fix them.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
tools/perf/tests/parse-events.c | 4 ++--
tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index f78be21a5999..e52f45c7c3d1 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
if (strchr(ent->d_name, '.'))
continue;
- /* exclude parametrized ones (name contains '?') */
+ /* exclude parameterized ones (name contains '?') */
n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
if (n >= PATH_MAX) {
pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
@@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
fclose(file);
if (is_event_parameterized == 1) {
- pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
+ pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
continue;
}
diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
index c77955419173..d2a3506e0d19 100755
--- a/tools/perf/tests/shell/stat_all_pmu.sh
+++ b/tools/perf/tests/shell/stat_all_pmu.sh
@@ -4,7 +4,7 @@
set -e
-# Test all PMU events; however exclude parametrized ones (name contains '?')
+# Test all PMU events; however exclude parameterized ones (name contains '?')
for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
echo "Testing $p"
result=$(perf stat -e "$p" true 2>&1)
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized"
2023-10-03 7:49 [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized" Colin Ian King
@ 2023-10-04 1:07 ` Ian Rogers
2023-10-04 8:13 ` Athira Rajeev
0 siblings, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2023-10-04 1:07 UTC (permalink / raw)
To: Colin Ian King, Athira Rajeev
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, linux-perf-users,
kernel-janitors, linux-kernel
On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There are spelling mistakes in comments and a pr_debug message. Fix them.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
+ Athira Rajeev
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/tests/parse-events.c | 4 ++--
> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index f78be21a5999..e52f45c7c3d1 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
> if (strchr(ent->d_name, '.'))
> continue;
>
> - /* exclude parametrized ones (name contains '?') */
> + /* exclude parameterized ones (name contains '?') */
> n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
> if (n >= PATH_MAX) {
> pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
> fclose(file);
>
> if (is_event_parameterized == 1) {
> - pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
> + pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
> continue;
> }
>
> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
> index c77955419173..d2a3506e0d19 100755
> --- a/tools/perf/tests/shell/stat_all_pmu.sh
> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
> @@ -4,7 +4,7 @@
>
> set -e
>
> -# Test all PMU events; however exclude parametrized ones (name contains '?')
> +# Test all PMU events; however exclude parameterized ones (name contains '?')
> for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
> echo "Testing $p"
> result=$(perf stat -e "$p" true 2>&1)
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized"
2023-10-04 1:07 ` Ian Rogers
@ 2023-10-04 8:13 ` Athira Rajeev
2023-11-06 21:35 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Athira Rajeev @ 2023-10-04 8:13 UTC (permalink / raw)
To: Ian Rogers, colin.i.king
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, linux-perf-users,
kernel-janitors, LKML
> On 04-Oct-2023, at 6:37 AM, Ian Rogers <irogers@google.com> wrote:
>
> On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>>
>> There are spelling mistakes in comments and a pr_debug message. Fix them.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> + Athira Rajeev
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com <mailto:atrajeev@linux.vnet.ibm.com>>
Thanks
Athira
>
> Thanks,
> Ian
>
>> ---
>> tools/perf/tests/parse-events.c | 4 ++--
>> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
>> index f78be21a5999..e52f45c7c3d1 100644
>> --- a/tools/perf/tests/parse-events.c
>> +++ b/tools/perf/tests/parse-events.c
>> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>> if (strchr(ent->d_name, '.'))
>> continue;
>>
>> - /* exclude parametrized ones (name contains '?') */
>> + /* exclude parameterized ones (name contains '?') */
>> n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
>> if (n >= PATH_MAX) {
>> pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
>> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>> fclose(file);
>>
>> if (is_event_parameterized == 1) {
>> - pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
>> + pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
>> continue;
>> }
>>
>> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
>> index c77955419173..d2a3506e0d19 100755
>> --- a/tools/perf/tests/shell/stat_all_pmu.sh
>> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
>> @@ -4,7 +4,7 @@
>>
>> set -e
>>
>> -# Test all PMU events; however exclude parametrized ones (name contains '?')
>> +# Test all PMU events; however exclude parameterized ones (name contains '?')
>> for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
>> echo "Testing $p"
>> result=$(perf stat -e "$p" true 2>&1)
>> --
>> 2.39.2
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized"
2023-10-04 8:13 ` Athira Rajeev
@ 2023-11-06 21:35 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-11-06 21:35 UTC (permalink / raw)
To: Athira Rajeev
Cc: Ian Rogers, colin.i.king, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, linux-perf-users,
kernel-janitors, LKML
Em Wed, Oct 04, 2023 at 01:43:28PM +0530, Athira Rajeev escreveu:
> > On 04-Oct-2023, at 6:37 AM, Ian Rogers <irogers@google.com> wrote:
> > On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
> >> There are spelling mistakes in comments and a pr_debug message. Fix them.
> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > + Athira Rajeev
> > Reviewed-by: Ian Rogers <irogers@google.com>
> Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com <mailto:atrajeev@linux.vnet.ibm.com>>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-06 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-03 7:49 [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized" Colin Ian King
2023-10-04 1:07 ` Ian Rogers
2023-10-04 8:13 ` Athira Rajeev
2023-11-06 21:35 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.