* [PATCH] x86/vPIC: correct vcpi_domain()
@ 2023-11-23 10:20 Jan Beulich
2023-11-23 10:34 ` Andrew Cooper
2023-11-23 10:41 ` Roger Pau Monné
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2023-11-23 10:20 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
Make it use its parameter in both places.
Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/vpic.c
+++ b/xen/arch/x86/hvm/vpic.c
@@ -35,7 +35,7 @@
#include <asm/hvm/save.h>
#define vpic_domain(v) (container_of((v), struct domain, \
- arch.hvm.vpic[!vpic->is_master]))
+ arch.hvm.vpic[!(v)->is_master]))
#define __vpic_lock(v) &container_of((v), struct hvm_domain, \
vpic[!(v)->is_master])->irq_lock
#define vpic_lock(v) spin_lock(__vpic_lock(v))
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/vPIC: correct vcpi_domain()
2023-11-23 10:20 [PATCH] x86/vPIC: correct vcpi_domain() Jan Beulich
@ 2023-11-23 10:34 ` Andrew Cooper
2023-11-23 10:41 ` Roger Pau Monné
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2023-11-23 10:34 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Wei Liu, Roger Pau Monné
On 23/11/2023 10:20 am, Jan Beulich wrote:
> Make it use its parameter in both places.
>
> Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/vPIC: correct vcpi_domain()
2023-11-23 10:20 [PATCH] x86/vPIC: correct vcpi_domain() Jan Beulich
2023-11-23 10:34 ` Andrew Cooper
@ 2023-11-23 10:41 ` Roger Pau Monné
1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2023-11-23 10:41 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel@lists.xenproject.org, Andrew Cooper, Wei Liu
^ typo in the subject :).
On Thu, Nov 23, 2023 at 11:20:24AM +0100, Jan Beulich wrote:
> Make it use its parameter in both places.
>
> Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-23 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 10:20 [PATCH] x86/vPIC: correct vcpi_domain() Jan Beulich
2023-11-23 10:34 ` Andrew Cooper
2023-11-23 10:41 ` Roger Pau Monné
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.