From: Baoquan He <bhe@redhat.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
akpm@linux-foundation.org, ignat@cloudflare.com,
eric_devolder@yahoo.com
Subject: Re: [PATCH 2/3] drivers/base/cpu: crash data showing should depends on KEXEC_CORE
Date: Thu, 23 Nov 2023 22:27:13 +0800 [thread overview]
Message-ID: <ZV9hQfugDw2gDTRy@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZV9eCBm5uy7/VgOX@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
On 11/23/23 at 03:13pm, Alexander Gordeev wrote:
> On Thu, Nov 23, 2023 at 03:36:51PM +0800, Baoquan He wrote:
> > When below kernel config items are set, compiling error are triggered.
> >
> > CONFIG_CRASH_CORE=y
> > CONFIG_KEXEC_CORE=y
> > CONFIG_CRASH_DUMP=y
> > CONFIG_CRASH_HOTPLUG=y
> >
> > ------------------------------------------------------
> > drivers/base/cpu.c: In function ‘crash_hotplug_show’:
> > drivers/base/cpu.c:309:40: error: implicit declaration of function ‘crash_hotplug_cpu_support’; did you mean ‘crash_hotplug_show’? [-Werror=implicit-function-declaration]
> > 309 | return sysfs_emit(buf, "%d\n", crash_hotplug_cpu_support());
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > | crash_hotplug_show
> > cc1: some warnings being treated as errors
> > ------------------------------------------------------
> >
> > CONFIG_KEXEC is used to enable kexec_load interface, the
> > crash_notes/crash_notes_size/crash_hotplug showing depends on
> > CONFIG_KEXEC is incorrect. It should depend on KEXEC_CORE instead.
> >
> > Fix it now.
>
> If this error introduced with the prevous patch?
> If so, the patches need to be swapped I guess.
From the phenomenon, yes. In fact it's the patch 1 which exposes
the wrong ifdeffery. I can shift the order in v2. Thanks.
>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
akpm@linux-foundation.org, ignat@cloudflare.com,
eric_devolder@yahoo.com
Subject: Re: [PATCH 2/3] drivers/base/cpu: crash data showing should depends on KEXEC_CORE
Date: Thu, 23 Nov 2023 22:27:13 +0800 [thread overview]
Message-ID: <ZV9hQfugDw2gDTRy@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZV9eCBm5uy7/VgOX@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
On 11/23/23 at 03:13pm, Alexander Gordeev wrote:
> On Thu, Nov 23, 2023 at 03:36:51PM +0800, Baoquan He wrote:
> > When below kernel config items are set, compiling error are triggered.
> >
> > CONFIG_CRASH_CORE=y
> > CONFIG_KEXEC_CORE=y
> > CONFIG_CRASH_DUMP=y
> > CONFIG_CRASH_HOTPLUG=y
> >
> > ------------------------------------------------------
> > drivers/base/cpu.c: In function ‘crash_hotplug_show’:
> > drivers/base/cpu.c:309:40: error: implicit declaration of function ‘crash_hotplug_cpu_support’; did you mean ‘crash_hotplug_show’? [-Werror=implicit-function-declaration]
> > 309 | return sysfs_emit(buf, "%d\n", crash_hotplug_cpu_support());
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > | crash_hotplug_show
> > cc1: some warnings being treated as errors
> > ------------------------------------------------------
> >
> > CONFIG_KEXEC is used to enable kexec_load interface, the
> > crash_notes/crash_notes_size/crash_hotplug showing depends on
> > CONFIG_KEXEC is incorrect. It should depend on KEXEC_CORE instead.
> >
> > Fix it now.
>
> If this error introduced with the prevous patch?
> If so, the patches need to be swapped I guess.
From the phenomenon, yes. In fact it's the patch 1 which exposes
the wrong ifdeffery. I can shift the order in v2. Thanks.
>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
akpm@linux-foundation.org, ignat@cloudflare.com,
eric_devolder@yahoo.com
Subject: Re: [PATCH 2/3] drivers/base/cpu: crash data showing should depends on KEXEC_CORE
Date: Thu, 23 Nov 2023 22:27:13 +0800 [thread overview]
Message-ID: <ZV9hQfugDw2gDTRy@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZV9eCBm5uy7/VgOX@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
On 11/23/23 at 03:13pm, Alexander Gordeev wrote:
> On Thu, Nov 23, 2023 at 03:36:51PM +0800, Baoquan He wrote:
> > When below kernel config items are set, compiling error are triggered.
> >
> > CONFIG_CRASH_CORE=y
> > CONFIG_KEXEC_CORE=y
> > CONFIG_CRASH_DUMP=y
> > CONFIG_CRASH_HOTPLUG=y
> >
> > ------------------------------------------------------
> > drivers/base/cpu.c: In function ‘crash_hotplug_show’:
> > drivers/base/cpu.c:309:40: error: implicit declaration of function ‘crash_hotplug_cpu_support’; did you mean ‘crash_hotplug_show’? [-Werror=implicit-function-declaration]
> > 309 | return sysfs_emit(buf, "%d\n", crash_hotplug_cpu_support());
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > | crash_hotplug_show
> > cc1: some warnings being treated as errors
> > ------------------------------------------------------
> >
> > CONFIG_KEXEC is used to enable kexec_load interface, the
> > crash_notes/crash_notes_size/crash_hotplug showing depends on
> > CONFIG_KEXEC is incorrect. It should depend on KEXEC_CORE instead.
> >
> > Fix it now.
>
> If this error introduced with the prevous patch?
> If so, the patches need to be swapped I guess.
From the phenomenon, yes. In fact it's the patch 1 which exposes
the wrong ifdeffery. I can shift the order in v2. Thanks.
>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-23 14:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 7:36 [PATCH 0/3] kernel/Kconfig.kexec: drop select of KEXEC for CRASH_DUMP Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 7:36 ` [PATCH 1/3] " Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 8:23 ` Ignat Korchagin
2023-11-23 8:23 ` Ignat Korchagin
2023-11-23 8:23 ` Ignat Korchagin
2023-11-23 11:07 ` Baoquan He
2023-11-23 11:07 ` Baoquan He
2023-11-23 11:07 ` Baoquan He
2023-11-23 7:36 ` [PATCH 2/3] drivers/base/cpu: crash data showing should depends on KEXEC_CORE Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 8:34 ` Ignat Korchagin
2023-11-23 8:34 ` Ignat Korchagin
2023-11-23 8:34 ` Ignat Korchagin
2023-11-23 11:15 ` Baoquan He
2023-11-23 11:15 ` Baoquan He
2023-11-23 11:15 ` Baoquan He
2023-11-24 16:44 ` Andrew Morton
2023-11-24 16:44 ` Andrew Morton
2023-11-24 16:44 ` Andrew Morton
2023-11-25 2:29 ` Baoquan He
2023-11-25 2:29 ` Baoquan He
2023-11-25 2:29 ` Baoquan He
2023-11-23 14:13 ` Alexander Gordeev
2023-11-23 14:13 ` Alexander Gordeev
2023-11-23 14:13 ` Alexander Gordeev
2023-11-23 14:27 ` Baoquan He [this message]
2023-11-23 14:27 ` Baoquan He
2023-11-23 14:27 ` Baoquan He
2023-11-23 7:36 ` [PATCH 3/3] s390/Kconfig: drop select of KEXEC Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 7:36 ` Baoquan He
2023-11-23 13:43 ` Alexander Gordeev
2023-11-23 13:43 ` Alexander Gordeev
2023-11-23 13:43 ` Alexander Gordeev
2023-11-23 14:31 ` Baoquan He
2023-11-23 14:31 ` Baoquan He
2023-11-23 14:31 ` Baoquan He
2023-11-26 0:07 ` [PATCH 0/3] kernel/Kconfig.kexec: drop select of KEXEC for CRASH_DUMP Eric DeVolder
2023-11-26 0:07 ` Eric DeVolder
2023-11-26 0:07 ` Eric DeVolder
2023-11-27 3:29 ` Baoquan He
2023-11-27 3:29 ` Baoquan He
2023-11-27 3:29 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV9hQfugDw2gDTRy@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=eric_devolder@yahoo.com \
--cc=ignat@cloudflare.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.