All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf auxtrace: Add 'T' itrace option for timestamp trace
Date: Thu, 23 Nov 2023 11:42:18 -0300	[thread overview]
Message-ID: <ZV9kypSaAZNvaP1X@kernel.org> (raw)
In-Reply-To: <20231107141808.GD656098@leoy-yangtze.lan>

Em Tue, Nov 07, 2023 at 10:18:08PM +0800, Leo Yan escreveu:
> On Tue, Nov 07, 2023 at 12:16:25PM +0200, Adrian Hunter wrote:
> 
> [...]
> 
> > >>>> "If users know" <- how would users know?  Could the kernel
> > >>>> or tools also figure it out?
> > >>>
> > >>> Adrian, I'm trying to go all the outstanding patches, do you still have
> > >>> any issues with this series?
> > >>
> > >> No, although the question wasn't actually answered.  I presume users
> > >> just have to try the 'T' option and see if it helps.
> > > 
> > > Sometimes, users are software developers in SoC companies, they can
> > > know well for the hardware design but are confused why current
> > > implementation cannot use timestamp trace.  This is the main reason
> > > I sent this patch set.
> > > 
> > > An example hardware platform is DB410c [1], we know its CoreSight can
> > > support timestamp trace, but if without this adding option 'T', we
> > > have no chance to use it due to it its CPU arch is prior to Armv8.4.
> > 
> > perf config might be better than an itrace option, but you decide.
> 
> I understand perf config is a better approach due to users don't need
> to bother inputting options after set it once.  I will look at it and
> respin new patch set.
> 
> Thanks for suggestion!

Thanks, applied.

- Arnaldo

WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf auxtrace: Add 'T' itrace option for timestamp trace
Date: Thu, 23 Nov 2023 11:42:18 -0300	[thread overview]
Message-ID: <ZV9kypSaAZNvaP1X@kernel.org> (raw)
In-Reply-To: <20231107141808.GD656098@leoy-yangtze.lan>

Em Tue, Nov 07, 2023 at 10:18:08PM +0800, Leo Yan escreveu:
> On Tue, Nov 07, 2023 at 12:16:25PM +0200, Adrian Hunter wrote:
> 
> [...]
> 
> > >>>> "If users know" <- how would users know?  Could the kernel
> > >>>> or tools also figure it out?
> > >>>
> > >>> Adrian, I'm trying to go all the outstanding patches, do you still have
> > >>> any issues with this series?
> > >>
> > >> No, although the question wasn't actually answered.  I presume users
> > >> just have to try the 'T' option and see if it helps.
> > > 
> > > Sometimes, users are software developers in SoC companies, they can
> > > know well for the hardware design but are confused why current
> > > implementation cannot use timestamp trace.  This is the main reason
> > > I sent this patch set.
> > > 
> > > An example hardware platform is DB410c [1], we know its CoreSight can
> > > support timestamp trace, but if without this adding option 'T', we
> > > have no chance to use it due to it its CPU arch is prior to Armv8.4.
> > 
> > perf config might be better than an itrace option, but you decide.
> 
> I understand perf config is a better approach due to users don't need
> to bother inputting options after set it once.  I will look at it and
> respin new patch set.
> 
> Thanks for suggestion!

Thanks, applied.

- Arnaldo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-23 14:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-14  7:45 [PATCH v1 0/2] perf cs-etm: Add support for itrace option 'T' Leo Yan
2023-10-14  7:45 ` Leo Yan
2023-10-14  7:45 ` [PATCH v1 1/2] perf auxtrace: Add 'T' itrace option for timestamp trace Leo Yan
2023-10-14  7:45   ` Leo Yan
2023-10-19 10:31   ` James Clark
2023-10-19 10:31     ` James Clark
2023-10-19 11:52     ` Leo Yan
2023-10-19 11:52       ` Leo Yan
2023-10-19 10:47   ` Adrian Hunter
2023-10-19 10:47     ` Adrian Hunter
2023-10-19 11:17     ` James Clark
2023-10-19 11:17       ` James Clark
2023-11-06 21:52     ` Arnaldo Carvalho de Melo
2023-11-06 21:52       ` Arnaldo Carvalho de Melo
2023-11-07  7:19       ` Adrian Hunter
2023-11-07  7:19         ` Adrian Hunter
2023-11-07  9:36         ` James Clark
2023-11-07  9:36           ` James Clark
2023-11-07  9:48         ` Leo Yan
2023-11-07  9:48           ` Leo Yan
2023-11-07 10:16           ` Adrian Hunter
2023-11-07 10:16             ` Adrian Hunter
2023-11-07 14:18             ` Leo Yan
2023-11-07 14:18               ` Leo Yan
2023-11-23 14:42               ` Arnaldo Carvalho de Melo [this message]
2023-11-23 14:42                 ` Arnaldo Carvalho de Melo
2023-10-14  7:45 ` [PATCH v1 2/2] perf cs-etm: Enable itrace option 'T' Leo Yan
2023-10-14  7:45   ` Leo Yan
2023-10-19 10:38   ` James Clark
2023-10-19 10:38     ` James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZV9kypSaAZNvaP1X@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.