All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Nischala Yelchuri <niyelchu@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
	linux-fbdev@vger.kernel.org, kys@microsoft.com,
	haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	drawat.floss@gmail.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	daniel@ffwll.ch, dri-devel@lists.freedesktop.org, deller@gmx.de,
	mhklinux@outlook.com, mhkelley@outlook.com,
	singhabhinav9051571833@gmail.com, niyelchu@microsoft.com
Subject: Re: [PATCH] Replace ioremap_cache() with memremap()
Date: Sun, 12 Nov 2023 23:12:33 +0000	[thread overview]
Message-ID: <ZVFb4f8IRJeCFmYD@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1698854508-23036-1-git-send-email-niyelchu@linux.microsoft.com>

On Wed, Nov 01, 2023 at 09:01:48AM -0700, Nischala Yelchuri wrote:
> Current Hyper-V code for CoCo VMs uses ioremap_cache() to map normal memory as decrypted.
> ioremap_cache() is ideally used to map I/O device memory when it has the characteristics
> of normal memory. It should not be used to map normal memory as the returned pointer
> has the __iomem attribute.

Do you find any real world issues with the current code? How do you
discover these issues?

Thanks,
Wei.

WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu@kernel.org>
To: Nischala Yelchuri <niyelchu@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, dave.hansen@linux.intel.com,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	hpa@zytor.com, kys@microsoft.com, wei.liu@kernel.org,
	deller@gmx.de, x86@kernel.org, decui@microsoft.com,
	mhkelley@outlook.com, drawat.floss@gmail.com, mingo@redhat.com,
	haiyangz@microsoft.com, mripard@kernel.org,
	singhabhinav9051571833@gmail.com, bp@alien8.de,
	tglx@linutronix.de, mhklinux@outlook.com, niyelchu@microsoft.com,
	linux-kernel@vger.kernel.org, tzimmermann@suse.de
Subject: Re: [PATCH] Replace ioremap_cache() with memremap()
Date: Sun, 12 Nov 2023 23:12:33 +0000	[thread overview]
Message-ID: <ZVFb4f8IRJeCFmYD@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1698854508-23036-1-git-send-email-niyelchu@linux.microsoft.com>

On Wed, Nov 01, 2023 at 09:01:48AM -0700, Nischala Yelchuri wrote:
> Current Hyper-V code for CoCo VMs uses ioremap_cache() to map normal memory as decrypted.
> ioremap_cache() is ideally used to map I/O device memory when it has the characteristics
> of normal memory. It should not be used to map normal memory as the returned pointer
> has the __iomem attribute.

Do you find any real world issues with the current code? How do you
discover these issues?

Thanks,
Wei.

  parent reply	other threads:[~2023-11-12 23:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 16:01 [PATCH] Replace ioremap_cache() with memremap() Nischala Yelchuri
2023-11-01 16:01 ` Nischala Yelchuri
2023-11-05 15:15 ` Michael Kelley
2023-11-05 15:15   ` Michael Kelley
2023-11-12 23:12 ` Wei Liu [this message]
2023-11-12 23:12   ` Wei Liu
2023-11-27 18:56   ` Nischala Yelchuri
2023-11-27 18:56     ` Nischala Yelchuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVFb4f8IRJeCFmYD@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=airlied@gmail.com \
    --cc=bp@alien8.de \
    --cc=daniel@ffwll.ch \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=deller@gmx.de \
    --cc=drawat.floss@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kys@microsoft.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mhkelley@outlook.com \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=mripard@kernel.org \
    --cc=niyelchu@linux.microsoft.com \
    --cc=niyelchu@microsoft.com \
    --cc=singhabhinav9051571833@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tzimmermann@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.