All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/intel: fix indentation
@ 2023-11-13  8:51 Roger Pau Monne
  2023-11-13  9:22 ` Jan Beulich
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monne @ 2023-11-13  8:51 UTC (permalink / raw)
  To: xen-devel; +Cc: Roger Pau Monne, Jan Beulich, Andrew Cooper, Wei Liu

Adjust line to use a hard tab and align using spaces afterwards, instead of
using all spaces.

Fixes: fc3090a47b21 ('x86/boot: Clear XD_DISABLE from the early boot path')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Realized while doing backports, not sure if it's worth fixing on it's own.
---
 xen/arch/x86/cpu/intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c
index a8ba3191e618..dfee64689ffe 100644
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -307,7 +307,7 @@ static void cf_check early_init_intel(struct cpuinfo_x86 *c)
 		c->x86_cache_alignment = 128;
 
 	if (c == &boot_cpu_data &&
-            bootsym(trampoline_misc_enable_off) & MSR_IA32_MISC_ENABLE_XD_DISABLE)
+	    bootsym(trampoline_misc_enable_off) & MSR_IA32_MISC_ENABLE_XD_DISABLE)
 		printk(KERN_INFO "re-enabled NX (Execute Disable) protection\n");
 
 	/* Unmask CPUID levels and NX if masked: */
-- 
2.42.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/intel: fix indentation
  2023-11-13  8:51 [PATCH] x86/intel: fix indentation Roger Pau Monne
@ 2023-11-13  9:22 ` Jan Beulich
  2023-11-13  9:57   ` Roger Pau Monné
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2023-11-13  9:22 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: Andrew Cooper, Wei Liu, xen-devel

On 13.11.2023 09:51, Roger Pau Monne wrote:
> Adjust line to use a hard tab and align using spaces afterwards, instead of
> using all spaces.
> 
> Fixes: fc3090a47b21 ('x86/boot: Clear XD_DISABLE from the early boot path')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> ---
> Realized while doing backports, not sure if it's worth fixing on it's own.

Fine for staging, but regardless of the Fixes: tag not a backporting
candidate imo.

Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/intel: fix indentation
  2023-11-13  9:22 ` Jan Beulich
@ 2023-11-13  9:57   ` Roger Pau Monné
  0 siblings, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2023-11-13  9:57 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Andrew Cooper, Wei Liu, xen-devel

On Mon, Nov 13, 2023 at 10:22:19AM +0100, Jan Beulich wrote:
> On 13.11.2023 09:51, Roger Pau Monne wrote:
> > Adjust line to use a hard tab and align using spaces afterwards, instead of
> > using all spaces.
> > 
> > Fixes: fc3090a47b21 ('x86/boot: Clear XD_DISABLE from the early boot path')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> > ---
> > Realized while doing backports, not sure if it's worth fixing on it's own.
> 
> Fine for staging, but regardless of the Fixes: tag not a backporting
> candidate imo.

No, not unless there's a further backport that requires the adjusted
context maybe.

Thanks, Roger.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-13  9:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13  8:51 [PATCH] x86/intel: fix indentation Roger Pau Monne
2023-11-13  9:22 ` Jan Beulich
2023-11-13  9:57   ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.