All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH] scripts: clean up IA-64 code
Date: Sun, 19 Nov 2023 21:58:16 +0100	[thread overview]
Message-ID: <ZVp26K9b8Apuy3FD@fjasle.eu> (raw)
In-Reply-To: <20231118081334.1308242-1-masahiroy@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On Sat, Nov 18, 2023 at 05:13:34PM +0900 Masahiro Yamada wrote:
> A little more janitorial work after commit cf8e8658100d ("arch: Remove
> Itanium (IA-64) architecture").
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/checkstack.pl        |  3 ---
>  scripts/gdb/linux/tasks.py   | 15 +++------------
>  scripts/head-object-list.txt |  1 -
>  scripts/kconfig/mconf.c      |  2 +-
>  scripts/kconfig/nconf.c      |  2 +-
>  scripts/package/kernel.spec  |  6 ------
>  scripts/package/mkdebian     |  2 +-
>  scripts/recordmcount.pl      |  7 -------
>  scripts/xz_wrap.sh           |  1 -
>  9 files changed, 6 insertions(+), 33 deletions(-)
> 

Thanks, looks good to me.  Might you want to also remove replace the last
references in the kbuild files?

scripts/recordmcount.c  uses cpp symbol EM_IA_64
Makefile                contains two comments with examples naming IA64
scripts/checkstack.pl   still holds credits for its (now removed) IA64 port,
                        but that might have been left by intention

Nevertheless:

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

Kind regards,
Nicolas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH] scripts: clean up IA-64 code
Date: Sun, 19 Nov 2023 21:58:16 +0100	[thread overview]
Message-ID: <ZVp26K9b8Apuy3FD@fjasle.eu> (raw)
In-Reply-To: <20231118081334.1308242-1-masahiroy@kernel.org>


[-- Attachment #1.1: Type: text/plain, Size: 1169 bytes --]

On Sat, Nov 18, 2023 at 05:13:34PM +0900 Masahiro Yamada wrote:
> A little more janitorial work after commit cf8e8658100d ("arch: Remove
> Itanium (IA-64) architecture").
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/checkstack.pl        |  3 ---
>  scripts/gdb/linux/tasks.py   | 15 +++------------
>  scripts/head-object-list.txt |  1 -
>  scripts/kconfig/mconf.c      |  2 +-
>  scripts/kconfig/nconf.c      |  2 +-
>  scripts/package/kernel.spec  |  6 ------
>  scripts/package/mkdebian     |  2 +-
>  scripts/recordmcount.pl      |  7 -------
>  scripts/xz_wrap.sh           |  1 -
>  9 files changed, 6 insertions(+), 33 deletions(-)
> 

Thanks, looks good to me.  Might you want to also remove replace the last
references in the kbuild files?

scripts/recordmcount.c  uses cpp symbol EM_IA_64
Makefile                contains two comments with examples naming IA64
scripts/checkstack.pl   still holds credits for its (now removed) IA64 port,
                        but that might have been left by intention

Nevertheless:

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

Kind regards,
Nicolas

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-11-19 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  8:13 [PATCH] scripts: clean up IA-64 code Masahiro Yamada
2023-11-18  8:13 ` Masahiro Yamada
2023-11-19 20:58 ` Nicolas Schier [this message]
2023-11-19 20:58   ` Nicolas Schier
2023-11-20  4:18   ` Masahiro Yamada
2023-11-20  4:18     ` Masahiro Yamada
2023-11-20  5:15     ` Nicolas Schier
2023-11-20  5:15       ` Nicolas Schier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVp26K9b8Apuy3FD@fjasle.eu \
    --to=nicolas@fjasle.eu \
    --cc=aou@eecs.berkeley.edu \
    --cc=jan.kiszka@siemens.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.