From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH V3] leds: gpio: Add kernel log if devm_fwnode_gpiod_get fails
Date: Mon, 4 Dec 2023 16:03:20 +0200 [thread overview]
Message-ID: <ZW3cKOcFt4g4H7Mm@smile.fi.intel.com> (raw)
In-Reply-To: <20231202183636.7055-1-wahrenst@gmx.net>
On Sat, Dec 02, 2023 at 07:36:36PM +0100, Stefan Wahren wrote:
> In case leds-gpio fails to get at least one of possibly many GPIOs
> from the DT (e.g. the GPIO is already requested) neither gpiolib nor
> the driver does provide any helpful error log:
>
> leds-gpio: probe of leds failed with error -16
>
> As the driver knows better how to handle errors with such mandatory
> GPIOs, let's implement an error log which points to the affected
> GPIO.
As we have had a consensus,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-04 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 18:36 [PATCH V3] leds: gpio: Add kernel log if devm_fwnode_gpiod_get fails Stefan Wahren
2023-12-04 10:21 ` Linus Walleij
2023-12-04 14:03 ` Andy Shevchenko [this message]
2023-12-07 16:08 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW3cKOcFt4g4H7Mm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.