From: Andi Shyti <andi.shyti@linux.intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.
Date: Mon, 4 Dec 2023 20:52:03 +0100 [thread overview]
Message-ID: <ZW4t485KNGFaOTwq@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231201154443.16660-1-nirmoy.das@intel.com>
Hi Nirmoy,
On Fri, Dec 01, 2023 at 04:44:43PM +0100, Nirmoy Das wrote:
> gen8_engine_reset_prepare() can fail when HW fails to set
> RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal
> error as driver will retry.
>
> Let the caller of gen8_engine_reset_prepare() decide if a
> failure in gen8_engine_reset_prepare is an error or not.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Andi Shyti <andi.shyti@linux.intel.com>,
John Harrison <John.C.Harrison@intel.com>
Subject: Re: [PATCH] drm/i915/gt: Reduce log severity on reset prepare.
Date: Mon, 4 Dec 2023 20:52:03 +0100 [thread overview]
Message-ID: <ZW4t485KNGFaOTwq@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231201154443.16660-1-nirmoy.das@intel.com>
Hi Nirmoy,
On Fri, Dec 01, 2023 at 04:44:43PM +0100, Nirmoy Das wrote:
> gen8_engine_reset_prepare() can fail when HW fails to set
> RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal
> error as driver will retry.
>
> Let the caller of gen8_engine_reset_prepare() decide if a
> failure in gen8_engine_reset_prepare is an error or not.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
next prev parent reply other threads:[~2023-12-04 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:44 [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare Nirmoy Das
2023-12-01 15:44 ` Nirmoy Das
2023-12-02 2:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-12-03 5:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-12-04 19:52 ` Andi Shyti [this message]
2023-12-04 19:52 ` [PATCH] " Andi Shyti
2023-12-05 1:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Reduce log severity on reset prepare. (rev2) Patchwork
2023-12-05 6:58 ` [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare Andrzej Hajda
2023-12-05 6:58 ` Andrzej Hajda
2023-12-05 8:34 ` [Intel-gfx] " Tvrtko Ursulin
2023-12-05 8:50 ` Nirmoy Das
2023-12-05 10:05 ` Tvrtko Ursulin
2023-12-05 10:44 ` Nirmoy Das
2023-12-05 10:52 ` Tvrtko Ursulin
2023-12-05 9:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Reduce log severity on reset prepare. (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW4t485KNGFaOTwq@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.