From: Michal Hocko <mhocko@suse.com>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc: shakeelb@google.com, rostedt@goodmis.org, mhiramat@kernel.org,
hannes@cmpxchg.org, roman.gushchin@linux.dev,
muchun.song@linux.dev, akpm@linux-foundation.org,
kernel@sberdevices.ru, rockosov@gmail.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm: memcg: introduce new event to trace shrink_memcg
Date: Mon, 27 Nov 2023 10:25:12 +0100 [thread overview]
Message-ID: <ZWRgeAMxQ580-Fgd@tiehlicka> (raw)
In-Reply-To: <20231123112629.2rwxr7gtmbyirwua@CAB-WSD-L081021>
On Thu 23-11-23 14:26:29, Dmitry Rokosov wrote:
> Michal, Shakeel,
>
> Sorry for pinging you here, but I don't quite understand your decision
> on this patchset.
>
> Is it a NAK or not? If it's not, should I consider redesigning
> something? For instance, introducing stub functions to
> remove ifdefs from shrink_node_memcgs().
>
> Thank you for taking the time to look into this!
Sorry for a late reply. I have noticed you have posted a new version.
Let me have a look and comment there.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-11-27 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 10:01 [PATCH v2 0/2] mm: memcg: improve vmscan tracepoints Dmitry Rokosov
2023-11-22 10:01 ` [PATCH v2 1/2] mm: memcg: print out cgroup name in the memcg tracepoints Dmitry Rokosov
2023-11-23 7:21 ` Shakeel Butt
2023-11-23 8:03 ` Dmitry Rokosov
2023-11-23 8:15 ` Shakeel Butt
2023-11-23 8:45 ` Dmitry Rokosov
2023-11-23 11:21 ` Dmitry Rokosov
2023-11-22 10:01 ` [PATCH v2 2/2] mm: memcg: introduce new event to trace shrink_memcg Dmitry Rokosov
2023-11-22 10:23 ` Michal Hocko
2023-11-22 10:58 ` Dmitry Rokosov
2023-11-22 13:24 ` Michal Hocko
2023-11-22 18:57 ` Dmitry Rokosov
2023-11-23 11:26 ` Dmitry Rokosov
2023-11-27 9:25 ` Michal Hocko [this message]
2023-11-27 11:37 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWRgeAMxQ580-Fgd@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=ddrokosov@salutedevices.com \
--cc=hannes@cmpxchg.org \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=muchun.song@linux.dev \
--cc=rockosov@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.