From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
jolsa@kernel.org, adrian.hunter@intel.com, irogers@google.com,
namhyung@kernel.org, linux-perf-users@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com,
kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com
Subject: Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf
Date: Mon, 27 Nov 2023 11:51:23 -0300 [thread overview]
Message-ID: <ZWSs6zn1NqWqzoyC@kernel.org> (raw)
In-Reply-To: <e8143e4d-d3ca-88c5-f1c8-b79f70ee5ffa@arm.com>
Em Mon, Nov 27, 2023 at 11:12:57AM +0000, James Clark escreveu:
> On 23/11/2023 16:02, Athira Rajeev wrote:
> > Add rule in new Makefile "tests/Makefile.tests" for running
> > shellcheck on shell test scripts. This automates below shellcheck
> > into the build.
> Seems to work really well. I also tested it on Ubuntu, and checked
> NO_SHELLCHECK, cleaning and with and without shellcheck installed etc.
> Reviewed-by: James Clark <james.clark@arm.com>
Tested on Fedora 38, works as advertised, applied.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: irogers@google.com, Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
kjain@linux.ibm.com, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, maddy@linux.ibm.com,
jolsa@kernel.org, namhyung@kernel.org,
disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf
Date: Mon, 27 Nov 2023 11:51:23 -0300 [thread overview]
Message-ID: <ZWSs6zn1NqWqzoyC@kernel.org> (raw)
In-Reply-To: <e8143e4d-d3ca-88c5-f1c8-b79f70ee5ffa@arm.com>
Em Mon, Nov 27, 2023 at 11:12:57AM +0000, James Clark escreveu:
> On 23/11/2023 16:02, Athira Rajeev wrote:
> > Add rule in new Makefile "tests/Makefile.tests" for running
> > shellcheck on shell test scripts. This automates below shellcheck
> > into the build.
> Seems to work really well. I also tested it on Ubuntu, and checked
> NO_SHELLCHECK, cleaning and with and without shellcheck installed etc.
> Reviewed-by: James Clark <james.clark@arm.com>
Tested on Fedora 38, works as advertised, applied.
- Arnaldo
next prev parent reply other threads:[~2023-11-27 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 16:02 [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf Athira Rajeev
2023-11-23 16:02 ` Athira Rajeev
2023-11-27 11:12 ` James Clark
2023-11-27 11:12 ` James Clark
2023-11-27 14:51 ` Arnaldo Carvalho de Melo [this message]
2023-11-27 14:51 ` Arnaldo Carvalho de Melo
2023-11-29 5:22 ` Athira Rajeev
2023-11-29 5:22 ` Athira Rajeev
2023-12-05 21:50 ` Arnaldo Carvalho de Melo
2023-12-05 21:50 ` Arnaldo Carvalho de Melo
2023-12-05 22:09 ` Ian Rogers
2023-12-05 22:09 ` Ian Rogers
2023-12-06 12:28 ` Arnaldo Carvalho de Melo
2023-12-06 12:28 ` Arnaldo Carvalho de Melo
2023-12-06 4:45 ` Athira Rajeev
2023-12-06 4:45 ` Athira Rajeev
2023-12-06 12:29 ` Arnaldo Carvalho de Melo
2023-12-06 12:29 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWSs6zn1NqWqzoyC@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.