* Re: Patch "bpf: Fix dev's rx stats for bpf_redirect_peer traffic" has been added to the 6.6-stable tree [not found] <20231129025247.890789-1-sashal@kernel.org> @ 2023-11-29 6:05 ` Peilin Ye 2023-11-29 19:30 ` Sasha Levin 0 siblings, 1 reply; 2+ messages in thread From: Peilin Ye @ 2023-11-29 6:05 UTC (permalink / raw) To: Sasha Levin Cc: stable-commits, peilin.ye, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Cong Wang, yepeilin.cs, stable +Cc: Cong Wang <cong.wang@bytedance.com> Hi all, On Tue, Nov 28, 2023 at 09:52:46PM -0500, Sasha Levin wrote: > > This is a note to let you know that I've just added the patch titled > > bpf: Fix dev's rx stats for bpf_redirect_peer traffic > > to the 6.6-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > bpf-fix-dev-s-rx-stats-for-bpf_redirect_peer-traffic.patch > and it can be found in the queue-6.6 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@vger.kernel.org> know about it. Seems like only patch 1, 2 and 5 in this [1] series are selected? We also need patch 4, upstream commit 6f2684bf2b44 ("veth: Use tstats per-CPU traffic counters"). Otherwise the fix won't work, and the code will be wrong [2] . We should've included a "Depends on patch..." note for stable in the commit message. Thanks, Peilin Ye [1] https://lore.kernel.org/all/170050562585.4532.1588179408610417971.git-patchwork-notify@kernel.org/ [2] veth still uses @lstats, but patch 5 makes skb_do_redirect() update it as @tstats. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch "bpf: Fix dev's rx stats for bpf_redirect_peer traffic" has been added to the 6.6-stable tree 2023-11-29 6:05 ` Patch "bpf: Fix dev's rx stats for bpf_redirect_peer traffic" has been added to the 6.6-stable tree Peilin Ye @ 2023-11-29 19:30 ` Sasha Levin 0 siblings, 0 replies; 2+ messages in thread From: Sasha Levin @ 2023-11-29 19:30 UTC (permalink / raw) To: Peilin Ye Cc: stable-commits, peilin.ye, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Cong Wang, stable On Wed, Nov 29, 2023 at 06:05:17AM +0000, Peilin Ye wrote: >+Cc: Cong Wang <cong.wang@bytedance.com> > >Hi all, > >On Tue, Nov 28, 2023 at 09:52:46PM -0500, Sasha Levin wrote: >> >> This is a note to let you know that I've just added the patch titled >> >> bpf: Fix dev's rx stats for bpf_redirect_peer traffic >> >> to the 6.6-stable tree which can be found at: >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >> >> The filename of the patch is: >> bpf-fix-dev-s-rx-stats-for-bpf_redirect_peer-traffic.patch >> and it can be found in the queue-6.6 subdirectory. >> >> If you, or anyone else, feels it should not be added to the stable tree, >> please let <stable@vger.kernel.org> know about it. > >Seems like only patch 1, 2 and 5 in this [1] series are selected? We >also need patch 4, upstream commit 6f2684bf2b44 ("veth: Use tstats >per-CPU traffic counters"). Otherwise the fix won't work, and the code >will be wrong [2] . > >We should've included a "Depends on patch..." note for stable in the >commit message. I'll take it too, thanks! -- Thanks, Sasha ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-29 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231129025247.890789-1-sashal@kernel.org>
2023-11-29 6:05 ` Patch "bpf: Fix dev's rx stats for bpf_redirect_peer traffic" has been added to the 6.6-stable tree Peilin Ye
2023-11-29 19:30 ` Sasha Levin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.