From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: Kunkun Jiang <jiangkunkun@huawei.com>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>,
kvmarm@lists.linux.dev, open list <linux-kernel@vger.kernel.org>,
"wanghaibin.wang@huawei.com" <wanghaibin.wang@huawei.com>
Subject: Re: [bug report] GICv4.1: vSGI remains pending across the guest reset
Date: Sun, 17 Dec 2023 17:33:10 +0000 [thread overview]
Message-ID: <ZX8w1vfQzeXP5klL@linux.dev> (raw)
In-Reply-To: <87a5q983zc.wl-maz@kernel.org>
On Sun, Dec 17, 2023 at 11:26:15AM +0000, Marc Zyngier wrote:
[...]
> But this has *nothing* to do with the guest. This is the *host*
> userspace performing a write to the redistributor view, which has
> different semantics. Which is why your earlier description made no
> sense to me.
>
> I think the problem is slightly larger than what you describe. A write
> to ISPENDR0 should be propagated to the ITS for any values of the
> latch, just like this happens on enabling HW-backed SGIs.
>
> Can you please give this a go?
What do you think about using this as an opportunity for a bit of
cleanup? It'd be nice unify the various MMIO and uaccess handlers for
SPENDING + CPENDING while being careful about the arch_timer interrupt.
clear = ~val;
vgic_uaccess_write_spending(val);
vgic_uaccess_write_cpending(clear);
Happy to take your fix too, especially in case I missed something
obvious :)
[*] https://git.kernel.org/pub/scm/linux/kernel/git/oupton/linux.git/log/?h=kvm-arm64/vsgi-spending-fixes
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: Kunkun Jiang <jiangkunkun@huawei.com>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>,
kvmarm@lists.linux.dev, open list <linux-kernel@vger.kernel.org>,
"wanghaibin.wang@huawei.com" <wanghaibin.wang@huawei.com>
Subject: Re: [bug report] GICv4.1: vSGI remains pending across the guest reset
Date: Sun, 17 Dec 2023 17:33:10 +0000 [thread overview]
Message-ID: <ZX8w1vfQzeXP5klL@linux.dev> (raw)
In-Reply-To: <87a5q983zc.wl-maz@kernel.org>
On Sun, Dec 17, 2023 at 11:26:15AM +0000, Marc Zyngier wrote:
[...]
> But this has *nothing* to do with the guest. This is the *host*
> userspace performing a write to the redistributor view, which has
> different semantics. Which is why your earlier description made no
> sense to me.
>
> I think the problem is slightly larger than what you describe. A write
> to ISPENDR0 should be propagated to the ITS for any values of the
> latch, just like this happens on enabling HW-backed SGIs.
>
> Can you please give this a go?
What do you think about using this as an opportunity for a bit of
cleanup? It'd be nice unify the various MMIO and uaccess handlers for
SPENDING + CPENDING while being careful about the arch_timer interrupt.
clear = ~val;
vgic_uaccess_write_spending(val);
vgic_uaccess_write_cpending(clear);
Happy to take your fix too, especially in case I missed something
obvious :)
[*] https://git.kernel.org/pub/scm/linux/kernel/git/oupton/linux.git/log/?h=kvm-arm64/vsgi-spending-fixes
--
Thanks,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-17 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 12:13 [bug report] GICv4.1: vSGI remains pending across the guest reset Kunkun Jiang
2023-12-14 12:13 ` Kunkun Jiang
2023-12-17 11:26 ` Marc Zyngier
2023-12-17 11:26 ` Marc Zyngier
2023-12-17 17:33 ` Oliver Upton [this message]
2023-12-17 17:33 ` Oliver Upton
2023-12-17 17:34 ` Oliver Upton
2023-12-17 17:34 ` Oliver Upton
2023-12-17 18:52 ` Marc Zyngier
2023-12-17 18:52 ` Marc Zyngier
2023-12-18 17:20 ` Oliver Upton
2023-12-18 17:20 ` Oliver Upton
2023-12-18 17:29 ` Marc Zyngier
2023-12-18 17:29 ` Marc Zyngier
2023-12-19 9:32 ` Zenghui Yu
2023-12-19 9:32 ` Zenghui Yu
2023-12-19 7:24 ` Kunkun Jiang
2023-12-19 7:24 ` Kunkun Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZX8w1vfQzeXP5klL@linux.dev \
--to=oliver.upton@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=jiangkunkun@huawei.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.