From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Yu Kuai <yukuai1@huaweicloud.com>,
axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de,
kent.overstreet@gmail.com, joern@lazybastard.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, nico@fluxnic.net, xiang@kernel.org,
chao@kernel.org, adilger.kernel@dilger.ca, agruenba@redhat.com,
jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org,
akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-ext4@vger.kernel.org, gfs2@lists.linux.dev,
linux-nilfs@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next RFC 01/14] block: add some bdev apis
Date: Wed, 6 Dec 2023 09:57:46 -0800 [thread overview]
Message-ID: <ZXC2Gg7NPWu9MULx@infradead.org> (raw)
In-Reply-To: <20231206175038.GJ509422@mit.edu>
On Wed, Dec 06, 2023 at 12:50:38PM -0500, Theodore Ts'o wrote:
> This was added because pulling a mounted a USB thumb drive (or a HDD
> drops off the SATA bus) while the file system is mounted and actively
> in use, would result in a kernel OOPS. If that's no longer true,
> that's great, but it would be good to test to make sure this is the
> case....
And, surprise, surprise - that didn't just affect ext4. So I ended
up fixing this properly in the block layer.
> If we really want to remove it, I'd suggest doing this as a separate
> commit, so that after we see syzbot reports, or users complaining
> about kernel crashes, we can revert the removal if necessary.
Yes, this should of course be separate, well documented commit.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: hoeppner@linux.ibm.com, vigneshr@ti.com, yi.zhang@huawei.com,
gfs2@lists.linux.dev, clm@fb.com, adilger.kernel@dilger.ca,
miquel.raynal@bootlin.com, agordeev@linux.ibm.com,
linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
agruenba@redhat.com, linux-scsi@vger.kernel.org, richard@nod.at,
willy@infradead.org, Christoph Hellwig <hch@infradead.org>,
linux-bcachefs@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-ext4@vger.kernel.org, Yu Kuai <yukuai1@huaweicloud.com>,
jejb@linux.ibm.com, p.raghav@samsung.com, gor@linux.ibm.com,
hca@linux.ibm.com, joern@lazybastard.org, josef@toxicpanda.com,
colyli@suse.de, linux-block@vger.kernel.org,
linux-bcache@vger.kernel.org, sth@linux.ibm.com,
yukuai3@huawei.com, dsterba@suse.com, konishi.ryusuke@gmail.com,
axboe@kernel.dk, martin.petersen@oracle.com, nico@fluxnic.net,
yangerkun@huawei.com, linux-kernel@vger.kernel.org,
kent.overstreet@gmail.com, hare@suse.de, jack@suse.com,
linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org,
roger.pau@citrix.com
Subject: Re: [PATCH -next RFC 01/14] block: add some bdev apis
Date: Wed, 6 Dec 2023 09:57:46 -0800 [thread overview]
Message-ID: <ZXC2Gg7NPWu9MULx@infradead.org> (raw)
In-Reply-To: <20231206175038.GJ509422@mit.edu>
On Wed, Dec 06, 2023 at 12:50:38PM -0500, Theodore Ts'o wrote:
> This was added because pulling a mounted a USB thumb drive (or a HDD
> drops off the SATA bus) while the file system is mounted and actively
> in use, would result in a kernel OOPS. If that's no longer true,
> that's great, but it would be good to test to make sure this is the
> case....
And, surprise, surprise - that didn't just affect ext4. So I ended
up fixing this properly in the block layer.
> If we really want to remove it, I'd suggest doing this as a separate
> commit, so that after we see syzbot reports, or users complaining
> about kernel crashes, we can revert the removal if necessary.
Yes, this should of course be separate, well documented commit.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Yu Kuai <yukuai1@huaweicloud.com>,
axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de,
kent.overstreet@gmail.com, joern@lazybastard.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, nico@fluxnic.net, xiang@kernel.org,
chao@kernel.org, adilger.kernel@dilger.ca, agruenba@redhat.com,
jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org,
akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-ext4@vger.kernel.org, gfs2@lists.linux.dev,
linux-nilfs@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next RFC 01/14] block: add some bdev apis
Date: Wed, 6 Dec 2023 09:57:46 -0800 [thread overview]
Message-ID: <ZXC2Gg7NPWu9MULx@infradead.org> (raw)
In-Reply-To: <20231206175038.GJ509422@mit.edu>
On Wed, Dec 06, 2023 at 12:50:38PM -0500, Theodore Ts'o wrote:
> This was added because pulling a mounted a USB thumb drive (or a HDD
> drops off the SATA bus) while the file system is mounted and actively
> in use, would result in a kernel OOPS. If that's no longer true,
> that's great, but it would be good to test to make sure this is the
> case....
And, surprise, surprise - that didn't just affect ext4. So I ended
up fixing this properly in the block layer.
> If we really want to remove it, I'd suggest doing this as a separate
> commit, so that after we see syzbot reports, or users complaining
> about kernel crashes, we can revert the removal if necessary.
Yes, this should of course be separate, well documented commit.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-12-06 17:58 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 12:37 [PATCH -next RFC 00/14] block: don't access bd_inode directly from other modules Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 01/14] block: add some bdev apis Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 17:03 ` Bart Van Assche
2023-12-05 17:03 ` Bart Van Assche
2023-12-05 17:03 ` Bart Van Assche
2023-12-06 6:14 ` Christoph Hellwig
2023-12-06 6:14 ` Christoph Hellwig
2023-12-06 6:14 ` Christoph Hellwig
2023-12-06 6:50 ` Yu Kuai
2023-12-06 6:50 ` Yu Kuai
2023-12-06 6:50 ` Yu Kuai
2023-12-06 7:20 ` Christoph Hellwig
2023-12-06 7:20 ` Christoph Hellwig
2023-12-06 7:20 ` Christoph Hellwig
2023-12-06 17:50 ` Theodore Ts'o
2023-12-06 17:50 ` Theodore Ts'o
2023-12-06 17:50 ` Theodore Ts'o
2023-12-06 17:57 ` Christoph Hellwig [this message]
2023-12-06 17:57 ` Christoph Hellwig
2023-12-06 17:57 ` Christoph Hellwig
2023-12-06 14:58 ` Matthew Wilcox
2023-12-06 14:58 ` Matthew Wilcox
2023-12-06 14:58 ` Matthew Wilcox
2023-12-07 2:45 ` Yu Kuai
2023-12-07 2:45 ` Yu Kuai
2023-12-07 2:45 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 02/14] xen/blkback: use bdev api in xen_update_blkif_status() Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-06 5:55 ` Christoph Hellwig
2023-12-06 5:55 ` Christoph Hellwig
2023-12-06 5:55 ` Christoph Hellwig
2023-12-06 6:56 ` Yu Kuai
2023-12-06 6:56 ` Yu Kuai
2023-12-06 6:56 ` Yu Kuai
2023-12-06 7:21 ` Christoph Hellwig
2023-12-06 7:21 ` Christoph Hellwig
2023-12-06 7:21 ` Christoph Hellwig
2023-12-05 12:37 ` [PATCH -next RFC 03/14] bcache: use bdev api in read_super() Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 04/14] mtd: block2mtd: use bdev apis Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 05/14] s390/dasd: use bdev api in dasd_format() Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 06/14] scsicam: use bdev api in scsi_bios_ptable() Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 07/14] bcachefs: remove dead function bdev_sectors() Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 08/14] btrfs: use bdev apis Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 09/14] cramfs: use bdev apis in cramfs_blkdev_read() Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 10/14] erofs: use bdev api Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` [PATCH -next RFC 11/14] ext4: use bdev apis Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:37 ` Yu Kuai
2023-12-05 12:38 ` [PATCH -next RFC 12/14] jbd2: " Yu Kuai
2023-12-05 12:38 ` Yu Kuai
2023-12-05 12:38 ` Yu Kuai
2023-12-05 12:39 ` [PATCH -next RFC 13/14] gfs2: use bdev api Yu Kuai
2023-12-05 12:39 ` Yu Kuai
2023-12-05 12:39 ` Yu Kuai
2023-12-05 12:39 ` [PATCH -next RFC 14/14] nilfs2: use bdev api in nilfs_attach_log_writer() Yu Kuai
2023-12-05 12:39 ` Yu Kuai
2023-12-05 12:39 ` Yu Kuai
2023-12-06 5:54 ` [PATCH -next RFC 00/14] block: don't access bd_inode directly from other modules Christoph Hellwig
2023-12-06 5:54 ` Christoph Hellwig
2023-12-06 5:54 ` Christoph Hellwig
2023-12-06 6:06 ` Yu Kuai
2023-12-06 6:06 ` Yu Kuai
2023-12-06 6:06 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXC2Gg7NPWu9MULx@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=agordeev@linux.ibm.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=gor@linux.ibm.com \
--cc=hare@suse.de \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=jack@suse.com \
--cc=jejb@linux.ibm.com \
--cc=joern@lazybastard.org \
--cc=josef@toxicpanda.com \
--cc=kent.overstreet@gmail.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=nico@fluxnic.net \
--cc=p.raghav@samsung.com \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=sth@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=vigneshr@ti.com \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiang@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.