From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: dmitry.baryshkov@linaro.org, gregkh@linuxfoundation.org,
linux@roeck-us.net, neil.armstrong@linaro.org,
bryan.odonoghue@linaro.org, linux-usb@vger.kernel.org,
dri-devel@lists.freedesktop.org, patches@lists.linux.dev
Subject: Re: [PATCH 1/3] usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE with OF
Date: Thu, 7 Dec 2023 11:02:09 +0200 [thread overview]
Message-ID: <ZXGKEXDAMM6yUup7@kuha.fi.intel.com> (raw)
In-Reply-To: <20231205-drm_aux_bridge-fixes-v1-1-d242a0ae9df4@kernel.org>
On Tue, Dec 05, 2023 at 01:13:34PM -0700, Nathan Chancellor wrote:
> CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not
> included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a
> Kconfig warning when CONFIG_OF is disabled:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> Selected by [y]:
> - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>
> Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and
> CONFIG_OF to clear up the warning.
>
> Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 5120942f309d..38416fb0cc3c 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -40,7 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> depends on I2C
> depends on DRM || DRM=n
> - select DRM_AUX_BRIDGE if DRM_BRIDGE
> + select DRM_AUX_BRIDGE if DRM_BRIDGE && OF
> select REGMAP_I2C
> help
> Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C
>
> --
> 2.43.0
--
heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: neil.armstrong@linaro.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, patches@lists.linux.dev,
dri-devel@lists.freedesktop.org, dmitry.baryshkov@linaro.org,
bryan.odonoghue@linaro.org, linux@roeck-us.net
Subject: Re: [PATCH 1/3] usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE with OF
Date: Thu, 7 Dec 2023 11:02:09 +0200 [thread overview]
Message-ID: <ZXGKEXDAMM6yUup7@kuha.fi.intel.com> (raw)
In-Reply-To: <20231205-drm_aux_bridge-fixes-v1-1-d242a0ae9df4@kernel.org>
On Tue, Dec 05, 2023 at 01:13:34PM -0700, Nathan Chancellor wrote:
> CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not
> included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a
> Kconfig warning when CONFIG_OF is disabled:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> Selected by [y]:
> - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>
> Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and
> CONFIG_OF to clear up the warning.
>
> Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 5120942f309d..38416fb0cc3c 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -40,7 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> depends on I2C
> depends on DRM || DRM=n
> - select DRM_AUX_BRIDGE if DRM_BRIDGE
> + select DRM_AUX_BRIDGE if DRM_BRIDGE && OF
> select REGMAP_I2C
> help
> Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C
>
> --
> 2.43.0
--
heikki
next prev parent reply other threads:[~2023-12-07 9:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:13 [PATCH 0/3] A few fixes for transparent bridge support Nathan Chancellor
2023-12-05 20:13 ` Nathan Chancellor
2023-12-05 20:13 ` [PATCH 1/3] usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE with OF Nathan Chancellor
2023-12-05 20:13 ` Nathan Chancellor
2023-12-05 20:58 ` Guenter Roeck
2023-12-05 20:58 ` Guenter Roeck
2023-12-06 7:16 ` Dmitry Baryshkov
2023-12-06 7:16 ` Dmitry Baryshkov
2023-12-07 9:02 ` Heikki Krogerus [this message]
2023-12-07 9:02 ` Heikki Krogerus
2023-12-05 20:13 ` [PATCH 2/3] usb: typec: qcom-pmic-typec: Only select DRM_AUX_HPD_BRIDGE " Nathan Chancellor
2023-12-05 20:13 ` Nathan Chancellor
2023-12-05 20:58 ` Guenter Roeck
2023-12-05 20:58 ` Guenter Roeck
2023-12-05 22:03 ` Bryan O'Donoghue
2023-12-05 22:03 ` Bryan O'Donoghue
2023-12-07 9:11 ` Heikki Krogerus
2023-12-07 9:11 ` Heikki Krogerus
2023-12-05 20:13 ` [PATCH 3/3] drm/bridge: Return NULL instead of plain 0 in drm_dp_hpd_bridge_register() stub Nathan Chancellor
2023-12-05 20:13 ` Nathan Chancellor
2023-12-05 20:59 ` Guenter Roeck
2023-12-05 20:59 ` Guenter Roeck
2023-12-05 22:04 ` Bryan O'Donoghue
2023-12-05 22:04 ` Bryan O'Donoghue
2023-12-07 10:33 ` [PATCH 0/3] A few fixes for transparent bridge support Dmitry Baryshkov
2023-12-07 10:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXGKEXDAMM6yUup7@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nathan@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.