From: Daniel Golle <daniel@makrotopia.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Jianhui Zhao <zhaojh329@gmail.com>,
Chen-Yu Tsai <wenst@chromium.org>,
"Garmin.Chang" <Garmin.Chang@mediatek.com>,
Sam Shih <sam.shih@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
James Liao <jamesjj.liao@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: mediatek: add clock controllers of MT7988
Date: Thu, 7 Dec 2023 17:17:38 +0000 [thread overview]
Message-ID: <ZXH-Mq_DlW5Oodwt@makrotopia.org> (raw)
In-Reply-To: <64ee48fc-4f77-48cc-b235-c9fb2b10afc4@linaro.org>
On Thu, Dec 07, 2023 at 06:03:44PM +0100, Krzysztof Kozlowski wrote:
> On 06/12/2023 13:45, Daniel Golle wrote:
> >>> +properties:
> >>> + compatible:
> >>> + items:
> >>> + - const: mediatek,mt7988-ethwarp
> >>> + - const: syscon
> >>> + - const: simple-mfd
> >>
> >> No, this is not a mfd, I say.
> >>
> >> Prove me wrong! :-)
> >
> > https://github.com/dangowrt/linux/blob/mt7988-for-next/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L564
> >
> > The 'simple-mfd' compatible is required to have the Linux
> > kernel probe drivers for sub-nodes -- several drivers will act on
> > the different aspects of the circuit exposed at this memory range.
> > From what I understand, this is the definition of a MFD.
>
> We know what is MFD, so no need to teach us. We expect you to look at
> this. You do not have subnodes, so MFD is pointless. Showing DTSI means
> nothing except that you did not test your bindings.
Sorry, I simply wasn't aware that this is what I'm being asked for.
Is the device a MFD? - Yes it is.
In this case the child node would be a 'ti,syscon-reset' which doesn't
have YAML bindings. Should I include it as object without $ref or do I
need to convert ti,syscon-reset.txt to yaml first, and then reference
it as child node in the MFD?
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: James Liao <jamesjj.liao@mediatek.com>,
devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Eric Dumazet <edumazet@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-clk@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
Sabrina Dubroca <sd@queasysnail.net>,
Chen-Yu Tsai <wenst@chromium.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Garmin.Chang" <Garmin.Chang@mediatek.com>,
Conor Dooley <conor+dt@kernel.org>,
Sam Shih <sam.shih@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Jianhui Zhao <zhaojh329@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Stephen Boyd <sboyd@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: mediatek: add clock controllers of MT7988
Date: Thu, 7 Dec 2023 17:17:38 +0000 [thread overview]
Message-ID: <ZXH-Mq_DlW5Oodwt@makrotopia.org> (raw)
In-Reply-To: <64ee48fc-4f77-48cc-b235-c9fb2b10afc4@linaro.org>
On Thu, Dec 07, 2023 at 06:03:44PM +0100, Krzysztof Kozlowski wrote:
> On 06/12/2023 13:45, Daniel Golle wrote:
> >>> +properties:
> >>> + compatible:
> >>> + items:
> >>> + - const: mediatek,mt7988-ethwarp
> >>> + - const: syscon
> >>> + - const: simple-mfd
> >>
> >> No, this is not a mfd, I say.
> >>
> >> Prove me wrong! :-)
> >
> > https://github.com/dangowrt/linux/blob/mt7988-for-next/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L564
> >
> > The 'simple-mfd' compatible is required to have the Linux
> > kernel probe drivers for sub-nodes -- several drivers will act on
> > the different aspects of the circuit exposed at this memory range.
> > From what I understand, this is the definition of a MFD.
>
> We know what is MFD, so no need to teach us. We expect you to look at
> this. You do not have subnodes, so MFD is pointless. Showing DTSI means
> nothing except that you did not test your bindings.
Sorry, I simply wasn't aware that this is what I'm being asked for.
Is the device a MFD? - Yes it is.
In this case the child node would be a 'ti,syscon-reset' which doesn't
have YAML bindings. Should I include it as object without $ref or do I
need to convert ti,syscon-reset.txt to yaml first, and then reference
it as child node in the MFD?
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Jianhui Zhao <zhaojh329@gmail.com>,
Chen-Yu Tsai <wenst@chromium.org>,
"Garmin.Chang" <Garmin.Chang@mediatek.com>,
Sam Shih <sam.shih@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
James Liao <jamesjj.liao@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: mediatek: add clock controllers of MT7988
Date: Thu, 7 Dec 2023 17:17:38 +0000 [thread overview]
Message-ID: <ZXH-Mq_DlW5Oodwt@makrotopia.org> (raw)
In-Reply-To: <64ee48fc-4f77-48cc-b235-c9fb2b10afc4@linaro.org>
On Thu, Dec 07, 2023 at 06:03:44PM +0100, Krzysztof Kozlowski wrote:
> On 06/12/2023 13:45, Daniel Golle wrote:
> >>> +properties:
> >>> + compatible:
> >>> + items:
> >>> + - const: mediatek,mt7988-ethwarp
> >>> + - const: syscon
> >>> + - const: simple-mfd
> >>
> >> No, this is not a mfd, I say.
> >>
> >> Prove me wrong! :-)
> >
> > https://github.com/dangowrt/linux/blob/mt7988-for-next/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L564
> >
> > The 'simple-mfd' compatible is required to have the Linux
> > kernel probe drivers for sub-nodes -- several drivers will act on
> > the different aspects of the circuit exposed at this memory range.
> > From what I understand, this is the definition of a MFD.
>
> We know what is MFD, so no need to teach us. We expect you to look at
> this. You do not have subnodes, so MFD is pointless. Showing DTSI means
> nothing except that you did not test your bindings.
Sorry, I simply wasn't aware that this is what I'm being asked for.
Is the device a MFD? - Yes it is.
In this case the child node would be a 'ti,syscon-reset' which doesn't
have YAML bindings. Should I include it as object without $ref or do I
need to convert ti,syscon-reset.txt to yaml first, and then reference
it as child node in the MFD?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-07 17:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 0:55 [PATCH v3 1/4] dt-bindings: clock: mediatek: add MT7988 clock IDs Daniel Golle
2023-12-06 0:55 ` Daniel Golle
2023-12-06 0:57 ` [PATCH v3 2/4] dt-bindings: clock: mediatek: add clock controllers of MT7988 Daniel Golle
2023-12-06 0:57 ` Daniel Golle
2023-12-06 10:21 ` Krzysztof Kozlowski
2023-12-06 10:21 ` Krzysztof Kozlowski
2023-12-06 10:59 ` AngeloGioacchino Del Regno
2023-12-06 10:59 ` AngeloGioacchino Del Regno
2023-12-06 12:45 ` Daniel Golle
2023-12-06 12:45 ` Daniel Golle
2023-12-06 12:45 ` Daniel Golle
2023-12-07 17:03 ` Krzysztof Kozlowski
2023-12-07 17:03 ` Krzysztof Kozlowski
2023-12-07 17:03 ` Krzysztof Kozlowski
2023-12-07 17:17 ` Daniel Golle [this message]
2023-12-07 17:17 ` Daniel Golle
2023-12-07 17:17 ` Daniel Golle
2023-12-07 17:23 ` Krzysztof Kozlowski
2023-12-07 17:23 ` Krzysztof Kozlowski
2023-12-07 17:23 ` Krzysztof Kozlowski
2023-12-06 0:57 ` [PATCH v3 3/4] clk: mediatek: Add pcw_chg_shift control Daniel Golle
2023-12-06 0:57 ` Daniel Golle
2023-12-06 10:38 ` AngeloGioacchino Del Regno
2023-12-06 10:38 ` AngeloGioacchino Del Regno
2023-12-09 0:10 ` Daniel Golle
2023-12-09 0:10 ` Daniel Golle
2023-12-09 0:10 ` Daniel Golle
2023-12-06 0:57 ` [PATCH v3 4/4] clk: mediatek: add drivers for MT7988 SoC Daniel Golle
2023-12-06 0:57 ` Daniel Golle
2023-12-06 10:58 ` AngeloGioacchino Del Regno
2023-12-06 10:58 ` AngeloGioacchino Del Regno
2023-12-06 10:20 ` [PATCH v3 1/4] dt-bindings: clock: mediatek: add MT7988 clock IDs Krzysztof Kozlowski
2023-12-06 10:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXH-Mq_DlW5Oodwt@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Garmin.Chang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=jamesjj.liao@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sam.shih@mediatek.com \
--cc=sboyd@kernel.org \
--cc=sd@queasysnail.net \
--cc=wenst@chromium.org \
--cc=zhaojh329@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.