From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Pavel Machek" <pavel@ucw.cz>, "David Airlie" <airlied@gmail.com>,
linux-leds@vger.kernel.org,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Helge Deller" <deller@gmx.de>, "Lee Jones" <lee@kernel.org>,
"Javier Martinez Canillas" <javierm@redhat.com>,
linux-input@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Guenter Roeck" <linux@roeck-us.net>,
linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-pwm@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jani Nikula" <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
"Mark Gross" <markgross@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
"Support Opensource" <support.opensource@diasemi.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()
Date: Mon, 11 Dec 2023 08:30:10 +0000 [thread overview]
Message-ID: <ZXbIknpNVxb5Mh2B@gofer.mess.org> (raw)
In-Reply-To: <20231209135742.3ieusuq3h3xlvjfn@pengutronix.de>
On Sat, Dec 09, 2023 at 02:57:42PM +0100, Uwe Kleine-König wrote:
> On Wed, Nov 29, 2023 at 09:13:34AM +0000, Sean Young wrote:
> > In order to introduce a pwm api which can be used from atomic context,
> > we will need two functions for applying pwm changes:
> >
> > int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
> > int pwm_apply_atomic(struct pwm *, struct pwm_state *);
> >
> > This commit just deals with renaming pwm_apply_state(), a following
> > commit will introduce the pwm_apply_atomic() function.
> >
> > Acked-by: Hans de Goede <hdegoede@redhat.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Acked-by: Lee Jones <lee@kernel.org>
> > Signed-off-by: Sean Young <sean@mess.org>
>
> Not a in-detail-review, but I just noticed again, that we have
>
> K: pwm_(config|apply_state|ops)
>
> in MAINTAINERS. That one needs adaption, too.
Fixed in v7.
Thanks,
Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Support Opensource" <support.opensource@diasemi.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Jani Nikula" <jani.nikula@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()
Date: Mon, 11 Dec 2023 08:30:10 +0000 [thread overview]
Message-ID: <ZXbIknpNVxb5Mh2B@gofer.mess.org> (raw)
In-Reply-To: <20231209135742.3ieusuq3h3xlvjfn@pengutronix.de>
On Sat, Dec 09, 2023 at 02:57:42PM +0100, Uwe Kleine-König wrote:
> On Wed, Nov 29, 2023 at 09:13:34AM +0000, Sean Young wrote:
> > In order to introduce a pwm api which can be used from atomic context,
> > we will need two functions for applying pwm changes:
> >
> > int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
> > int pwm_apply_atomic(struct pwm *, struct pwm_state *);
> >
> > This commit just deals with renaming pwm_apply_state(), a following
> > commit will introduce the pwm_apply_atomic() function.
> >
> > Acked-by: Hans de Goede <hdegoede@redhat.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Acked-by: Lee Jones <lee@kernel.org>
> > Signed-off-by: Sean Young <sean@mess.org>
>
> Not a in-detail-review, but I just noticed again, that we have
>
> K: pwm_(config|apply_state|ops)
>
> in MAINTAINERS. That one needs adaption, too.
Fixed in v7.
Thanks,
Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Support Opensource" <support.opensource@diasemi.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Jani Nikula" <jani.nikula@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()
Date: Mon, 11 Dec 2023 08:30:10 +0000 [thread overview]
Message-ID: <ZXbIknpNVxb5Mh2B@gofer.mess.org> (raw)
In-Reply-To: <20231209135742.3ieusuq3h3xlvjfn@pengutronix.de>
On Sat, Dec 09, 2023 at 02:57:42PM +0100, Uwe Kleine-König wrote:
> On Wed, Nov 29, 2023 at 09:13:34AM +0000, Sean Young wrote:
> > In order to introduce a pwm api which can be used from atomic context,
> > we will need two functions for applying pwm changes:
> >
> > int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
> > int pwm_apply_atomic(struct pwm *, struct pwm_state *);
> >
> > This commit just deals with renaming pwm_apply_state(), a following
> > commit will introduce the pwm_apply_atomic() function.
> >
> > Acked-by: Hans de Goede <hdegoede@redhat.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Acked-by: Lee Jones <lee@kernel.org>
> > Signed-off-by: Sean Young <sean@mess.org>
>
> Not a in-detail-review, but I just noticed again, that we have
>
> K: pwm_(config|apply_state|ops)
>
> in MAINTAINERS. That one needs adaption, too.
Fixed in v7.
Thanks,
Sean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Helge Deller" <deller@gmx.de>, "Lee Jones" <lee@kernel.org>,
"Javier Martinez Canillas" <javierm@redhat.com>,
linux-input@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Guenter Roeck" <linux@roeck-us.net>,
linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-pwm@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>,
"Jani Nikula" <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
"Mark Gross" <markgross@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()
Date: Mon, 11 Dec 2023 08:30:10 +0000 [thread overview]
Message-ID: <ZXbIknpNVxb5Mh2B@gofer.mess.org> (raw)
In-Reply-To: <20231209135742.3ieusuq3h3xlvjfn@pengutronix.de>
On Sat, Dec 09, 2023 at 02:57:42PM +0100, Uwe Kleine-König wrote:
> On Wed, Nov 29, 2023 at 09:13:34AM +0000, Sean Young wrote:
> > In order to introduce a pwm api which can be used from atomic context,
> > we will need two functions for applying pwm changes:
> >
> > int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
> > int pwm_apply_atomic(struct pwm *, struct pwm_state *);
> >
> > This commit just deals with renaming pwm_apply_state(), a following
> > commit will introduce the pwm_apply_atomic() function.
> >
> > Acked-by: Hans de Goede <hdegoede@redhat.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Acked-by: Lee Jones <lee@kernel.org>
> > Signed-off-by: Sean Young <sean@mess.org>
>
> Not a in-detail-review, but I just noticed again, that we have
>
> K: pwm_(config|apply_state|ops)
>
> in MAINTAINERS. That one needs adaption, too.
Fixed in v7.
Thanks,
Sean
next prev parent reply other threads:[~2023-12-11 8:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 9:13 [PATCH v6 0/4] Improve pwm-ir-tx precision Sean Young
2023-11-29 9:13 ` [Intel-gfx] [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep() Sean Young
2023-11-29 9:13 ` Sean Young
2023-11-29 9:13 ` Sean Young
2023-11-29 9:13 ` Sean Young
2023-12-09 13:57 ` Uwe Kleine-König
2023-12-09 13:57 ` Uwe Kleine-König
2023-12-09 13:57 ` Uwe Kleine-König
2023-12-09 13:57 ` Uwe Kleine-König
2023-12-11 8:30 ` Sean Young [this message]
2023-12-11 8:30 ` Sean Young
2023-12-11 8:30 ` Sean Young
2023-12-11 8:30 ` Sean Young
2023-12-10 3:59 ` Dmitry Torokhov
2023-12-10 3:59 ` Dmitry Torokhov
2023-12-10 3:59 ` Dmitry Torokhov
2023-12-10 3:59 ` Dmitry Torokhov
2023-11-29 9:13 ` [PATCH v6 2/4] pwm: make it possible to apply pwm changes in atomic context Sean Young
2023-12-08 16:19 ` Thierry Reding
2023-12-09 9:49 ` Sean Young
2023-11-29 9:13 ` [PATCH v6 3/4] pwm: bcm2835: allow pwm driver to be used " Sean Young
2023-11-29 9:13 ` Sean Young
2023-11-29 17:47 ` Florian Fainelli
2023-11-29 17:47 ` Florian Fainelli
2023-12-08 16:22 ` Thierry Reding
2023-12-08 16:22 ` Thierry Reding
2023-12-08 17:01 ` Sean Young
2023-12-08 17:01 ` Sean Young
2023-12-08 17:20 ` Uwe Kleine-König
2023-12-08 17:20 ` Uwe Kleine-König
2023-12-09 9:11 ` Sean Young
2023-12-09 9:11 ` Sean Young
2023-12-11 14:17 ` Thierry Reding
2023-12-11 14:17 ` Thierry Reding
2023-11-29 9:13 ` [PATCH v6 4/4] media: pwm-ir-tx: trigger edges from hrtimer interrupt context Sean Young
2023-12-08 16:29 ` Thierry Reding
2023-12-09 9:52 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXbIknpNVxb5Mh2B@gofer.mess.org \
--to=sean@mess.org \
--cc=airlied@gmail.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jani.nikula@intel.com \
--cc=javierm@redhat.com \
--cc=jdelvare@suse.com \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=support.opensource@diasemi.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.