From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/3] acpi: fix FADT table
Date: Fri, 15 Dec 2023 19:43:41 +0200 [thread overview]
Message-ID: <ZXyQTYKzRm6BMsMe@smile.fi.intel.com> (raw)
In-Reply-To: <20231215164016.137794-2-heinrich.schuchardt@canonical.com>
On Fri, Dec 15, 2023 at 05:40:14PM +0100, Heinrich Schuchardt wrote:
> Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to
> to uintptr_t to fill these.
>
> If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If
> field X_DSDT is filled, field DSDT must be ignored. We should not fill
> unused fields.
Is it dictated by the specifications?
Please, put the reference here in the commit message (section X.Y.Z "Goo bar").
...
From code perspective LGTM.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-15 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 16:40 [PATCH 0/3] cmd: acpi: fix list_fadt() Heinrich Schuchardt
2023-12-15 16:40 ` [PATCH 1/3] acpi: fix FADT table Heinrich Schuchardt
2023-12-15 17:43 ` Andy Shevchenko [this message]
2023-12-15 17:48 ` Simon Glass
2023-12-15 19:04 ` Heinrich Schuchardt
2023-12-15 16:40 ` [PATCH 2/3] cmd: acpi: fix listing DSDT and FACS Heinrich Schuchardt
2023-12-15 16:40 ` [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list Heinrich Schuchardt
2023-12-15 17:46 ` Andy Shevchenko
2023-12-15 19:22 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXyQTYKzRm6BMsMe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.