From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list
Date: Fri, 15 Dec 2023 19:46:53 +0200 [thread overview]
Message-ID: <ZXyRDStdm4J__CIX@smile.fi.intel.com> (raw)
In-Reply-To: <20231215164016.137794-4-heinrich.schuchardt@canonical.com>
On Fri, Dec 15, 2023 at 05:40:16PM +0100, Heinrich Schuchardt wrote:
> On non x86 platforms the hardware reduce flag must be set in the FADT
> table. Write an error message if the flag is missing.
...
> + if (!IS_ENABLED(CONFIG_X86) &&
> + !(fadt->flags & ACPI_FADT_HW_REDUCED_ACPI))
> + log_err("FADT not ACPI hardware reduced compliant\n");
I guess it's half baked solution as this, HW reduced, flag adds more
limitations even on x86. If you want a good validation it should be done
in a separate function taking others aspects into account.
But since it doesn't affect my area of interest in U-Boot, I won't prevent
you from doing this way, it's up to the U-Boot maintainers how to proceed
with it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-15 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 16:40 [PATCH 0/3] cmd: acpi: fix list_fadt() Heinrich Schuchardt
2023-12-15 16:40 ` [PATCH 1/3] acpi: fix FADT table Heinrich Schuchardt
2023-12-15 17:43 ` Andy Shevchenko
2023-12-15 17:48 ` Simon Glass
2023-12-15 19:04 ` Heinrich Schuchardt
2023-12-15 16:40 ` [PATCH 2/3] cmd: acpi: fix listing DSDT and FACS Heinrich Schuchardt
2023-12-15 16:40 ` [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list Heinrich Schuchardt
2023-12-15 17:46 ` Andy Shevchenko [this message]
2023-12-15 19:22 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXyRDStdm4J__CIX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.