All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kubiak <michal.kubiak@intel.com>
To: Brett Creeley <bcreeley@amd.com>
Cc: maciej.fijalkowski@intel.com, emil.s.tantilov@intel.com,
	larysa.zaremba@intel.com, netdev@vger.kernel.org,
	joshua.a.hay@intel.com, aleksander.lobakin@intel.com,
	intel-wired-lan@lists.osuosl.org, alan.brady@intel.com,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR
Date: Fri, 15 Dec 2023 20:04:52 +0100	[thread overview]
Message-ID: <ZXyjVCdi03p29jcc@localhost.localdomain> (raw)
In-Reply-To: <9ea0484d-a2a4-308c-95fd-c9accdcdc424@amd.com>

On Fri, Dec 15, 2023 at 10:01:36AM -0800, Brett Creeley wrote:
> 

[...]

> 
> > 
> > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> > index df76493faa75..50761c2d9f3b 100644
> > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> > @@ -495,9 +495,11 @@ struct idpf_vec_regs {
> >   struct idpf_intr_reg {
> >          void __iomem *dyn_ctl;
> >          u32 dyn_ctl_intena_m;
> > +       u32 dyn_ctl_intena_msk_m;
> >          u32 dyn_ctl_itridx_s;
> >          u32 dyn_ctl_itridx_m;
> >          u32 dyn_ctl_intrvl_s;
> > +       u32 dyn_ctl_wb_on_itr_m;
> >          void __iomem *rx_itr;
> >          void __iomem *tx_itr;
> >          void __iomem *icr_ena;
> > @@ -534,6 +536,7 @@ struct idpf_q_vector {
> >          struct napi_struct napi;
> >          u16 v_idx;
> >          struct idpf_intr_reg intr_reg;
> > +       bool wb_on_itr;
> 
> Not sure if this was considered, but it might be best to put this before
> intr_reg so it's on the same cacheline as intr_reg.
> 

Good point! It wasn't considered before.
I have just confirmed with pahole that it is worth putting that flag
before the register structure in terms of cacheline.

Thank you for your suggestion. I will reorder this.

Thanks,
Michal
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Michal Kubiak <michal.kubiak@intel.com>
To: Brett Creeley <bcreeley@amd.com>
Cc: <intel-wired-lan@lists.osuosl.org>,
	<aleksander.lobakin@intel.com>, <larysa.zaremba@intel.com>,
	<alan.brady@intel.com>, <joshua.a.hay@intel.com>,
	<emil.s.tantilov@intel.com>, <maciej.fijalkowski@intel.com>,
	<netdev@vger.kernel.org>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-net] idpf: enable WB_ON_ITR
Date: Fri, 15 Dec 2023 20:04:52 +0100	[thread overview]
Message-ID: <ZXyjVCdi03p29jcc@localhost.localdomain> (raw)
In-Reply-To: <9ea0484d-a2a4-308c-95fd-c9accdcdc424@amd.com>

On Fri, Dec 15, 2023 at 10:01:36AM -0800, Brett Creeley wrote:
> 

[...]

> 
> > 
> > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> > index df76493faa75..50761c2d9f3b 100644
> > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> > @@ -495,9 +495,11 @@ struct idpf_vec_regs {
> >   struct idpf_intr_reg {
> >          void __iomem *dyn_ctl;
> >          u32 dyn_ctl_intena_m;
> > +       u32 dyn_ctl_intena_msk_m;
> >          u32 dyn_ctl_itridx_s;
> >          u32 dyn_ctl_itridx_m;
> >          u32 dyn_ctl_intrvl_s;
> > +       u32 dyn_ctl_wb_on_itr_m;
> >          void __iomem *rx_itr;
> >          void __iomem *tx_itr;
> >          void __iomem *icr_ena;
> > @@ -534,6 +536,7 @@ struct idpf_q_vector {
> >          struct napi_struct napi;
> >          u16 v_idx;
> >          struct idpf_intr_reg intr_reg;
> > +       bool wb_on_itr;
> 
> Not sure if this was considered, but it might be best to put this before
> intr_reg so it's on the same cacheline as intr_reg.
> 

Good point! It wasn't considered before.
I have just confirmed with pahole that it is worth putting that flag
before the register structure in terms of cacheline.

Thank you for your suggestion. I will reorder this.

Thanks,
Michal

  reply	other threads:[~2023-12-15 19:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 14:55 [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR Michal Kubiak
2023-12-12 14:55 ` Michal Kubiak
2023-12-12 16:50 ` [Intel-wired-lan] " Paul Menzel
2023-12-12 16:50   ` Paul Menzel
2023-12-13 13:23   ` Michal Kubiak
2023-12-13 13:23     ` Michal Kubiak
2023-12-13 13:51     ` Michal Kubiak
2023-12-13 13:51       ` Michal Kubiak
2023-12-13 22:22       ` Nguyen, Anthony L
2023-12-13 22:22         ` Nguyen, Anthony L
2023-12-13 23:06         ` Tony Nguyen
2023-12-13 23:06           ` Tony Nguyen
2023-12-15 17:27           ` Michal Kubiak
2023-12-15 17:27             ` Michal Kubiak
2023-12-14 12:59     ` Paul Menzel
2023-12-14 12:59       ` Paul Menzel
2023-12-15 17:32       ` Michal Kubiak
2023-12-15 17:32         ` Michal Kubiak
2023-12-15 18:01 ` Brett Creeley
2023-12-15 18:01   ` Brett Creeley
2023-12-15 19:04   ` Michal Kubiak [this message]
2023-12-15 19:04     ` Michal Kubiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXyjVCdi03p29jcc@localhost.localdomain \
    --to=michal.kubiak@intel.com \
    --cc=alan.brady@intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=bcreeley@amd.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=joshua.a.hay@intel.com \
    --cc=larysa.zaremba@intel.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.