Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Baoquan He <bhe@redhat.com>
To: Conor Dooley <conor@kernel.org>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	linux-parisc@vger.kernel.org, joe@perches.com, nathan@kernel.org
Subject: Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
Date: Wed, 20 Dec 2023 12:22:29 +0800	[thread overview]
Message-ID: <ZYJsBW0Y7Y+XhSgf@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231219-twitch-many-ca8877857182@spud>

On 12/19/23 at 02:44pm, Conor Dooley wrote:
> On Wed, Dec 13, 2023 at 01:57:45PM +0800, Baoquan He wrote:
> > Then when specifying '-d' for kexec_file_load interface, loaded
> > locations of kernel/initrd/cmdline etc can be printed out to help debug.
> > 
> > Here replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> > loading related codes.
> > 
> > And also replace pr_notice() with kexec_dprintk() in elf_kexec_load()
> > because loaded location of purgatory and device tree are only printed
> > out for debugging, it doesn't make sense to always print them out.
> > 
> > And also remove kexec_image_info() because the content has been printed
> > out in generic code.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> I'm sorry - I meant to look at this several days ago but I forgot.
> Apart from the typo that crept back into $subject, this version explains
> the rationale behind what you're changing a lot better, thanks.

Thanks for careful checking. I forgot the typo fixing you have pointed
out in v3 reviewing.

Hi Andrew,

Could you help fix the typo in subject?

[PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
                           ~~~ s/ricv/riscv/


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)

From: Baoquan He <bhe@redhat.com>
To: Conor Dooley <conor@kernel.org>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	linux-parisc@vger.kernel.org, joe@perches.com, nathan@kernel.org
Subject: Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
Date: Wed, 20 Dec 2023 12:22:29 +0800	[thread overview]
Message-ID: <ZYJsBW0Y7Y+XhSgf@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231219-twitch-many-ca8877857182@spud>

On 12/19/23 at 02:44pm, Conor Dooley wrote:
> On Wed, Dec 13, 2023 at 01:57:45PM +0800, Baoquan He wrote:
> > Then when specifying '-d' for kexec_file_load interface, loaded
> > locations of kernel/initrd/cmdline etc can be printed out to help debug.
> > 
> > Here replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> > loading related codes.
> > 
> > And also replace pr_notice() with kexec_dprintk() in elf_kexec_load()
> > because loaded location of purgatory and device tree are only printed
> > out for debugging, it doesn't make sense to always print them out.
> > 
> > And also remove kexec_image_info() because the content has been printed
> > out in generic code.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> I'm sorry - I meant to look at this several days ago but I forgot.
> Apart from the typo that crept back into $subject, this version explains
> the rationale behind what you're changing a lot better, thanks.

Thanks for careful checking. I forgot the typo fixing you have pointed
out in v3 reviewing.

Hi Andrew,

Could you help fix the typo in subject?

[PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
                           ~~~ s/ricv/riscv/

WARNING: multiple messages have this Message-ID (diff)

From: Baoquan He <bhe@redhat.com>
To: Conor Dooley <conor@kernel.org>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	linux-parisc@vger.kernel.org, joe@perches.com, nathan@kernel.org
Subject: Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
Date: Wed, 20 Dec 2023 12:22:29 +0800	[thread overview]
Message-ID: <ZYJsBW0Y7Y+XhSgf@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231219-twitch-many-ca8877857182@spud>

On 12/19/23 at 02:44pm, Conor Dooley wrote:
> On Wed, Dec 13, 2023 at 01:57:45PM +0800, Baoquan He wrote:
> > Then when specifying '-d' for kexec_file_load interface, loaded
> > locations of kernel/initrd/cmdline etc can be printed out to help debug.
> > 
> > Here replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> > loading related codes.
> > 
> > And also replace pr_notice() with kexec_dprintk() in elf_kexec_load()
> > because loaded location of purgatory and device tree are only printed
> > out for debugging, it doesn't make sense to always print them out.
> > 
> > And also remove kexec_image_info() because the content has been printed
> > out in generic code.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> I'm sorry - I meant to look at this several days ago but I forgot.
> Apart from the typo that crept back into $subject, this version explains
> the rationale behind what you're changing a lot better, thanks.

Thanks for careful checking. I forgot the typo fixing you have pointed
out in v3 reviewing.

Hi Andrew,

Could you help fix the typo in subject?

[PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
                           ~~~ s/ricv/riscv/


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)

From: Baoquan He <bhe@redhat.com>
To: Conor Dooley <conor@kernel.org>, akpm@linux-foundation.org
Cc: linux-parisc@vger.kernel.org, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	nathan@kernel.org, joe@perches.com,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
Date: Wed, 20 Dec 2023 12:22:29 +0800	[thread overview]
Message-ID: <ZYJsBW0Y7Y+XhSgf@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231219-twitch-many-ca8877857182@spud>

On 12/19/23 at 02:44pm, Conor Dooley wrote:
> On Wed, Dec 13, 2023 at 01:57:45PM +0800, Baoquan He wrote:
> > Then when specifying '-d' for kexec_file_load interface, loaded
> > locations of kernel/initrd/cmdline etc can be printed out to help debug.
> > 
> > Here replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> > loading related codes.
> > 
> > And also replace pr_notice() with kexec_dprintk() in elf_kexec_load()
> > because loaded location of purgatory and device tree are only printed
> > out for debugging, it doesn't make sense to always print them out.
> > 
> > And also remove kexec_image_info() because the content has been printed
> > out in generic code.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> I'm sorry - I meant to look at this several days ago but I forgot.
> Apart from the typo that crept back into $subject, this version explains
> the rationale behind what you're changing a lot better, thanks.

Thanks for careful checking. I forgot the typo fixing you have pointed
out in v3 reviewing.

Hi Andrew,

Could you help fix the typo in subject?

[PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
                           ~~~ s/ricv/riscv/

WARNING: multiple messages have this Message-ID (diff)

From: Baoquan He <bhe@redhat.com>
To: Conor Dooley <conor@kernel.org>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	linux-parisc@vger.kernel.org, joe@perches.com, nathan@kernel.org
Subject: Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
Date: Wed, 20 Dec 2023 12:22:29 +0800	[thread overview]
Message-ID: <ZYJsBW0Y7Y+XhSgf@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231219-twitch-many-ca8877857182@spud>

On 12/19/23 at 02:44pm, Conor Dooley wrote:
> On Wed, Dec 13, 2023 at 01:57:45PM +0800, Baoquan He wrote:
> > Then when specifying '-d' for kexec_file_load interface, loaded
> > locations of kernel/initrd/cmdline etc can be printed out to help debug.
> > 
> > Here replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> > loading related codes.
> > 
> > And also replace pr_notice() with kexec_dprintk() in elf_kexec_load()
> > because loaded location of purgatory and device tree are only printed
> > out for debugging, it doesn't make sense to always print them out.
> > 
> > And also remove kexec_image_info() because the content has been printed
> > out in generic code.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> I'm sorry - I meant to look at this several days ago but I forgot.
> Apart from the typo that crept back into $subject, this version explains
> the rationale behind what you're changing a lot better, thanks.

Thanks for careful checking. I forgot the typo fixing you have pointed
out in v3 reviewing.

Hi Andrew,

Could you help fix the typo in subject?

[PATCH v4 5/7] kexec_file, ricv: print out debugging message if required
                           ~~~ s/ricv/riscv/


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2023-12-20  4:22 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13  5:57 [PATCH v4 0/7] kexec_file: print out debugging message if required Baoquan He
2023-12-13  5:57 ` Baoquan He
2023-12-13  5:57 ` Baoquan He
2023-12-13  5:57 ` Baoquan He
2023-12-13  5:57 ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 1/7] kexec_file: add kexec_file flag to control debug printing Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2024-03-12  9:58   ` kexec verbose dumps with 6.8 [was: [PATCH v4 1/7] kexec_file: add kexec_file flag to control debug printing] Jiri Slaby
2024-03-12  9:58     ` Jiri Slaby
2024-03-12  9:58     ` Jiri Slaby
2024-03-12  9:58     ` Jiri Slaby
2024-03-12  9:58     ` Jiri Slaby
2024-03-13  0:48     ` Baoquan He
2024-03-13  0:48       ` Baoquan He
2024-03-13  0:48       ` Baoquan He
2024-03-13  0:48       ` Baoquan He
2024-03-13  0:48       ` Baoquan He
2024-03-13  5:58       ` Jiri Slaby
2024-03-13  5:58         ` Jiri Slaby
2024-03-13  5:58         ` Jiri Slaby
2024-03-13  5:58         ` Jiri Slaby
2024-03-13  5:58         ` Jiri Slaby
2024-03-13  7:10         ` Baoquan He
2024-03-13  7:10           ` Baoquan He
2024-03-13  7:10           ` Baoquan He
2024-03-13  7:10           ` Baoquan He
2024-03-13  7:10           ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 2/7] kexec_file: print out debugging message if required Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 3/7] kexec_file, x86: " Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 4/7] kexec_file, arm64: " Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 5/7] kexec_file, ricv: " Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-19 14:44   ` Conor Dooley
2023-12-19 14:44     ` Conor Dooley
2023-12-19 14:44     ` Conor Dooley
2023-12-19 14:44     ` Conor Dooley
2023-12-19 14:44     ` Conor Dooley
2023-12-20  4:22     ` Baoquan He [this message]
2023-12-20  4:22       ` Baoquan He
2023-12-20  4:22       ` Baoquan He
2023-12-20  4:22       ` Baoquan He
2023-12-20  4:22       ` Baoquan He
2023-12-20 15:46       ` Andrew Morton
2023-12-20 15:46         ` Andrew Morton
2023-12-20 15:46         ` Andrew Morton
2023-12-20 15:46         ` Andrew Morton
2023-12-20 15:46         ` Andrew Morton
2023-12-20 23:30         ` Baoquan He
2023-12-20 23:30           ` Baoquan He
2023-12-20 23:30           ` Baoquan He
2023-12-20 23:30           ` Baoquan He
2023-12-20 23:30           ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 6/7] kexec_file, power: " Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57 ` [PATCH v4 7/7] kexec_file, parisc: " Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2023-12-13  5:57   ` Baoquan He
2024-01-20 21:09 ` [PATCH v4 0/7] kexec_file: " patchwork-bot+linux-riscv
2024-01-20 21:09   ` patchwork-bot+linux-riscv
2024-01-20 21:09   ` patchwork-bot+linux-riscv
2024-01-20 21:09   ` patchwork-bot+linux-riscv
2024-01-20 21:09   ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYJsBW0Y7Y+XhSgf@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=conor@kernel.org \
    --cc=joe@perches.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nathan@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.