* [PATCH] Input: da9063_onkey - avoid explicitly setting input's parent
@ 2023-12-21 3:09 Dmitry Torokhov
2024-01-04 19:09 ` Biju Das
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2023-12-21 3:09 UTC (permalink / raw)
To: Support Opensource, Biju Das; +Cc: linux-input, linux-kernel
devm_input_allocate_device() already sets parent of the new input
device, there's no need to set it up explicitly.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/da9063_onkey.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index ce499c28a7b2..c338765e0ecd 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -211,7 +211,6 @@ static int da9063_onkey_probe(struct platform_device *pdev)
snprintf(onkey->phys, sizeof(onkey->phys), "%s/input0",
onkey->config->name);
onkey->input->phys = onkey->phys;
- onkey->input->dev.parent = &pdev->dev;
input_set_capability(onkey->input, EV_KEY, KEY_POWER);
--
2.43.0.195.gebba966016-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] Input: da9063_onkey - avoid explicitly setting input's parent
2023-12-21 3:09 [PATCH] Input: da9063_onkey - avoid explicitly setting input's parent Dmitry Torokhov
@ 2024-01-04 19:09 ` Biju Das
0 siblings, 0 replies; 2+ messages in thread
From: Biju Das @ 2024-01-04 19:09 UTC (permalink / raw)
To: Dmitry Torokhov, Support Opensource
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Dmitry Torokhov,
Thanks for the patch.
> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Thursday, December 21, 2023 3:10 AM
> To: Support Opensource <support.opensource@diasemi.com>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Input: da9063_onkey - avoid explicitly setting input's
> parent
>
> devm_input_allocate_device() already sets parent of the new input device,
> there's no need to set it up explicitly.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Cheers,
Biju
> ---
> drivers/input/misc/da9063_onkey.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/da9063_onkey.c
> b/drivers/input/misc/da9063_onkey.c
> index ce499c28a7b2..c338765e0ecd 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -211,7 +211,6 @@ static int da9063_onkey_probe(struct platform_device
> *pdev)
> snprintf(onkey->phys, sizeof(onkey->phys), "%s/input0",
> onkey->config->name);
> onkey->input->phys = onkey->phys;
> - onkey->input->dev.parent = &pdev->dev;
>
> input_set_capability(onkey->input, EV_KEY, KEY_POWER);
>
> --
> 2.43.0.195.gebba966016-goog
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-04 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 3:09 [PATCH] Input: da9063_onkey - avoid explicitly setting input's parent Dmitry Torokhov
2024-01-04 19:09 ` Biju Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.