* [PATCH] perf vendor events: Remove UTF-8 characters from cmn.json
@ 2023-12-21 6:03 ` Jing Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jing Zhang @ 2023-12-21 6:03 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ian Rogers, kajoljain, Heiko Carstens, Thomas Richter,
Adrian Hunter, Linux Kernel Mailing List, Jiri Olsa, Namhyung Kim,
Sukadev Bhattiprolu, linuxppc-dev
cmn.json contains UTF-8 characters in brief description which
could break the perf build on some distros.
Fix this issue by removing the UTF-8 characters from cmn.json.
without the fix:
$find tools/perf/pmu-events/ -name "*.json" | xargs file -i | grep -v us-ascii
tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: application/json; charset=utf-8
with the fix:
$file -i tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: text/plain; charset=us-ascii
Fixes: 0b4de7bdf46c5215 ("perf jevents: Add support for Arm CMN PMU aliasing")
Reported-by: Arnaldo Carvalho de Melo <acme@kernel.com>
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
---
tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
index 428605c..5ec157c 100644
--- a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
+++ b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
@@ -107,7 +107,7 @@
"EventName": "hnf_qos_hh_retry",
"EventidCode": "0xe",
"NodeType": "0x5",
- "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN‑F.",
+ "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN-F.",
"Unit": "arm_cmn",
"Compat": "(434|436|43c|43a).*"
},
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] perf vendor events: Remove UTF-8 characters from cmn.json
@ 2023-12-21 6:03 ` Jing Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jing Zhang @ 2023-12-21 6:03 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: kajoljain, Sukadev Bhattiprolu, Ian Rogers, Heiko Carstens,
Thomas Richter, Adrian Hunter, Linux Kernel Mailing List,
Jiri Olsa, Namhyung Kim, linuxppc-dev
cmn.json contains UTF-8 characters in brief description which
could break the perf build on some distros.
Fix this issue by removing the UTF-8 characters from cmn.json.
without the fix:
$find tools/perf/pmu-events/ -name "*.json" | xargs file -i | grep -v us-ascii
tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: application/json; charset=utf-8
with the fix:
$file -i tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: text/plain; charset=us-ascii
Fixes: 0b4de7bdf46c5215 ("perf jevents: Add support for Arm CMN PMU aliasing")
Reported-by: Arnaldo Carvalho de Melo <acme@kernel.com>
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
---
tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
index 428605c..5ec157c 100644
--- a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
+++ b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
@@ -107,7 +107,7 @@
"EventName": "hnf_qos_hh_retry",
"EventidCode": "0xe",
"NodeType": "0x5",
- "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN‑F.",
+ "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN-F.",
"Unit": "arm_cmn",
"Compat": "(434|436|43c|43a).*"
},
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf vendor events: Remove UTF-8 characters from cmn.json
2023-12-21 6:03 ` Jing Zhang
@ 2023-12-21 15:55 ` Arnaldo Carvalho de Melo
-1 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-12-21 15:55 UTC (permalink / raw)
To: Jing Zhang
Cc: Ian Rogers, kajoljain, Heiko Carstens, Thomas Richter,
Adrian Hunter, Linux Kernel Mailing List, Jiri Olsa, Namhyung Kim,
Sukadev Bhattiprolu, linuxppc-dev
Em Thu, Dec 21, 2023 at 02:03:13PM +0800, Jing Zhang escreveu:
> cmn.json contains UTF-8 characters in brief description which
> could break the perf build on some distros.
>
> Fix this issue by removing the UTF-8 characters from cmn.json.
>
> without the fix:
> $find tools/perf/pmu-events/ -name "*.json" | xargs file -i | grep -v us-ascii
> tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: application/json; charset=utf-8
>
> with the fix:
> $file -i tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: text/plain; charset=us-ascii
Thanks, applied!
- Arnaldo
> Fixes: 0b4de7bdf46c5215 ("perf jevents: Add support for Arm CMN PMU aliasing")
> Reported-by: Arnaldo Carvalho de Melo <acme@kernel.com>
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> ---
> tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> index 428605c..5ec157c 100644
> --- a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> +++ b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> @@ -107,7 +107,7 @@
> "EventName": "hnf_qos_hh_retry",
> "EventidCode": "0xe",
> "NodeType": "0x5",
> - "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN‑F.",
> + "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN-F.",
> "Unit": "arm_cmn",
> "Compat": "(434|436|43c|43a).*"
> },
> --
> 1.8.3.1
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf vendor events: Remove UTF-8 characters from cmn.json
@ 2023-12-21 15:55 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-12-21 15:55 UTC (permalink / raw)
To: Jing Zhang
Cc: kajoljain, Sukadev Bhattiprolu, Ian Rogers, Heiko Carstens,
Thomas Richter, Adrian Hunter, Linux Kernel Mailing List,
Jiri Olsa, Namhyung Kim, linuxppc-dev
Em Thu, Dec 21, 2023 at 02:03:13PM +0800, Jing Zhang escreveu:
> cmn.json contains UTF-8 characters in brief description which
> could break the perf build on some distros.
>
> Fix this issue by removing the UTF-8 characters from cmn.json.
>
> without the fix:
> $find tools/perf/pmu-events/ -name "*.json" | xargs file -i | grep -v us-ascii
> tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: application/json; charset=utf-8
>
> with the fix:
> $file -i tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: text/plain; charset=us-ascii
Thanks, applied!
- Arnaldo
> Fixes: 0b4de7bdf46c5215 ("perf jevents: Add support for Arm CMN PMU aliasing")
> Reported-by: Arnaldo Carvalho de Melo <acme@kernel.com>
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> ---
> tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> index 428605c..5ec157c 100644
> --- a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> +++ b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json
> @@ -107,7 +107,7 @@
> "EventName": "hnf_qos_hh_retry",
> "EventidCode": "0xe",
> "NodeType": "0x5",
> - "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN‑F.",
> + "BriefDescription": "Counts number of times a HighHigh priority request is protocolretried at the HN-F.",
> "Unit": "arm_cmn",
> "Compat": "(434|436|43c|43a).*"
> },
> --
> 1.8.3.1
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 15:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 6:03 [PATCH] perf vendor events: Remove UTF-8 characters from cmn.json Jing Zhang
2023-12-21 6:03 ` Jing Zhang
2023-12-21 15:55 ` Arnaldo Carvalho de Melo
2023-12-21 15:55 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.