[PATCH v1 1/1] pvpanic: Don't use "proxy" headers

[PATCH v1 1/1] pvpanic: Don't use "proxy" headers

[Andy Shevchenko]

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/misc/pvpanic/pvpanic-mmio.c |  7 +++----
 drivers/misc/pvpanic/pvpanic-pci.c  |  5 +----
 drivers/misc/pvpanic/pvpanic.c      | 12 ++++++++----
 drivers/misc/pvpanic/pvpanic.h      |  5 +++++
 4 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c b/drivers/misc/pvpanic/pvpanic-mmio.c
index 9715798acce3..f3f2113a54a7 100644
--- a/drivers/misc/pvpanic/pvpanic-mmio.c
+++ b/drivers/misc/pvpanic/pvpanic-mmio.c
@@ -7,16 +7,15 @@
  *  Copyright (C) 2021 Oracle.
  */
 
+#include <linux/device.h>
+#include <linux/err.h>
 #include <linux/io.h>
-#include <linux/kernel.h>
+#include <linux/ioport.h>
 #include <linux/kexec.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/types.h>
-#include <linux/slab.h>
-
-#include <uapi/misc/pvpanic.h>
 
 #include "pvpanic.h"
 
diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
index c5fb6298cb8d..9ad20e82785b 100644
--- a/drivers/misc/pvpanic/pvpanic-pci.c
+++ b/drivers/misc/pvpanic/pvpanic-pci.c
@@ -5,13 +5,10 @@
  *  Copyright (C) 2021 Oracle.
  */
 
-#include <linux/kernel.h>
+#include <linux/errno.h>
 #include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/types.h>
-#include <linux/slab.h>
-
-#include <uapi/misc/pvpanic.h>
 
 #include "pvpanic.h"
 
diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
index 305b367e0ce3..df3457ce1cb1 100644
--- a/drivers/misc/pvpanic/pvpanic.c
+++ b/drivers/misc/pvpanic/pvpanic.c
@@ -8,16 +8,20 @@
  */
 
 #include <linux/device.h>
+#include <linux/errno.h>
+#include <linux/gfp_types.h>
 #include <linux/io.h>
-#include <linux/kernel.h>
 #include <linux/kexec.h>
+#include <linux/kstrtox.h>
+#include <linux/limits.h>
+#include <linux/list.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
-#include <linux/platform_device.h>
 #include <linux/panic_notifier.h>
+#include <linux/platform_device.h>
+#include <linux/spinlock.h>
+#include <linux/sysfs.h>
 #include <linux/types.h>
-#include <linux/cdev.h>
-#include <linux/list.h>
 
 #include <uapi/misc/pvpanic.h>
 
diff --git a/drivers/misc/pvpanic/pvpanic.h b/drivers/misc/pvpanic/pvpanic.h
index 46ffb10438ad..a42fa760eed5 100644
--- a/drivers/misc/pvpanic/pvpanic.h
+++ b/drivers/misc/pvpanic/pvpanic.h
@@ -8,6 +8,11 @@
 #ifndef PVPANIC_H_
 #define PVPANIC_H_
 
+#include <linux/compiler_types.h>
+
+struct attribute_group;
+struct device;
+
 int devm_pvpanic_probe(struct device *dev, void __iomem *base);
 extern const struct attribute_group *pvpanic_dev_groups[];
 
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/1] pvpanic: Don't use "proxy" headers

[Thomas Weißschuh]

Dec 21, 2023 15:44:55 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

Note:
This also drops the unused include of the UAPI header
which could be mentioned in the changelog.

> ---
> drivers/misc/pvpanic/pvpanic-mmio.c |  7 +++----
> drivers/misc/pvpanic/pvpanic-pci.c  |  5 +----
> drivers/misc/pvpanic/pvpanic.c      | 12 ++++++++----
> drivers/misc/pvpanic/pvpanic.h      |  5 +++++
> 4 files changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c b/drivers/misc/pvpanic/pvpanic-mmio.c
> index 9715798acce3..f3f2113a54a7 100644
> --- a/drivers/misc/pvpanic/pvpanic-mmio.c
> +++ b/drivers/misc/pvpanic/pvpanic-mmio.c
> @@ -7,16 +7,15 @@
>   *  Copyright (C) 2021 Oracle.
>   */
>
> +#include <linux/device.h>
> +#include <linux/err.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> +#include <linux/ioport.h>
> #include <linux/kexec.h>
> #include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/types.h>
> -#include <linux/slab.h>
> -
> -#include <uapi/misc/pvpanic.h>
>
> #include "pvpanic.h"
>
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index c5fb6298cb8d..9ad20e82785b 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -5,13 +5,10 @@
>   *  Copyright (C) 2021 Oracle.
>   */
>
> -#include <linux/kernel.h>
> +#include <linux/errno.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> #include <linux/types.h>
> -#include <linux/slab.h>
> -
> -#include <uapi/misc/pvpanic.h>
>
> #include "pvpanic.h"
>
> diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
> index 305b367e0ce3..df3457ce1cb1 100644
> --- a/drivers/misc/pvpanic/pvpanic.c
> +++ b/drivers/misc/pvpanic/pvpanic.c
> @@ -8,16 +8,20 @@
>   */
>
> #include <linux/device.h>
> +#include <linux/errno.h>
> +#include <linux/gfp_types.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/kexec.h>
> +#include <linux/kstrtox.h>
> +#include <linux/limits.h>
> +#include <linux/list.h>
> #include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/platform_device.h>
> #include <linux/panic_notifier.h>
> +#include <linux/platform_device.h>
> +#include <linux/spinlock.h>
> +#include <linux/sysfs.h>
> #include <linux/types.h>
> -#include <linux/cdev.h>
> -#include <linux/list.h>
>
> #include <uapi/misc/pvpanic.h>
>
> diff --git a/drivers/misc/pvpanic/pvpanic.h b/drivers/misc/pvpanic/pvpanic.h
> index 46ffb10438ad..a42fa760eed5 100644
> --- a/drivers/misc/pvpanic/pvpanic.h
> +++ b/drivers/misc/pvpanic/pvpanic.h
> @@ -8,6 +8,11 @@
> #ifndef PVPANIC_H_
> #define PVPANIC_H_
>
> +#include <linux/compiler_types.h>
> +
> +struct attribute_group;
> +struct device;
> +
> int devm_pvpanic_probe(struct device *dev, void __iomem *base);
> extern const struct attribute_group *pvpanic_dev_groups[];
>
> --
> 2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/1] pvpanic: Don't use "proxy" headers

[Andy Shevchenko]

On Thu, Dec 21, 2023 at 06:48:49PM +0100, Thomas Weißschuh  wrote:
> Dec 21, 2023 15:44:55 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> 
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

Thank you!

> Note:
> This also drops the unused include of the UAPI header
> which could be mentioned in the changelog.

Isn't it implied?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] pvpanic: Don't use "proxy" headers

[Thomas Weißschuh]

On 2023-12-21 20:28:44+0200, Andy Shevchenko wrote:
> On Thu, Dec 21, 2023 at 06:48:49PM +0100, Thomas Weißschuh  wrote:
> > Dec 21, 2023 15:44:55 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> > 
> > > Update header inclusions to follow IWYU (Include What You Use)
> > > principle.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
> 
> Thank you!
> 
> > Note:
> > This also drops the unused include of the UAPI header
> > which could be mentioned in the changelog.
> 
> Isn't it implied?

It's not covered by the subject. The message itself is fine.
But it's only a tiny nitpick anyways.

Re: [PATCH v1 1/1] pvpanic: Don't use "proxy" headers

[Andy Shevchenko]

On Fri, Dec 22, 2023 at 12:08:51AM +0100, Thomas Weißschuh wrote:
> On 2023-12-21 20:28:44+0200, Andy Shevchenko wrote:
> > On Thu, Dec 21, 2023 at 06:48:49PM +0100, Thomas Weißschuh  wrote:
> > > Dec 21, 2023 15:44:55 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

...

> > > Note:
> > > This also drops the unused include of the UAPI header
> > > which could be mentioned in the changelog.
> > 
> > Isn't it implied?
> 
> It's not covered by the subject. The message itself is fine.

Ah, I thought you are talking about the body of the message.

> But it's only a tiny nitpick anyways.

Yes, I don't think we need a new iteration due to this.

Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko