All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonardo Bras <leobras@redhat.com>
To: Guo Ren <guoren@kernel.org>
Cc: Leonardo Bras <leobras@redhat.com>,
	linux-kernel@vger.kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, alexghiti@rivosinc.com, charlie@rivosinc.com,
	xiao.w.wang@intel.com, david@redhat.com,
	panqinglin2020@iscas.ac.cn, rick.p.edgecombe@intel.com,
	willy@infradead.org, bjorn@rivosinc.com,
	conor.dooley@microchip.com, cleger@rivosinc.com,
	linux-riscv@lists.infradead.org,
	Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V2 3/4] riscv: mm: Remove unused TASK_SIZE_MIN
Date: Fri, 22 Dec 2023 04:22:10 -0300	[thread overview]
Message-ID: <ZYU5InA7WcpGKaRF@LeoBras> (raw)
In-Reply-To: <CAJF2gTQSZSWJ7qZQckuALHkcJb8kEGTnb8wJQ9H2wgODkN56Lw@mail.gmail.com>

On Fri, Dec 22, 2023 at 03:16:45PM +0800, Guo Ren wrote:
> On Fri, Dec 22, 2023 at 12:49 PM Leonardo Bras <leobras@redhat.com> wrote:
> >
> > On Thu, Dec 21, 2023 at 10:47:00AM -0500, guoren@kernel.org wrote:
> > > From: Guo Ren <guoren@linux.alibaba.com>
> > >
> > > Remove TASK_SIZE_MIN because it's not used anymore.
> > >
> > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > > Signed-off-by: Guo Ren <guoren@kernel.org>
> > > ---
> > >  arch/riscv/include/asm/pgtable.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> > > index 74ffb2178f54..e415582276ec 100644
> > > --- a/arch/riscv/include/asm/pgtable.h
> > > +++ b/arch/riscv/include/asm/pgtable.h
> > > @@ -878,7 +878,6 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)
> > >   */
> > >  #ifdef CONFIG_64BIT
> > >  #define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2)
> > > -#define TASK_SIZE_MIN        (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> > >
> > >  #ifdef CONFIG_COMPAT
> > >  #define TASK_SIZE_32 (_AC(0x80000000, UL))
> > > @@ -890,7 +889,6 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)
> > >
> > >  #else
> > >  #define TASK_SIZE    FIXADDR_START
> > > -#define TASK_SIZE_MIN        TASK_SIZE
> > >  #endif
> > >
> > >  #else /* CONFIG_MMU */
> > > --
> > > 2.40.1
> > >
> >
> > On torvalds/master:
> >
> > $git grep TASK_SIZE_MIN
> > arch/loongarch/include/asm/processor.h:23:#define TASK_SIZE_MIN TASK_SIZE
> > arch/loongarch/include/asm/processor.h:36:#define TASK_SIZE_MIN TASK_SIZE32
> > arch/riscv/include/asm/pgtable.h:881:#define TASK_SIZE_MIN      (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> > arch/riscv/include/asm/pgtable.h:893:#define TASK_SIZE_MIN      TASK_SIZE
> >
> > I can only see definitions, without any usage, so agreed on removing them.
> >
> > FWIW:
> > Reviewed-by: Leonardo Bras <leobras@redhat.com>
> Thx
> 
> >
> > I would also send a patch for loongarch, since they are in the same boat :)
> Eh... I've sent one yesterday together.
> 
> https://lore.kernel.org/loongarch/20231221054624.2208019-1-guoren@kernel.org/

Awesome! :)

> 
> >
> > Thanks!
> > Leo
> >
> 
> 
> -- 
> Best Regards
>  Guo Ren
> 


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Leonardo Bras <leobras@redhat.com>
To: Guo Ren <guoren@kernel.org>
Cc: Leonardo Bras <leobras@redhat.com>,
	linux-kernel@vger.kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, alexghiti@rivosinc.com, charlie@rivosinc.com,
	xiao.w.wang@intel.com, david@redhat.com,
	panqinglin2020@iscas.ac.cn, rick.p.edgecombe@intel.com,
	willy@infradead.org, bjorn@rivosinc.com,
	conor.dooley@microchip.com, cleger@rivosinc.com,
	linux-riscv@lists.infradead.org,
	Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V2 3/4] riscv: mm: Remove unused TASK_SIZE_MIN
Date: Fri, 22 Dec 2023 04:22:10 -0300	[thread overview]
Message-ID: <ZYU5InA7WcpGKaRF@LeoBras> (raw)
In-Reply-To: <CAJF2gTQSZSWJ7qZQckuALHkcJb8kEGTnb8wJQ9H2wgODkN56Lw@mail.gmail.com>

On Fri, Dec 22, 2023 at 03:16:45PM +0800, Guo Ren wrote:
> On Fri, Dec 22, 2023 at 12:49 PM Leonardo Bras <leobras@redhat.com> wrote:
> >
> > On Thu, Dec 21, 2023 at 10:47:00AM -0500, guoren@kernel.org wrote:
> > > From: Guo Ren <guoren@linux.alibaba.com>
> > >
> > > Remove TASK_SIZE_MIN because it's not used anymore.
> > >
> > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > > Signed-off-by: Guo Ren <guoren@kernel.org>
> > > ---
> > >  arch/riscv/include/asm/pgtable.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> > > index 74ffb2178f54..e415582276ec 100644
> > > --- a/arch/riscv/include/asm/pgtable.h
> > > +++ b/arch/riscv/include/asm/pgtable.h
> > > @@ -878,7 +878,6 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)
> > >   */
> > >  #ifdef CONFIG_64BIT
> > >  #define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2)
> > > -#define TASK_SIZE_MIN        (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> > >
> > >  #ifdef CONFIG_COMPAT
> > >  #define TASK_SIZE_32 (_AC(0x80000000, UL))
> > > @@ -890,7 +889,6 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)
> > >
> > >  #else
> > >  #define TASK_SIZE    FIXADDR_START
> > > -#define TASK_SIZE_MIN        TASK_SIZE
> > >  #endif
> > >
> > >  #else /* CONFIG_MMU */
> > > --
> > > 2.40.1
> > >
> >
> > On torvalds/master:
> >
> > $git grep TASK_SIZE_MIN
> > arch/loongarch/include/asm/processor.h:23:#define TASK_SIZE_MIN TASK_SIZE
> > arch/loongarch/include/asm/processor.h:36:#define TASK_SIZE_MIN TASK_SIZE32
> > arch/riscv/include/asm/pgtable.h:881:#define TASK_SIZE_MIN      (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> > arch/riscv/include/asm/pgtable.h:893:#define TASK_SIZE_MIN      TASK_SIZE
> >
> > I can only see definitions, without any usage, so agreed on removing them.
> >
> > FWIW:
> > Reviewed-by: Leonardo Bras <leobras@redhat.com>
> Thx
> 
> >
> > I would also send a patch for loongarch, since they are in the same boat :)
> Eh... I've sent one yesterday together.
> 
> https://lore.kernel.org/loongarch/20231221054624.2208019-1-guoren@kernel.org/

Awesome! :)

> 
> >
> > Thanks!
> > Leo
> >
> 
> 
> -- 
> Best Regards
>  Guo Ren
> 


  reply	other threads:[~2023-12-22  7:22 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 15:46 [PATCH V2 0/4] riscv: mm: Fixup & Optimize COMPAT code guoren
2023-12-21 15:46 ` guoren
2023-12-21 15:46 ` [PATCH V2 1/4] riscv: mm: Fixup compat mode boot failure guoren
2023-12-21 15:46   ` guoren
2023-12-22  1:51   ` Leonardo Bras
2023-12-22  1:51     ` Leonardo Bras
2023-12-22  2:57     ` Guo Ren
2023-12-22  2:57       ` Guo Ren
2023-12-22  3:50       ` Charlie Jenkins
2023-12-22  3:50         ` Charlie Jenkins
2023-12-22  4:32         ` Leonardo Bras
2023-12-22  4:32           ` Leonardo Bras
2023-12-22  7:33           ` Guo Ren
2023-12-22  7:33             ` Guo Ren
2023-12-22 10:58         ` Guo Ren
2023-12-22 10:58           ` Guo Ren
2023-12-21 15:46 ` [PATCH V2 2/4] riscv: mm: Fixup compat arch_get_mmap_end guoren
2023-12-21 15:46   ` guoren
2023-12-22  3:34   ` Leonardo Bras
2023-12-22  3:34     ` Leonardo Bras
2023-12-22  4:04     ` Charlie Jenkins
2023-12-22  4:04       ` Charlie Jenkins
2023-12-22  4:23       ` Leonardo Bras
2023-12-22  4:23         ` Leonardo Bras
2023-12-22  5:42         ` Charlie Jenkins
2023-12-22  5:42           ` Charlie Jenkins
2023-12-22  8:27           ` Leonardo Bras
2023-12-22  8:27             ` Leonardo Bras
2023-12-22  4:36       ` Guo Ren
2023-12-22  4:36         ` Guo Ren
2023-12-22  4:26     ` Guo Ren
2023-12-22  4:26       ` Guo Ren
2023-12-22  4:43       ` Leonardo Bras
2023-12-22  4:43         ` Leonardo Bras
2023-12-22  4:50         ` Guo Ren
2023-12-22  4:50           ` Guo Ren
2023-12-22  5:27           ` Leonardo Bras
2023-12-22  5:27             ` Leonardo Bras
2023-12-22  7:20             ` Guo Ren
2023-12-22  7:20               ` Guo Ren
2023-12-22  7:49               ` Leonardo Bras
2023-12-22  7:49                 ` Leonardo Bras
2023-12-22  8:59   ` David Laight
2023-12-22  8:59     ` David Laight
2023-12-22  9:33     ` Guo Ren
2023-12-22  9:33       ` Guo Ren
2023-12-21 15:47 ` [PATCH V2 3/4] riscv: mm: Remove unused TASK_SIZE_MIN guoren
2023-12-21 15:47   ` guoren
2023-12-22  4:49   ` Leonardo Bras
2023-12-22  4:49     ` Leonardo Bras
2023-12-22  7:16     ` Guo Ren
2023-12-22  7:16       ` Guo Ren
2023-12-22  7:22       ` Leonardo Bras [this message]
2023-12-22  7:22         ` Leonardo Bras
2023-12-21 15:47 ` [PATCH V2 4/4] riscv: mm: Optimize TASK_SIZE definition guoren
2023-12-21 15:47   ` guoren
2023-12-22  5:09   ` Leonardo Bras
2023-12-22  5:09     ` Leonardo Bras
2023-12-22 11:25     ` Guo Ren
2023-12-22 11:25       ` Guo Ren
2023-12-22 11:52       ` David Laight
2023-12-22 11:52         ` David Laight
2023-12-23  2:38         ` Guo Ren
2023-12-23  2:38           ` Guo Ren
2023-12-23  2:52         ` Guo Ren
2023-12-23  2:52           ` Guo Ren
2023-12-23 10:31           ` David Laight
2023-12-23 10:31             ` David Laight
2023-12-24  1:24             ` Guo Ren
2023-12-24  1:24               ` Guo Ren
2023-12-24 14:37               ` David Laight
2023-12-24 14:37                 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYU5InA7WcpGKaRF@LeoBras \
    --to=leobras@redhat.com \
    --cc=alexghiti@rivosinc.com \
    --cc=bjorn@rivosinc.com \
    --cc=charlie@rivosinc.com \
    --cc=cleger@rivosinc.com \
    --cc=conor.dooley@microchip.com \
    --cc=david@redhat.com \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=panqinglin2020@iscas.ac.cn \
    --cc=paul.walmsley@sifive.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=willy@infradead.org \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.