* [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
@ 2023-12-26 11:22 Youling Tang
2023-12-26 17:13 ` kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: Youling Tang @ 2023-12-26 11:22 UTC (permalink / raw)
To: Baoquan He; +Cc: Huacai Chen, linux-kernel, Youling Tang
From: Youling Tang <tangyouling@kylinos.cn>
Remove duplicate definitions, no functional changes.
Reported-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
---
include/linux/crash_core.h | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
index 5126a4fecb44..02397c5639fe 100644
--- a/include/linux/crash_core.h
+++ b/include/linux/crash_core.h
@@ -87,16 +87,6 @@ Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
void *data, size_t data_len);
void final_note(Elf_Word *buf);
-#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
-#ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
-#define DEFAULT_CRASH_KERNEL_LOW_SIZE (128UL << 20)
-#endif
-#endif
-
-int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
- unsigned long long *crash_size, unsigned long long *crash_base,
- unsigned long long *low_size, bool *high);
-
#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
#ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
#define DEFAULT_CRASH_KERNEL_LOW_SIZE (128UL << 20)
@@ -111,6 +101,10 @@ int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
#define CRASH_ADDR_HIGH_MAX memblock_end_of_DRAM()
#endif
+int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
+ unsigned long long *crash_size, unsigned long long *crash_base,
+ unsigned long long *low_size, bool *high);
+
void __init reserve_crashkernel_generic(char *cmdline,
unsigned long long crash_size,
unsigned long long crash_base,
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
2023-12-26 11:22 [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE Youling Tang
@ 2023-12-26 17:13 ` kernel test robot
2023-12-27 0:48 ` Baoquan He
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2023-12-26 17:13 UTC (permalink / raw)
To: Youling Tang, Baoquan He
Cc: oe-kbuild-all, Huacai Chen, linux-kernel, Youling Tang
Hi Youling,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Youling-Tang/kdump-Remove-redundant-DEFAULT_CRASH_KERNEL_LOW_SIZE/20231226-193215
base: linus/master
patch link: https://lore.kernel.org/r/MW4PR84MB3145D3EB871BBD59AA71C0FC8198A%40MW4PR84MB3145.NAMPRD84.PROD.OUTLOOK.COM
patch subject: [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
config: i386-buildonly-randconfig-002-20231226 (https://download.01.org/0day-ci/archive/20231227/202312270133.8w4Wrh4h-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231227/202312270133.8w4Wrh4h-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312270133.8w4Wrh4h-lkp@intel.com/
All errors (new ones prefixed by >>):
arch/x86/kernel/setup.c: In function 'arch_reserve_crashkernel':
>> arch/x86/kernel/setup.c:479:8: error: implicit declaration of function 'parse_crashkernel' [-Werror=implicit-function-declaration]
479 | ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/parse_crashkernel +479 arch/x86/kernel/setup.c
a0a0becd2da0ba Yinghai Lu 2008-07-03 468
9c08a2a139fe83 Baoquan He 2023-09-14 469 static void __init arch_reserve_crashkernel(void)
ccb4defa71744f Yinghai Lu 2008-06-25 470 {
9c08a2a139fe83 Baoquan He 2023-09-14 471 unsigned long long crash_base, crash_size, low_size = 0;
9c08a2a139fe83 Baoquan He 2023-09-14 472 char *cmdline = boot_command_line;
55a20ee7804ab6 Yinghai Lu 2013-04-15 473 bool high = false;
ccb4defa71744f Yinghai Lu 2008-06-25 474 int ret;
ccb4defa71744f Yinghai Lu 2008-06-25 475
4ece09be9913a8 Jisheng Zhang 2022-03-23 476 if (!IS_ENABLED(CONFIG_KEXEC_CORE))
4ece09be9913a8 Jisheng Zhang 2022-03-23 477 return;
4ece09be9913a8 Jisheng Zhang 2022-03-23 478
9c08a2a139fe83 Baoquan He 2023-09-14 @479 ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),
9c08a2a139fe83 Baoquan He 2023-09-14 480 &crash_size, &crash_base,
9c08a2a139fe83 Baoquan He 2023-09-14 481 &low_size, &high);
9c08a2a139fe83 Baoquan He 2023-09-14 482 if (ret)
32105f7fd8faa7 Bernhard Walle 2008-06-26 483 return;
32105f7fd8faa7 Bernhard Walle 2008-06-26 484
3db3eb285259ac Petr Tesarik 2018-04-25 485 if (xen_pv_domain()) {
3db3eb285259ac Petr Tesarik 2018-04-25 486 pr_info("Ignoring crashkernel for a Xen PV domain\n");
3db3eb285259ac Petr Tesarik 2018-04-25 487 return;
3db3eb285259ac Petr Tesarik 2018-04-25 488 }
3db3eb285259ac Petr Tesarik 2018-04-25 489
9c08a2a139fe83 Baoquan He 2023-09-14 490 reserve_crashkernel_generic(cmdline, crash_size, crash_base,
9c08a2a139fe83 Baoquan He 2023-09-14 491 low_size, high);
ccb4defa71744f Yinghai Lu 2008-06-25 492 }
ccb4defa71744f Yinghai Lu 2008-06-25 493
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
2023-12-26 17:13 ` kernel test robot
@ 2023-12-27 0:48 ` Baoquan He
0 siblings, 0 replies; 3+ messages in thread
From: Baoquan He @ 2023-12-27 0:48 UTC (permalink / raw)
To: kernel test robot
Cc: Youling Tang, oe-kbuild-all, Huacai Chen, linux-kernel,
Youling Tang
On 12/27/23 at 01:13am, kernel test robot wrote:
> Hi Youling,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v6.7-rc7 next-20231222]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Youling-Tang/kdump-Remove-redundant-DEFAULT_CRASH_KERNEL_LOW_SIZE/20231226-193215
> base: linus/master
> patch link: https://lore.kernel.org/r/MW4PR84MB3145D3EB871BBD59AA71C0FC8198A%40MW4PR84MB3145.NAMPRD84.PROD.OUTLOOK.COM
> patch subject: [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
> config: i386-buildonly-randconfig-002-20231226 (https://download.01.org/0day-ci/archive/20231227/202312270133.8w4Wrh4h-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231227/202312270133.8w4Wrh4h-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312270133.8w4Wrh4h-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
This has been fixed by patch author's v2 patch:
https://lore.kernel.org/all/MW4PR84MB3145459ADC7EB38BBB36955B8198A@MW4PR84MB3145.NAMPRD84.PROD.OUTLOOK.COM/T/#u
>
> arch/x86/kernel/setup.c: In function 'arch_reserve_crashkernel':
> >> arch/x86/kernel/setup.c:479:8: error: implicit declaration of function 'parse_crashkernel' [-Werror=implicit-function-declaration]
> 479 | ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),
> | ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
>
> vim +/parse_crashkernel +479 arch/x86/kernel/setup.c
>
> a0a0becd2da0ba Yinghai Lu 2008-07-03 468
> 9c08a2a139fe83 Baoquan He 2023-09-14 469 static void __init arch_reserve_crashkernel(void)
> ccb4defa71744f Yinghai Lu 2008-06-25 470 {
> 9c08a2a139fe83 Baoquan He 2023-09-14 471 unsigned long long crash_base, crash_size, low_size = 0;
> 9c08a2a139fe83 Baoquan He 2023-09-14 472 char *cmdline = boot_command_line;
> 55a20ee7804ab6 Yinghai Lu 2013-04-15 473 bool high = false;
> ccb4defa71744f Yinghai Lu 2008-06-25 474 int ret;
> ccb4defa71744f Yinghai Lu 2008-06-25 475
> 4ece09be9913a8 Jisheng Zhang 2022-03-23 476 if (!IS_ENABLED(CONFIG_KEXEC_CORE))
> 4ece09be9913a8 Jisheng Zhang 2022-03-23 477 return;
> 4ece09be9913a8 Jisheng Zhang 2022-03-23 478
> 9c08a2a139fe83 Baoquan He 2023-09-14 @479 ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),
> 9c08a2a139fe83 Baoquan He 2023-09-14 480 &crash_size, &crash_base,
> 9c08a2a139fe83 Baoquan He 2023-09-14 481 &low_size, &high);
> 9c08a2a139fe83 Baoquan He 2023-09-14 482 if (ret)
> 32105f7fd8faa7 Bernhard Walle 2008-06-26 483 return;
> 32105f7fd8faa7 Bernhard Walle 2008-06-26 484
> 3db3eb285259ac Petr Tesarik 2018-04-25 485 if (xen_pv_domain()) {
> 3db3eb285259ac Petr Tesarik 2018-04-25 486 pr_info("Ignoring crashkernel for a Xen PV domain\n");
> 3db3eb285259ac Petr Tesarik 2018-04-25 487 return;
> 3db3eb285259ac Petr Tesarik 2018-04-25 488 }
> 3db3eb285259ac Petr Tesarik 2018-04-25 489
> 9c08a2a139fe83 Baoquan He 2023-09-14 490 reserve_crashkernel_generic(cmdline, crash_size, crash_base,
> 9c08a2a139fe83 Baoquan He 2023-09-14 491 low_size, high);
> ccb4defa71744f Yinghai Lu 2008-06-25 492 }
> ccb4defa71744f Yinghai Lu 2008-06-25 493
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-27 0:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-26 11:22 [PATCH] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE Youling Tang
2023-12-26 17:13 ` kernel test robot
2023-12-27 0:48 ` Baoquan He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.