From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, wens@csie.org, samuel@sholland.org,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH v5 1/3] phy: handle optional regulator for PHY
Date: Tue, 2 Jan 2024 11:38:59 +0000 [thread overview]
Message-ID: <ZZP10wqfHFD72e9s@shell.armlinux.org.uk> (raw)
In-Reply-To: <f729baa5-7986-4841-8cd6-fc4bdc652f75@lunn.ch>
On Thu, Dec 21, 2023 at 10:06:50AM +0100, Andrew Lunn wrote:
> I've not used regulators much, but i think you can combine these two
> into one. Its guaranteed *consumer is NULL if reg_cnt == 0. And
> kfree() is happy with a NULL pointer.
kfree(NULL) is valid (and is a no-op.)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, wens@csie.org, samuel@sholland.org,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH v5 1/3] phy: handle optional regulator for PHY
Date: Tue, 2 Jan 2024 11:38:59 +0000 [thread overview]
Message-ID: <ZZP10wqfHFD72e9s@shell.armlinux.org.uk> (raw)
In-Reply-To: <f729baa5-7986-4841-8cd6-fc4bdc652f75@lunn.ch>
On Thu, Dec 21, 2023 at 10:06:50AM +0100, Andrew Lunn wrote:
> I've not used regulators much, but i think you can combine these two
> into one. Its guaranteed *consumer is NULL if reg_cnt == 0. And
> kfree() is happy with a NULL pointer.
kfree(NULL) is valid (and is a no-op.)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-02 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 20:35 [PATCH v5 0/3] arm64: add ethernet to orange pi 3 & one plus Jernej Skrabec
2023-12-20 20:35 ` Jernej Skrabec
2023-12-20 20:35 ` [PATCH v5 1/3] phy: handle optional regulator for PHY Jernej Skrabec
2023-12-20 20:35 ` Jernej Skrabec
2023-12-21 9:06 ` Andrew Lunn
2023-12-21 9:06 ` Andrew Lunn
2024-01-02 11:38 ` Russell King (Oracle) [this message]
2024-01-02 11:38 ` Russell King (Oracle)
2023-12-22 12:52 ` Simon Horman
2023-12-22 12:52 ` Simon Horman
2024-01-02 11:30 ` Russell King (Oracle)
2024-01-02 11:30 ` Russell King (Oracle)
2023-12-20 20:35 ` [PATCH v5 2/3] arm64: dts: allwinner: orange-pi-3: Enable ethernet Jernej Skrabec
2023-12-20 20:35 ` Jernej Skrabec
2023-12-20 20:35 ` [PATCH v5 3/3] arm64: dts: allwinner: orange-pi-one-plus: Fix ethernet Jernej Skrabec
2023-12-20 20:35 ` Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZP10wqfHFD72e9s@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.