* [PATCH trivial] chardev/char.c: fix "abstract device type" error message
@ 2024-01-03 11:42 Michael Tokarev
2024-01-03 14:16 ` Zhao Liu
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2024-01-03 11:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Tokarev, qemu-trivial, Marc-André Lureau
Current error message:
qemu-system-x86_64: -chardev spice,id=foo: Parameter 'driver' expects an abstract device type
while in fact the meaning is in reverse, -chardev expects
a non-abstract device type.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Fixes: 777357d758d9 "chardev: qom-ify" (2016-12-07)
---
chardev/char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index 996a024c7a..119b548784 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -518,7 +518,7 @@ static const ChardevClass *char_get_class(const char *driver, Error **errp)
if (object_class_is_abstract(oc)) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
- "an abstract device type");
+ "a non-abstract device type");
return NULL;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH trivial] chardev/char.c: fix "abstract device type" error message
2024-01-03 11:42 [PATCH trivial] chardev/char.c: fix "abstract device type" error message Michael Tokarev
@ 2024-01-03 14:16 ` Zhao Liu
0 siblings, 0 replies; 2+ messages in thread
From: Zhao Liu @ 2024-01-03 14:16 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-devel, qemu-trivial, Marc-André Lureau
On Wed, Jan 03, 2024 at 02:42:21PM +0300, Michael Tokarev wrote:
> Date: Wed, 3 Jan 2024 14:42:21 +0300
> From: Michael Tokarev <mjt@tls.msk.ru>
> Subject: [PATCH trivial] chardev/char.c: fix "abstract device type" error
> message
> X-Mailer: git-send-email 2.39.2
>
> Current error message:
>
> qemu-system-x86_64: -chardev spice,id=foo: Parameter 'driver' expects an abstract device type
>
> while in fact the meaning is in reverse, -chardev expects
> a non-abstract device type.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Fixes: 777357d758d9 "chardev: qom-ify" (2016-12-07)
> ---
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
> chardev/char.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 996a024c7a..119b548784 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -518,7 +518,7 @@ static const ChardevClass *char_get_class(const char *driver, Error **errp)
>
> if (object_class_is_abstract(oc)) {
> error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
> - "an abstract device type");
> + "a non-abstract device type");
> return NULL;
> }
>
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-03 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03 11:42 [PATCH trivial] chardev/char.c: fix "abstract device type" error message Michael Tokarev
2024-01-03 14:16 ` Zhao Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.