* [PATCH v1] perf stat: Fix hard coded ll miss units
@ 2023-12-11 18:12 Ian Rogers
2024-01-02 19:34 ` Ian Rogers
0 siblings, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2023-12-11 18:12 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, John Garry,
linux-perf-users, linux-kernel, Guillaume Endignoux
Copy-paste error where LL cache misses are reported as l1i.
Suggested-by: Guillaume Endignoux <guillaumee@google.com>
Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/stat-shadow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 1c5c3eeba4cf..e31426167852 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
static const double color_ratios[3] = {20.0, 10.0, 5.0};
print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
- "of all L1-icache accesses");
+ "of all LL-cache accesses");
}
static void print_dtlb_miss(struct perf_stat_config *config,
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] perf stat: Fix hard coded ll miss units
2023-12-11 18:12 [PATCH v1] perf stat: Fix hard coded ll miss units Ian Rogers
@ 2024-01-02 19:34 ` Ian Rogers
2024-01-02 20:01 ` Liang, Kan
0 siblings, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2024-01-02 19:34 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, John Garry,
linux-perf-users, linux-kernel, Guillaume Endignoux
On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@google.com> wrote:
>
> Copy-paste error where LL cache misses are reported as l1i.
>
> Suggested-by: Guillaume Endignoux <guillaumee@google.com>
> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
> Signed-off-by: Ian Rogers <irogers@google.com>
Ping. Trivial 1 character fix but no reviews :-(
Thanks,
Ian
> ---
> tools/perf/util/stat-shadow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> index 1c5c3eeba4cf..e31426167852 100644
> --- a/tools/perf/util/stat-shadow.c
> +++ b/tools/perf/util/stat-shadow.c
> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
> static const double color_ratios[3] = {20.0, 10.0, 5.0};
>
> print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
> - "of all L1-icache accesses");
> + "of all LL-cache accesses");
> }
>
> static void print_dtlb_miss(struct perf_stat_config *config,
> --
> 2.43.0.472.g3155946c3a-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] perf stat: Fix hard coded ll miss units
2024-01-02 19:34 ` Ian Rogers
@ 2024-01-02 20:01 ` Liang, Kan
2024-01-03 16:47 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Liang, Kan @ 2024-01-02 20:01 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Adrian Hunter, John Garry, linux-perf-users, linux-kernel,
Guillaume Endignoux
On 2024-01-02 2:34 p.m., Ian Rogers wrote:
> On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@google.com> wrote:
>>
>> Copy-paste error where LL cache misses are reported as l1i.
>>
>> Suggested-by: Guillaume Endignoux <guillaumee@google.com>
>> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
>> Signed-off-by: Ian Rogers <irogers@google.com>
>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> Ping. Trivial 1 character fix but no reviews :-(
>
> Thanks,
> Ian
>
>> ---
>> tools/perf/util/stat-shadow.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
>> index 1c5c3eeba4cf..e31426167852 100644
>> --- a/tools/perf/util/stat-shadow.c
>> +++ b/tools/perf/util/stat-shadow.c
>> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
>> static const double color_ratios[3] = {20.0, 10.0, 5.0};
>>
>> print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
>> - "of all L1-icache accesses");
>> + "of all LL-cache accesses");
>> }
>>
>> static void print_dtlb_miss(struct perf_stat_config *config,
>> --
>> 2.43.0.472.g3155946c3a-goog
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] perf stat: Fix hard coded ll miss units
2024-01-02 20:01 ` Liang, Kan
@ 2024-01-03 16:47 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-01-03 16:47 UTC (permalink / raw)
To: Liang, Kan
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Adrian Hunter,
John Garry, linux-perf-users, linux-kernel, Guillaume Endignoux
Em Tue, Jan 02, 2024 at 03:01:55PM -0500, Liang, Kan escreveu:
>
>
> On 2024-01-02 2:34 p.m., Ian Rogers wrote:
> > On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@google.com> wrote:
> >>
> >> Copy-paste error where LL cache misses are reported as l1i.
> >>
> >> Suggested-by: Guillaume Endignoux <guillaumee@google.com>
> >> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
> >> Signed-off-by: Ian Rogers <irogers@google.com>
> >
>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks, applied to perf-tools-next.
- Arnaldo
> Thanks,
> Kan
>
> > Ping. Trivial 1 character fix but no reviews :-(
> >
> > Thanks,
> > Ian
> >
> >> ---
> >> tools/perf/util/stat-shadow.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> >> index 1c5c3eeba4cf..e31426167852 100644
> >> --- a/tools/perf/util/stat-shadow.c
> >> +++ b/tools/perf/util/stat-shadow.c
> >> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
> >> static const double color_ratios[3] = {20.0, 10.0, 5.0};
> >>
> >> print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
> >> - "of all L1-icache accesses");
> >> + "of all LL-cache accesses");
> >> }
> >>
> >> static void print_dtlb_miss(struct perf_stat_config *config,
> >> --
> >> 2.43.0.472.g3155946c3a-goog
> >>
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-03 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-11 18:12 [PATCH v1] perf stat: Fix hard coded ll miss units Ian Rogers
2024-01-02 19:34 ` Ian Rogers
2024-01-02 20:01 ` Liang, Kan
2024-01-03 16:47 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.