All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: linux-arm-msm@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Eric Chanudet <echanude@redhat.com>,
	Shazad Hussain <shazhuss@qti.qualcomm.com>,
	Prasad Sodagudi <psodagud@quicinc.com>
Subject: sa8755p ufs ice bug: gcc_ufs_phy_ice_core_clk status stuck at 'off'
Date: Wed, 3 Jan 2024 21:09:38 -0500	[thread overview]
Message-ID: <ZZYTYsaNUuWQg3tR@x1> (raw)

Right now when we boot the RideSX4 (sa8775p) board on linux-next with
a quiet kernel log (specifically loglevel=4 - warning) about 50% of
the boots fail since UFS cannot be mounted. Changing the loglevel to
5 (notice) or higher to show more logging makes the race condition
and error go away. I tracked the error down to the following:

  - The ice driver fails to probe due to the error
    "gcc_ufs_phy_ice_core_clk status stuck at 'off'" and returns
    -EBUSY and is not retried. platform_set_drvdata() is never
    called as expected.

  - The qcom UFS host driver calls of_qcom_ice_get(), however this
    will always return -EPROBE_DEFER since the ice probe failed,
    and platform_get_drvdata() is always null.

Here's the relevant log messages that I was able to get from a failed
boot once I configured dracut to time out:

    gcc_ufs_phy_ice_core_clk status stuck at 'off' 
    qcom-ice: probe of 1d88000.crypto failed with error -16
    ufshcd-qcom 1d84000.ufs: Cannot get ice instance from 1d88000.crypto
    ufshcd-qcom 1d84000.ufs: Cannot get ice instance from 1d88000.crypto
    platform 1d84000.ufs: deferred probe pending: ufshcd-qcom: ufshcd_pltfrm_init() failed

I assume that there's some kind of vote (icc, clk, regulator, etc)
that's missing from the ice driver, and another driver is performing
the necessary votes. However, I don't have access to the hardware docs
to tell if that's the case. Can someone that has access take a look? I
can post patch(es) if someone can point me to what needs configured.

Brian


             reply	other threads:[~2024-01-04  2:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04  2:09 Brian Masney [this message]
2024-01-08 18:14 ` sa8755p ufs ice bug: gcc_ufs_phy_ice_core_clk status stuck at 'off' Shazad Hussain
2024-01-08 20:50   ` Brian Masney
2024-01-08 23:35     ` Elliot Berman
2024-01-09 21:44       ` Brian Masney
2024-01-09 21:56         ` Elliot Berman
2024-01-09 23:45           ` Brian Masney
2024-01-15 15:47           ` Brian Masney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZYTYsaNUuWQg3tR@x1 \
    --to=bmasney@redhat.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=echanude@redhat.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=psodagud@quicinc.com \
    --cc=shazhuss@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.