All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikko Rapeli <mikko.rapeli@linaro.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] runqemu: match .rootfs. in image names instead of -image-
Date: Thu, 4 Jan 2024 08:59:03 +0200	[thread overview]
Message-ID: <ZZZXN9gx2iLcDqdb@nuoska> (raw)
In-Reply-To: <CA+chaQcd4MKK_KMdmpEqCtMLZVGx_MCP3y5sVhteKdzDQnNPKg@mail.gmail.com>

Hi,

On Wed, Jan 03, 2024 at 03:54:02PM +0100, Martin Jansa wrote:
> On Wed, Jan 3, 2024 at 11:16 AM Mikko Rapeli <mikko.rapeli@linaro.org>
> wrote:
> 
> > Don't expect image file names to include "-image-" but
> > expect them to have the ".rootfs." postfix which is the
> > default.
> >
> 
> It's the current default, but whole runqemu won't work when someone changes:
> 
> meta/classes-recipe/image-artifact-names.bbclass:IMAGE_NAME_SUFFIX ??=
> ".rootfs"
> 
> So you should probably read IMAGE_NAME_SUFFIX variable first, but the most
> likely change someone will have in local.conf would be to drop this suffix
> and set this to empty and then the check for empty string in basename won't
> be very useful as well.

So drop this file name check completely? Fine for me. I'll send an update.

Cheers,

-Mikko


  reply	other threads:[~2024-01-04  6:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 10:16 [PATCH] runqemu: match .rootfs. in image names instead of -image- Mikko Rapeli
2024-01-03 14:54 ` [OE-core] " Martin Jansa
2024-01-04  6:59   ` Mikko Rapeli [this message]
     [not found]   ` <17A712B42F330FC5.10454@lists.openembedded.org>
2024-01-04  7:50     ` Mikko Rapeli
2024-01-04  8:34       ` Richard Purdie
2024-01-04  9:38         ` Mikko Rapeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZZXN9gx2iLcDqdb@nuoska \
    --to=mikko.rapeli@linaro.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.