Re: [OE-core] [PATCH] runqemu: match .rootfs. in image names instead of -image-

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Thu, Jan 04, 2024 at 08:59:03AM +0200, Mikko Rapeli via lists.openembedded.org wrote:
> Hi,
> 
> On Wed, Jan 03, 2024 at 03:54:02PM +0100, Martin Jansa wrote:
> > On Wed, Jan 3, 2024 at 11:16 AM Mikko Rapeli <mikko.rapeli@linaro.org>
> > wrote:
> > 
> > > Don't expect image file names to include "-image-" but
> > > expect them to have the ".rootfs." postfix which is the
> > > default.
> > >
> > 
> > It's the current default, but whole runqemu won't work when someone changes:
> > 
> > meta/classes-recipe/image-artifact-names.bbclass:IMAGE_NAME_SUFFIX ??=
> > ".rootfs"
> > 
> > So you should probably read IMAGE_NAME_SUFFIX variable first, but the most
> > likely change someone will have in local.conf would be to drop this suffix
> > and set this to empty and then the check for empty string in basename won't
> > be very useful as well.
> 
> So drop this file name check completely? Fine for me. I'll send an update.

As you said too, this doesn't work. runqemu has a bunch of heuristics to detect different
kinds of file arguments which break too easily. Test for .rootfs. in file name is IMO
better than than -image- in recipe/file name, but also not perfect. Using IMAGE_NAME_SUFFIX
would be nice but the indirection with qemuboot.conf makes this hard too, and if that variable
is set to empty then a lot of things break again on runqemu side heuristics, gah...

I have a dm-verity image recipe and a separate recipe which bakes that into a .wic image
file which I'd like to test with oeqa, testimage.bbclass and qemu.

It's either this patch or I rename all image recipes to have -image in their names.

Cheers,

-Mikko