From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Klinger <ak@it-klinger.de>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v2 07/10] iio: pressure: mprls0025pa.c whitespace cleanup
Date: Sat, 6 Jan 2024 16:03:17 +0200 [thread overview]
Message-ID: <ZZldpV13HaRUrQBU@smile.fi.intel.com> (raw)
In-Reply-To: <ZYxhUJlAb63wRJE-@sunspire>
On Wed, Dec 27, 2023 at 07:39:28PM +0200, Petre Rodan wrote:
> On Wed, Dec 27, 2023 at 06:34:25PM +0200, Andy Shevchenko wrote:
> > On Sun, Dec 24, 2023 at 04:34:52PM +0200, Petre Rodan wrote:
> > > Fix indentation and whitespace in code that will not get refactored.
> > >
> > > Make URL inside comment copy-paste friendly.
> >
> > > return dev_err_probe(dev, ret,
> > > - "honeywell,pmin-pascal could not be read\n");
> > > + "honeywell,pmin-pascal could not be read\n");
> >
> > As done elsewhere, here and in other similar places fix the indentation
> > by making first character on the latter line to be in the same column as
> > the first character after the opening parenthesis.
>
> I triple-checked that I am following the max 80 column rule, the parenthesis
> rule and the 'do not split printk messages' rules in all my code in these 10 patches.
> precisely so I don't get feedback like this one.
> if the parenthesis rule makes the line longer then 80 chars I right-align to
> column 80 as seen above.
> that is what I understand from the latest coding style document and that is what
> I will follow.
>
> in this particular case if I were to ignore the 80 column rule we would end up on
> column 90 if I were to follow your feedback (open parenthesis is at column 45
> and the error takes 45 chars more).
checkpatch has got an exceptional rule _not_ to warn on the long string
literals for 10+ years. It had happened much earlier than 100 relaxation one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-06 14:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 14:34 [PATCH v2 00/10] changes to mprls0025pa Petre Rodan
2023-12-24 14:34 ` [PATCH v2 01/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml fix Petre Rodan
2023-12-25 12:55 ` Krzysztof Kozlowski
2023-12-26 16:28 ` Jonathan Cameron
2023-12-26 16:31 ` Jonathan Cameron
2023-12-27 7:11 ` Petre Rodan
2023-12-30 11:28 ` Jonathan Cameron
2023-12-24 14:34 ` [PATCH v2 02/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add pressure-triplet Petre Rodan
2023-12-25 12:57 ` Krzysztof Kozlowski
2023-12-25 13:23 ` Petre Rodan
2023-12-25 13:34 ` Krzysztof Kozlowski
2023-12-25 13:37 ` Krzysztof Kozlowski
2023-12-25 13:58 ` Petre Rodan
2023-12-24 14:34 ` [PATCH v2 03/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add spi bus Petre Rodan
2023-12-25 12:59 ` Krzysztof Kozlowski
2023-12-25 15:13 ` Petre Rodan
2023-12-25 18:56 ` Krzysztof Kozlowski
2023-12-25 20:29 ` Petre Rodan
2023-12-26 9:38 ` Krzysztof Kozlowski
2023-12-24 14:34 ` [PATCH v2 04/10] iio: pressure: mprls0025pa.c fix off-by-one enum Petre Rodan
2023-12-26 16:33 ` Jonathan Cameron
2023-12-27 16:30 ` Andy Shevchenko
2023-12-24 14:34 ` [PATCH v2 05/10] iio: pressure: mprls0025pa.c fix error flag check Petre Rodan
2023-12-26 16:35 ` Jonathan Cameron
2023-12-24 14:34 ` [PATCH v2 06/10] iio: pressure: mprls0025pa.c remove dangerous defaults Petre Rodan
2023-12-26 16:39 ` Jonathan Cameron
2023-12-24 14:34 ` [PATCH v2 07/10] iio: pressure: mprls0025pa.c whitespace cleanup Petre Rodan
2023-12-27 16:34 ` Andy Shevchenko
2023-12-27 17:39 ` Petre Rodan
2023-12-30 11:33 ` Jonathan Cameron
2024-01-06 14:03 ` Andy Shevchenko [this message]
2023-12-24 14:34 ` [PATCH v2 08/10] iio: pressure: mprls0025pa.c refactor Petre Rodan
2023-12-26 16:49 ` Jonathan Cameron
2023-12-27 14:33 ` Petre Rodan
2023-12-27 16:37 ` Andy Shevchenko
2023-12-30 11:34 ` Jonathan Cameron
2023-12-24 14:34 ` [PATCH v2 09/10] iio: pressure: mprls0025pa.c add triplet property Petre Rodan
2023-12-24 14:34 ` [PATCH v2 10/10] iio: pressure: mprls0025pa.c add SPI driver Petre Rodan
2023-12-26 16:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZldpV13HaRUrQBU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.