All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libutempter: fix dependencies
@ 2024-01-06 22:05 Fabrice Fontaine
  2024-01-08 20:19 ` Adam Duskett
  2024-01-08 20:32 ` Yann E. MORIN
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-01-06 22:05 UTC (permalink / raw)
  To: buildroot; +Cc: Adam Duskett, Fabrice Fontaine

Commit 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b forgot to add
dependencies resulting in the following static build failure:

/home/autobuild/autobuild/instance-5/output-1/host/bin/arm-buildroot-linux-uclibcgnueabi-gcc -Wl,-z,relro -Wl,-stats  -static  -shared \
	-Wl,-soname,libutempter.so.0,--version-script=libutempter.map,-z,defs \
	-lc iface.os -o libutempter.so
/home/autobuild/autobuild/instance-5/output-1/host/lib/gcc/arm-buildroot-linux-uclibcgnueabi/12.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/autobuild/autobuild/instance-5/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/lib/libc.a(__uClibc_main.os): in function `__uClibc_fini':
__uClibc_main.c:(.text+0x190): undefined reference to `__fini_array_start'

Fixes:
 - http://autobuild.buildroot.org/results/781ab393455f0e6823b850f474f6fe38b27d8efa

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libutempter/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/libutempter/Config.in b/package/libutempter/Config.in
index a06a240418..5b79c1e44d 100644
--- a/package/libutempter/Config.in
+++ b/package/libutempter/Config.in
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_LIBUTEMPTER
 	bool "libutempter"
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
+	depends on !BR2_STATIC_LIBS
 	help
 	  The libutempter library provides interface for terminal
 	  emulators such as screen and xterm to record user
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libutempter: fix dependencies
  2024-01-06 22:05 [Buildroot] [PATCH 1/1] package/libutempter: fix dependencies Fabrice Fontaine
@ 2024-01-08 20:19 ` Adam Duskett
  2024-01-08 20:32 ` Yann E. MORIN
  1 sibling, 0 replies; 3+ messages in thread
From: Adam Duskett @ 2024-01-08 20:19 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

All;

Thank you Fabrice for the patch! Looks good to me!

Reviewed-by: Adam Duskett <adam.duskett@amarulasolutions.com>
Tested-by: Adam Duskett <adam.duskett@amarulasolutions.com>



On Sat, Jan 6, 2024 at 3:05 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Commit 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b forgot to add
> dependencies resulting in the following static build failure:
>
> /home/autobuild/autobuild/instance-5/output-1/host/bin/arm-buildroot-linux-uclibcgnueabi-gcc -Wl,-z,relro -Wl,-stats  -static  -shared \
>         -Wl,-soname,libutempter.so.0,--version-script=libutempter.map,-z,defs \
>         -lc iface.os -o libutempter.so
> /home/autobuild/autobuild/instance-5/output-1/host/lib/gcc/arm-buildroot-linux-uclibcgnueabi/12.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/autobuild/autobuild/instance-5/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/lib/libc.a(__uClibc_main.os): in function `__uClibc_fini':
> __uClibc_main.c:(.text+0x190): undefined reference to `__fini_array_start'
>
> Fixes:
>  - http://autobuild.buildroot.org/results/781ab393455f0e6823b850f474f6fe38b27d8efa
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libutempter/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/package/libutempter/Config.in b/package/libutempter/Config.in
> index a06a240418..5b79c1e44d 100644
> --- a/package/libutempter/Config.in
> +++ b/package/libutempter/Config.in
> @@ -1,5 +1,7 @@
>  config BR2_PACKAGE_LIBUTEMPTER
>         bool "libutempter"
> +       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
> +       depends on !BR2_STATIC_LIBS
>         help
>           The libutempter library provides interface for terminal
>           emulators such as screen and xterm to record user
> --
> 2.43.0
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libutempter: fix dependencies
  2024-01-06 22:05 [Buildroot] [PATCH 1/1] package/libutempter: fix dependencies Fabrice Fontaine
  2024-01-08 20:19 ` Adam Duskett
@ 2024-01-08 20:32 ` Yann E. MORIN
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-01-08 20:32 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Adam Duskett, buildroot

Fabricem, All,

On 2024-01-06 23:05 +0100, Fabrice Fontaine spake thusly:
> Commit 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b forgot to add
> dependencies resulting in the following static build failure:
> 
> /home/autobuild/autobuild/instance-5/output-1/host/bin/arm-buildroot-linux-uclibcgnueabi-gcc -Wl,-z,relro -Wl,-stats  -static  -shared \
> 	-Wl,-soname,libutempter.so.0,--version-script=libutempter.map,-z,defs \
> 	-lc iface.os -o libutempter.so
> /home/autobuild/autobuild/instance-5/output-1/host/lib/gcc/arm-buildroot-linux-uclibcgnueabi/12.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/autobuild/autobuild/instance-5/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/lib/libc.a(__uClibc_main.os): in function `__uClibc_fini':
> __uClibc_main.c:(.text+0x190): undefined reference to `__fini_array_start'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/781ab393455f0e6823b850f474f6fe38b27d8efa
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libutempter/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/libutempter/Config.in b/package/libutempter/Config.in
> index a06a240418..5b79c1e44d 100644
> --- a/package/libutempter/Config.in
> +++ b/package/libutempter/Config.in
> @@ -1,5 +1,7 @@
>  config BR2_PACKAGE_LIBUTEMPTER
>  	bool "libutempter"
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
> +	depends on !BR2_STATIC_LIBS

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  	help
>  	  The libutempter library provides interface for terminal
>  	  emulators such as screen and xterm to record user
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-08 20:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-06 22:05 [Buildroot] [PATCH 1/1] package/libutempter: fix dependencies Fabrice Fontaine
2024-01-08 20:19 ` Adam Duskett
2024-01-08 20:32 ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.