* [PATCH next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params()
@ 2025-04-15 10:45 Dan Carpenter
2025-04-15 11:09 ` Dmitry Baryshkov
2025-04-15 11:36 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-04-15 10:45 UTC (permalink / raw)
To: Wesley Cheng
Cc: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Greg Kroah-Hartman, linux-sound, linux-arm-msm,
linux-kernel, kernel-janitors
Propagate the error code if q6afe_port_get_from_id() fails. Don't
return success.
Fixes: 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
sound/soc/qcom/qdsp6/q6usb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6usb.c b/sound/soc/qcom/qdsp6/q6usb.c
index 274c251e84dd..adba0446f301 100644
--- a/sound/soc/qcom/qdsp6/q6usb.c
+++ b/sound/soc/qcom/qdsp6/q6usb.c
@@ -74,8 +74,10 @@ static int q6usb_hw_params(struct snd_pcm_substream *substream,
goto out;
q6usb_afe = q6afe_port_get_from_id(cpu_dai->dev, USB_RX);
- if (IS_ERR(q6usb_afe))
+ if (IS_ERR(q6usb_afe)) {
+ ret = PTR_ERR(q6usb_afe);
goto out;
+ }
/* Notify audio DSP about the devices being offloaded */
ret = afe_port_send_usb_dev_param(q6usb_afe, sdev->card_idx,
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params()
2025-04-15 10:45 [PATCH next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params() Dan Carpenter
@ 2025-04-15 11:09 ` Dmitry Baryshkov
2025-04-15 11:36 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-04-15 11:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Wesley Cheng, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Greg Kroah-Hartman, linux-sound,
linux-arm-msm, linux-kernel, kernel-janitors
On Tue, Apr 15, 2025 at 01:45:44PM +0300, Dan Carpenter wrote:
> Propagate the error code if q6afe_port_get_from_id() fails. Don't
> return success.
>
> Fixes: 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> sound/soc/qcom/qdsp6/q6usb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params()
2025-04-15 10:45 [PATCH next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params() Dan Carpenter
2025-04-15 11:09 ` Dmitry Baryshkov
@ 2025-04-15 11:36 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-04-15 11:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: Wesley Cheng, Srinivas Kandagatla, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Greg Kroah-Hartman, linux-sound, linux-arm-msm,
linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
On Tue, Apr 15, 2025 at 01:45:44PM +0300, Dan Carpenter wrote:
> Propagate the error code if q6afe_port_get_from_id() fails. Don't
> return success.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-15 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15 10:45 [PATCH next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params() Dan Carpenter
2025-04-15 11:09 ` Dmitry Baryshkov
2025-04-15 11:36 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.