All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Pylypiv <ipylypiv@google.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 3/3] ata: libata-sata: Use BIT() macro
Date: Tue, 15 Apr 2025 11:05:03 -0700	[thread overview]
Message-ID: <Z_6fz6kKim5upPtj@google.com> (raw)
In-Reply-To: <20250415073013.414987-8-cassel@kernel.org>

On Tue, Apr 15, 2025 at 09:30:17AM +0200, Niklas Cassel wrote:
> The BIT() macro is commonly used in the kernel.
> Make use of it when converting a tag, fetched from the Successful NCQ
> Commands log or the NCQ Command Error log, to a bit field.
> This makes the code easier to read.
> 
> Suggested-by: Igor Pylypiv <ipylypiv@google.com>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Igor Pylypiv <ipylypiv@google.com>

Thanks!

  parent reply	other threads:[~2025-04-15 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  7:30 [PATCH v2 0/3] Successful NCQ commands sense_valid cleanups/fixes Niklas Cassel
2025-04-15  7:30 ` [PATCH v2 1/3] ata: libata-sata: Save all fields from sense data descriptor Niklas Cassel
2025-04-16  8:35   ` Damien Le Moal
2025-04-15  7:30 ` [PATCH v2 2/3] ata: libata-sata: Simplify sense_valid fetching Niklas Cassel
2025-04-15 18:03   ` Igor Pylypiv
2025-04-15  7:30 ` [PATCH v2 3/3] ata: libata-sata: Use BIT() macro Niklas Cassel
2025-04-15  7:47   ` Hannes Reinecke
2025-04-15 18:05   ` Igor Pylypiv [this message]
2025-04-16  8:32   ` Damien Le Moal
2025-04-16  9:19     ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_6fz6kKim5upPtj@google.com \
    --to=ipylypiv@google.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.