All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols
Date: Mon, 7 Apr 2025 17:25:06 +0300	[thread overview]
Message-ID: <Z_PgQvvcZjZ-4fTS@smile.fi.intel.com> (raw)
In-Reply-To: <ba58d467-1525-496b-b8ba-b14aa04307a1@redhat.com>

On Mon, Apr 07, 2025 at 03:49:26PM +0200, Hans de Goede wrote:
> On 7-Apr-25 12:27, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 11:20:15AM +0200, Hans de Goede wrote:
> >> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> >> significantly different mainboards. The only outward difference is that
> >> the charging barrel on one is marked 5V and the other is marked 9V.
> >>
> >> Both need to be handled by the x86-android-tablets code. Add 9v to
> >> the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
> >> symbols to prepare for adding support for the 5V version.
> >>
> >> All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/
> > 
> > And period :-)
> > 
> > All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.
> 
> It feels a bit silly to send a v2 just to add a period to the commit msg.

I agree, it can be tweaked whilst applying, but I'm not the one in charge here
:-)

> Ilpo do you want me to send a v2 of this series?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-04-07 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  9:20 [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols Hans de Goede
2025-04-07  9:20 ` [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data Hans de Goede
2025-04-07 10:32   ` Andy Shevchenko
2025-04-07 11:22     ` Hans de Goede
2025-04-07 12:25       ` Andy Shevchenko
2025-04-07 10:27 ` [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols Andy Shevchenko
2025-04-07 13:49   ` Hans de Goede
2025-04-07 14:25     ` Andy Shevchenko [this message]
2025-04-07 15:24     ` Ilpo Järvinen
2025-04-11 10:03 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_PgQvvcZjZ-4fTS@smile.fi.intel.com \
    --to=andy@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.