[PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[Hans de Goede]

The Vexia EDU ATLA 10 tablet comes in 2 different versions with
significantly different mainboards. The only outward difference is that
the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to
the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
symbols to prepare for adding support for the 5V version.

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 .../platform/x86/x86-android-tablets/dmi.c    |  2 +-
 .../platform/x86/x86-android-tablets/other.c  | 64 +++++++++----------
 .../x86-android-tablets/x86-android-tablets.h |  2 +-
 3 files changed, 34 insertions(+), 34 deletions(-)

diff --git a/drivers/platform/x86/x86-android-tablets/dmi.c b/drivers/platform/x86/x86-android-tablets/dmi.c
index 3e5fa3b6e2fd..e43d482b17a3 100644
--- a/drivers/platform/x86/x86-android-tablets/dmi.c
+++ b/drivers/platform/x86/x86-android-tablets/dmi.c
@@ -187,7 +187,7 @@ const struct dmi_system_id x86_android_tablet_ids[] __initconst = {
 			/* Above strings are too generic, also match on BIOS date */
 			DMI_MATCH(DMI_BIOS_DATE, "08/25/2014"),
 		},
-		.driver_data = (void *)&vexia_edu_atla10_info,
+		.driver_data = (void *)&vexia_edu_atla10_9v_info,
 	},
 	{
 		/* Whitelabel (sold as various brands) TM800A550L */
diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c
index 1d93d9edb23f..74dcac8d19d7 100644
--- a/drivers/platform/x86/x86-android-tablets/other.c
+++ b/drivers/platform/x86/x86-android-tablets/other.c
@@ -599,62 +599,62 @@ const struct x86_dev_info whitelabel_tm800a550l_info __initconst = {
 };
 
 /*
- * Vexia EDU ATLA 10 tablet, Android 4.2 / 4.4 + Guadalinex Ubuntu tablet
+ * Vexia EDU ATLA 10 tablet 9V, Android 4.2 + Guadalinex Ubuntu tablet
  * distributed to schools in the Spanish Andalucía region.
  */
 static const char * const crystal_cove_pwrsrc_psy[] = { "crystal_cove_pwrsrc" };
 
-static const struct property_entry vexia_edu_atla10_ulpmc_props[] = {
+static const struct property_entry vexia_edu_atla10_9v_ulpmc_props[] = {
 	PROPERTY_ENTRY_STRING_ARRAY("supplied-from", crystal_cove_pwrsrc_psy),
 	{ }
 };
 
-static const struct software_node vexia_edu_atla10_ulpmc_node = {
-	.properties = vexia_edu_atla10_ulpmc_props,
+static const struct software_node vexia_edu_atla10_9v_ulpmc_node = {
+	.properties = vexia_edu_atla10_9v_ulpmc_props,
 };
 
-static const char * const vexia_edu_atla10_accel_mount_matrix[] = {
+static const char * const vexia_edu_atla10_9v_accel_mount_matrix[] = {
 	"0", "-1", "0",
 	"1", "0", "0",
 	"0", "0", "1"
 };
 
-static const struct property_entry vexia_edu_atla10_accel_props[] = {
-	PROPERTY_ENTRY_STRING_ARRAY("mount-matrix", vexia_edu_atla10_accel_mount_matrix),
+static const struct property_entry vexia_edu_atla10_9v_accel_props[] = {
+	PROPERTY_ENTRY_STRING_ARRAY("mount-matrix", vexia_edu_atla10_9v_accel_mount_matrix),
 	{ }
 };
 
-static const struct software_node vexia_edu_atla10_accel_node = {
-	.properties = vexia_edu_atla10_accel_props,
+static const struct software_node vexia_edu_atla10_9v_accel_node = {
+	.properties = vexia_edu_atla10_9v_accel_props,
 };
 
-static const struct property_entry vexia_edu_atla10_touchscreen_props[] = {
+static const struct property_entry vexia_edu_atla10_9v_touchscreen_props[] = {
 	PROPERTY_ENTRY_U32("hid-descr-addr", 0x0000),
 	PROPERTY_ENTRY_U32("post-reset-deassert-delay-ms", 120),
 	{ }
 };
 
-static const struct software_node vexia_edu_atla10_touchscreen_node = {
-	.properties = vexia_edu_atla10_touchscreen_props,
+static const struct software_node vexia_edu_atla10_9v_touchscreen_node = {
+	.properties = vexia_edu_atla10_9v_touchscreen_props,
 };
 
-static const struct property_entry vexia_edu_atla10_pmic_props[] = {
+static const struct property_entry vexia_edu_atla10_9v_pmic_props[] = {
 	PROPERTY_ENTRY_BOOL("linux,register-pwrsrc-power_supply"),
 	{ }
 };
 
-static const struct software_node vexia_edu_atla10_pmic_node = {
-	.properties = vexia_edu_atla10_pmic_props,
+static const struct software_node vexia_edu_atla10_9v_pmic_node = {
+	.properties = vexia_edu_atla10_9v_pmic_props,
 };
 
-static const struct x86_i2c_client_info vexia_edu_atla10_i2c_clients[] __initconst = {
+static const struct x86_i2c_client_info vexia_edu_atla10_9v_i2c_clients[] __initconst = {
 	{
 		/* I2C attached embedded controller, used to access fuel-gauge */
 		.board_info = {
 			.type = "vexia_atla10_ec",
 			.addr = 0x76,
 			.dev_name = "ulpmc",
-			.swnode = &vexia_edu_atla10_ulpmc_node,
+			.swnode = &vexia_edu_atla10_9v_ulpmc_node,
 		},
 		.adapter_path = "0000:00:18.1",
 	}, {
@@ -679,7 +679,7 @@ static const struct x86_i2c_client_info vexia_edu_atla10_i2c_clients[] __initcon
 			.type = "kxtj21009",
 			.addr = 0x0f,
 			.dev_name = "kxtj21009",
-			.swnode = &vexia_edu_atla10_accel_node,
+			.swnode = &vexia_edu_atla10_9v_accel_node,
 		},
 		.adapter_path = "0000:00:18.5",
 	}, {
@@ -688,7 +688,7 @@ static const struct x86_i2c_client_info vexia_edu_atla10_i2c_clients[] __initcon
 			.type = "hid-over-i2c",
 			.addr = 0x38,
 			.dev_name = "FTSC1000",
-			.swnode = &vexia_edu_atla10_touchscreen_node,
+			.swnode = &vexia_edu_atla10_9v_touchscreen_node,
 		},
 		.adapter_path = "0000:00:18.6",
 		.irq_data = {
@@ -703,7 +703,7 @@ static const struct x86_i2c_client_info vexia_edu_atla10_i2c_clients[] __initcon
 			.type = "intel_soc_pmic_crc",
 			.addr = 0x6e,
 			.dev_name = "intel_soc_pmic_crc",
-			.swnode = &vexia_edu_atla10_pmic_node,
+			.swnode = &vexia_edu_atla10_9v_pmic_node,
 		},
 		.adapter_path = "0000:00:18.7",
 		.irq_data = {
@@ -715,7 +715,7 @@ static const struct x86_i2c_client_info vexia_edu_atla10_i2c_clients[] __initcon
 	}
 };
 
-static const struct x86_serdev_info vexia_edu_atla10_serdevs[] __initconst = {
+static const struct x86_serdev_info vexia_edu_atla10_9v_serdevs[] __initconst = {
 	{
 		.ctrl.pci.devfn = PCI_DEVFN(0x1e, 3),
 		.ctrl_devname = "serial0",
@@ -723,7 +723,7 @@ static const struct x86_serdev_info vexia_edu_atla10_serdevs[] __initconst = {
 	},
 };
 
-static struct gpiod_lookup_table vexia_edu_atla10_ft5416_gpios = {
+static struct gpiod_lookup_table vexia_edu_atla10_9v_ft5416_gpios = {
 	.dev_id = "i2c-FTSC1000",
 	.table = {
 		GPIO_LOOKUP("INT33FC:00", 60, "reset", GPIO_ACTIVE_LOW),
@@ -731,12 +731,12 @@ static struct gpiod_lookup_table vexia_edu_atla10_ft5416_gpios = {
 	},
 };
 
-static struct gpiod_lookup_table * const vexia_edu_atla10_gpios[] = {
-	&vexia_edu_atla10_ft5416_gpios,
+static struct gpiod_lookup_table * const vexia_edu_atla10_9v_gpios[] = {
+	&vexia_edu_atla10_9v_ft5416_gpios,
 	NULL
 };
 
-static int __init vexia_edu_atla10_init(struct device *dev)
+static int __init vexia_edu_atla10_9v_init(struct device *dev)
 {
 	struct pci_dev *pdev;
 	int ret;
@@ -760,13 +760,13 @@ static int __init vexia_edu_atla10_init(struct device *dev)
 	return 0;
 }
 
-const struct x86_dev_info vexia_edu_atla10_info __initconst = {
-	.i2c_client_info = vexia_edu_atla10_i2c_clients,
-	.i2c_client_count = ARRAY_SIZE(vexia_edu_atla10_i2c_clients),
-	.serdev_info = vexia_edu_atla10_serdevs,
-	.serdev_count = ARRAY_SIZE(vexia_edu_atla10_serdevs),
-	.gpiod_lookup_tables = vexia_edu_atla10_gpios,
-	.init = vexia_edu_atla10_init,
+const struct x86_dev_info vexia_edu_atla10_9v_info __initconst = {
+	.i2c_client_info = vexia_edu_atla10_9v_i2c_clients,
+	.i2c_client_count = ARRAY_SIZE(vexia_edu_atla10_9v_i2c_clients),
+	.serdev_info = vexia_edu_atla10_9v_serdevs,
+	.serdev_count = ARRAY_SIZE(vexia_edu_atla10_9v_serdevs),
+	.gpiod_lookup_tables = vexia_edu_atla10_9v_gpios,
+	.init = vexia_edu_atla10_9v_init,
 	.use_pci = true,
 };
 
diff --git a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
index 63a38a0069ba..2204bbaf2ed5 100644
--- a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
+++ b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
@@ -127,7 +127,7 @@ extern const struct x86_dev_info nextbook_ares8_info;
 extern const struct x86_dev_info nextbook_ares8a_info;
 extern const struct x86_dev_info peaq_c1010_info;
 extern const struct x86_dev_info whitelabel_tm800a550l_info;
-extern const struct x86_dev_info vexia_edu_atla10_info;
+extern const struct x86_dev_info vexia_edu_atla10_9v_info;
 extern const struct x86_dev_info xiaomi_mipad2_info;
 extern const struct dmi_system_id x86_android_tablet_ids[];
 
-- 
2.49.0

[PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

[Hans de Goede]

The Vexia EDU ATLA 10 tablet comes in 2 different versions with
significantly different mainboards. The only outward difference is that
the charging barrel on one is marked 5V and the other is marked 9V.

Both are x86 ACPI tablets which ships with Android x86 as factory OS.
with a DSDT which contains a bunch of I2C devices which are not actually
there, causing various resource conflicts. Enumeration of these is skipped
through the acpi_quirk_skip_i2c_client_enumeration().

Extend the existing support for the 9V version by adding support for
manually instantiating the I2C devices which are actually present on
the 5V version by adding the necessary device info to
the x86-android-tablets module.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 .../platform/x86/x86-android-tablets/dmi.c    | 12 ++++
 .../platform/x86/x86-android-tablets/other.c  | 60 +++++++++++++++++++
 .../x86-android-tablets/x86-android-tablets.h |  1 +
 3 files changed, 73 insertions(+)

diff --git a/drivers/platform/x86/x86-android-tablets/dmi.c b/drivers/platform/x86/x86-android-tablets/dmi.c
index e43d482b17a3..278c6d151dc4 100644
--- a/drivers/platform/x86/x86-android-tablets/dmi.c
+++ b/drivers/platform/x86/x86-android-tablets/dmi.c
@@ -179,6 +179,18 @@ const struct dmi_system_id x86_android_tablet_ids[] __initconst = {
 		},
 		.driver_data = (void *)&peaq_c1010_info,
 	},
+	{
+		/* Vexia Edu Atla 10 tablet 5V version */
+		.matches = {
+			/* Having all 3 of these not set is somewhat unique */
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
+			/* Above strings are too generic, also match on BIOS date */
+			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
+		},
+		.driver_data = (void *)&vexia_edu_atla10_5v_info,
+	},
 	{
 		/* Vexia Edu Atla 10 tablet 9V version */
 		.matches = {
diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c
index 74dcac8d19d7..f7bd9f863c85 100644
--- a/drivers/platform/x86/x86-android-tablets/other.c
+++ b/drivers/platform/x86/x86-android-tablets/other.c
@@ -598,6 +598,66 @@ const struct x86_dev_info whitelabel_tm800a550l_info __initconst = {
 	.gpiod_lookup_tables = whitelabel_tm800a550l_gpios,
 };
 
+/*
+ * Vexia EDU ATLA 10 tablet 5V, Android 4.4 + Guadalinex Ubuntu tablet
+ * distributed to schools in the Spanish Andalucía region.
+ */
+static const struct property_entry vexia_edu_atla10_5v_touchscreen_props[] = {
+	PROPERTY_ENTRY_U32("hid-descr-addr", 0x0000),
+	PROPERTY_ENTRY_U32("post-reset-deassert-delay-ms", 120),
+	{ }
+};
+
+static const struct software_node vexia_edu_atla10_5v_touchscreen_node = {
+	.properties = vexia_edu_atla10_5v_touchscreen_props,
+};
+
+static const struct x86_i2c_client_info vexia_edu_atla10_5v_i2c_clients[] __initconst = {
+	{
+		/* kxcjk1013 accelerometer */
+		.board_info = {
+			.type = "kxcjk1013",
+			.addr = 0x0f,
+			.dev_name = "kxcjk1013",
+		},
+		.adapter_path = "\\_SB_.I2C3",
+	}, {
+		/*  touchscreen controller */
+		.board_info = {
+			.type = "hid-over-i2c",
+			.addr = 0x38,
+			.dev_name = "FTSC1000",
+			.swnode = &vexia_edu_atla10_5v_touchscreen_node,
+		},
+		.adapter_path = "\\_SB_.I2C4",
+		.irq_data = {
+			.type = X86_ACPI_IRQ_TYPE_APIC,
+			.index = 0x44,
+			.trigger = ACPI_LEVEL_SENSITIVE,
+			.polarity = ACPI_ACTIVE_HIGH,
+		},
+	}
+};
+
+static struct gpiod_lookup_table vexia_edu_atla10_5v_ft5416_gpios = {
+	.dev_id = "i2c-FTSC1000",
+	.table = {
+		GPIO_LOOKUP("INT33FC:01", 26, "reset", GPIO_ACTIVE_LOW),
+		{ }
+	},
+};
+
+static struct gpiod_lookup_table * const vexia_edu_atla10_5v_gpios[] = {
+	&vexia_edu_atla10_5v_ft5416_gpios,
+	NULL
+};
+
+const struct x86_dev_info vexia_edu_atla10_5v_info __initconst = {
+	.i2c_client_info = vexia_edu_atla10_5v_i2c_clients,
+	.i2c_client_count = ARRAY_SIZE(vexia_edu_atla10_5v_i2c_clients),
+	.gpiod_lookup_tables = vexia_edu_atla10_5v_gpios,
+};
+
 /*
  * Vexia EDU ATLA 10 tablet 9V, Android 4.2 + Guadalinex Ubuntu tablet
  * distributed to schools in the Spanish Andalucía region.
diff --git a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
index 2204bbaf2ed5..dcf8d49e3b5f 100644
--- a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
+++ b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
@@ -127,6 +127,7 @@ extern const struct x86_dev_info nextbook_ares8_info;
 extern const struct x86_dev_info nextbook_ares8a_info;
 extern const struct x86_dev_info peaq_c1010_info;
 extern const struct x86_dev_info whitelabel_tm800a550l_info;
+extern const struct x86_dev_info vexia_edu_atla10_5v_info;
 extern const struct x86_dev_info vexia_edu_atla10_9v_info;
 extern const struct x86_dev_info xiaomi_mipad2_info;
 extern const struct dmi_system_id x86_android_tablet_ids[];
-- 
2.49.0

Re: [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 11:20:15AM +0200, Hans de Goede wrote:
> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> significantly different mainboards. The only outward difference is that
> the charging barrel on one is marked 5V and the other is marked 9V.
> 
> Both need to be handled by the x86-android-tablets code. Add 9v to
> the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
> symbols to prepare for adding support for the 5V version.
> 
> All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

And period :-)

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 11:20:16AM +0200, Hans de Goede wrote:
> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> significantly different mainboards. The only outward difference is that
> the charging barrel on one is marked 5V and the other is marked 9V.
> 
> Both are x86 ACPI tablets which ships with Android x86 as factory OS.
> with a DSDT which contains a bunch of I2C devices which are not actually
> there, causing various resource conflicts. Enumeration of these is skipped
> through the acpi_quirk_skip_i2c_client_enumeration().
> 
> Extend the existing support for the 9V version by adding support for
> manually instantiating the I2C devices which are actually present on
> the 5V version by adding the necessary device info to
> the x86-android-tablets module.

...

> +	{
> +		/* Vexia Edu Atla 10 tablet 5V version */
> +		.matches = {
> +			/* Having all 3 of these not set is somewhat unique */
> +			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
> +			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
> +			/* Above strings are too generic, also match on BIOS date */
> +			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
> +		},

Oh, this is unfortunate matching and quite fragile. Do we have other matching
mechanisms in place in addition to this?

I am not against this change, but perhaps we need also add something to check,
say, CPUID before looking into this table or so?

> +		.driver_data = (void *)&vexia_edu_atla10_5v_info,
> +	},

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

[Hans de Goede]

Hi,

On 7-Apr-25 12:32, Andy Shevchenko wrote:
> On Mon, Apr 07, 2025 at 11:20:16AM +0200, Hans de Goede wrote:
>> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
>> significantly different mainboards. The only outward difference is that
>> the charging barrel on one is marked 5V and the other is marked 9V.
>>
>> Both are x86 ACPI tablets which ships with Android x86 as factory OS.
>> with a DSDT which contains a bunch of I2C devices which are not actually
>> there, causing various resource conflicts. Enumeration of these is skipped
>> through the acpi_quirk_skip_i2c_client_enumeration().
>>
>> Extend the existing support for the 9V version by adding support for
>> manually instantiating the I2C devices which are actually present on
>> the 5V version by adding the necessary device info to
>> the x86-android-tablets module.
> 
> ...
> 
>> +	{
>> +		/* Vexia Edu Atla 10 tablet 5V version */
>> +		.matches = {
>> +			/* Having all 3 of these not set is somewhat unique */
>> +			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
>> +			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
>> +			/* Above strings are too generic, also match on BIOS date */
>> +			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
>> +		},
> 
> Oh, this is unfortunate matching and quite fragile. Do we have other matching
> mechanisms in place in addition to this?

Having both PRODUCT_NAME and BOARD_NAME set to "To be filled by O.E.M." is
actually pretty rare. Of all the DMI decode's which I've collected only
2 other devices have this. Usually at least on of the 2 is set to something
less generic even if that something is still sometimes not super useful itself
like "BayTrail".

So IMHO combined with the BIOS date this should be plenty unique IMHO.

Regards,

Hans

Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 01:22:31PM +0200, Hans de Goede wrote:
> On 7-Apr-25 12:32, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 11:20:16AM +0200, Hans de Goede wrote:

...

> >> +	{
> >> +		/* Vexia Edu Atla 10 tablet 5V version */
> >> +		.matches = {
> >> +			/* Having all 3 of these not set is somewhat unique */
> >> +			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
> >> +			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
> >> +			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
> >> +			/* Above strings are too generic, also match on BIOS date */
> >> +			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
> >> +		},
> > 
> > Oh, this is unfortunate matching and quite fragile. Do we have other matching
> > mechanisms in place in addition to this?
> 
> Having both PRODUCT_NAME and BOARD_NAME set to "To be filled by O.E.M." is
> actually pretty rare. Of all the DMI decode's which I've collected only
> 2 other devices have this. Usually at least on of the 2 is set to something
> less generic even if that something is still sometimes not super useful itself
> like "BayTrail".
> 
> So IMHO combined with the BIOS date this should be plenty unique IMHO.

Sounds like a relief to me. Thanks for digging into this!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[Hans de Goede]

Hi,

On 7-Apr-25 12:27, Andy Shevchenko wrote:
> On Mon, Apr 07, 2025 at 11:20:15AM +0200, Hans de Goede wrote:
>> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
>> significantly different mainboards. The only outward difference is that
>> the charging barrel on one is marked 5V and the other is marked 9V.
>>
>> Both need to be handled by the x86-android-tablets code. Add 9v to
>> the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
>> symbols to prepare for adding support for the 5V version.
>>
>> All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/
> 
> And period :-)
> 
> All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.

It feels a bit silly to send a v2 just to add a period to the commit msg.

Ilpo do you want me to send a v2 of this series?

Regards,

Hans

Re: [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 03:49:26PM +0200, Hans de Goede wrote:
> On 7-Apr-25 12:27, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 11:20:15AM +0200, Hans de Goede wrote:
> >> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> >> significantly different mainboards. The only outward difference is that
> >> the charging barrel on one is marked 5V and the other is marked 9V.
> >>
> >> Both need to be handled by the x86-android-tablets code. Add 9v to
> >> the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
> >> symbols to prepare for adding support for the 5V version.
> >>
> >> All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/
> > 
> > And period :-)
> > 
> > All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.
> 
> It feels a bit silly to send a v2 just to add a period to the commit msg.

I agree, it can be tweaked whilst applying, but I'm not the one in charge here
:-)

> Ilpo do you want me to send a v2 of this series?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[Ilpo Järvinen]

On Mon, 7 Apr 2025, Hans de Goede wrote:
> On 7-Apr-25 12:27, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 11:20:15AM +0200, Hans de Goede wrote:
> >> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> >> significantly different mainboards. The only outward difference is that
> >> the charging barrel on one is marked 5V and the other is marked 9V.
> >>
> >> Both need to be handled by the x86-android-tablets code. Add 9v to
> >> the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
> >> symbols to prepare for adding support for the 5V version.
> >>
> >> All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/
> > 
> > And period :-)
> > 
> > All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.
> 
> It feels a bit silly to send a v2 just to add a period to the commit msg.
> 
> Ilpo do you want me to send a v2 of this series?

No, you don't have to send a new version because of that. I'll try to 
remember to add the period there while applying but I won't have regrets 
if I fail to remember it, TBH. :-)

-- 
 i.

Re: [PATCH 1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

[Ilpo Järvinen]

On Mon, 07 Apr 2025 11:20:15 +0200, Hans de Goede wrote:

> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> significantly different mainboards. The only outward difference is that
> the charging barrel on one is marked 5V and the other is marked 9V.
> 
> Both need to be handled by the x86-android-tablets code. Add 9v to
> the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet
> symbols to prepare for adding support for the 5V version.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols
      commit: 3343b086c7035222c24956780ea4423655cad6d2
[2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data
      commit: 59df54c67be3e587e4217bddd793350fbe8f5feb

--
 i.